From patchwork Fri Jul 6 12:35:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10511511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2B30C600CA for ; Fri, 6 Jul 2018 12:35:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D32F2858B for ; Fri, 6 Jul 2018 12:35:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00429285FF; Fri, 6 Jul 2018 12:35:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ACE7C2858B for ; Fri, 6 Jul 2018 12:35:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A45496EFFA; Fri, 6 Jul 2018 12:35:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD9EA6EFFA for ; Fri, 6 Jul 2018 12:35:40 +0000 (UTC) Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MINTj-1fXIxX1Qdz-004C3D; Fri, 06 Jul 2018 14:35:32 +0200 From: Arnd Bergmann To: Bartlomiej Zolnierkiewicz Subject: [PATCH] omapfb: rename omap2 module to omap2fb.ko Date: Fri, 6 Jul 2018 14:35:07 +0200 Message-Id: <20180706123528.2729378-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:yqtm9EmNCwRfWGPZbrJYWyp2L68CCEbo4RiE4Fb1IRz4vH2bq8g X5+67i0e5Z/B+onI9jAA/xJrfb0k4FAhGPffgt2JzbVt3zvnbs5PlVAel4CpgsPHFTanfd2 DvLPcK/oXyTfAwKITbksPgBr5TNZNa8frqAZueAySNyjX5SzP5vGxIVnh9zMWNoE81udZAB jQSLMSmIWQLC3r7j7aFPA== X-UI-Out-Filterresults: notjunk:1; V01:K0:ipGVinzco3I=:LlUGQYRFc//nYMIRvxDSyl SyN4ZFwjSlPHLhPwzyEIoRGAPtzcXT7Q1ulpcJpAcOeq8r4s0m+5bojhtSKNOo/sO0dqXAEx4 hsu729iPWCI+PW4OJ3SJ5uoFlxzGR1mfB2Ch+ZEeIPzDExKNGPja06127x3hIkZ5tuXg++V0r oAOID4pbGR+ZvqSfB2sRlczVpufxw/YyqkXwMjI7UUGBgBGXmWedC9kp8DlCKTmY0K6oDADKb SkzbUgXqnYEnqgXi3NUqoOPJHhpBA15sngrfJ7yGJOmUsefyNkq9+Rs5znO8tdk7e68hcC89y H9juvOobqBDehcoMWPNXg5TbZc6cq01OOxb+g+a+5I6mvOS9xHGdHD2P0LmarzVlldwn+GcWa 9hpGaZ5O8vWRl6snDmtvbloZqbgIep5aqJLR2D4RPnfDFdd57Ix4Jz9qN7uB78eU23FiMCYIt wSdgikee0H81QvFM97lCzFUx48UQdBvaWleI1ZkNoHXmBXqxN6A3A4X6cN2nROTdcWPQbqXHQ FnvIm8JnNGnNCCD/Bu7fFQxpiJuDrVAn1Nrx9fdAZmKo3sPvRc8R9wRF2blKWNe3oY1T0pPK8 82dBgVlMoBOdbzpB5wcjwiIbv4muVBms+TZjsgj6yRe5wNce4ZLg5klMrkqiIVTemDAe9BzMY 2jb3CAZXGUoZcRc+o6D7GnAXHXYCnoVV5WhO9+1O6ydQ2EJIH4i9PP0HNT7SrSy8tZlI= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , linux-omap@vger.kernel.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP In a kernel configuration with both CONFIG_FB_OMAP=m and CONFIG_FB_OMAP2=m, Kbuild fails to point out that we have two modules with the same name (omapfb.ko), but instead fails with a cryptic error message like: ERROR: "omapfb_register_panel" [drivers/video/fbdev/omap/lcd_osk.ko] undefined! This can now happen when building a randconfig kernel with CONFIG_ARCH_OMAP1, as the omap1 fbdev driver depends on that, whiel the omap2 fbdev driver can now be built anywhere with CONFIG_COMPILE_TEST. The solution is to rename one of the two modules, so for consistency with the directory naming I decided to rename the omap2 version to omap2fb.ko. Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") Signed-off-by: Arnd Bergmann Acked-by: Tony Lindgren --- drivers/video/fbdev/omap2/omapfb/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/Makefile b/drivers/video/fbdev/omap2/omapfb/Makefile index 602edfed09df..f54c3f56b641 100644 --- a/drivers/video/fbdev/omap2/omapfb/Makefile +++ b/drivers/video/fbdev/omap2/omapfb/Makefile @@ -2,5 +2,5 @@ obj-$(CONFIG_OMAP2_VRFB) += vrfb.o obj-y += dss/ obj-y += displays/ -obj-$(CONFIG_FB_OMAP2) += omapfb.o -omapfb-y := omapfb-main.o omapfb-sysfs.o omapfb-ioctl.o +obj-$(CONFIG_FB_OMAP2) += omap2fb.o +omap2fb-y := omapfb-main.o omapfb-sysfs.o omapfb-ioctl.o