From patchwork Mon Jul 9 17:31:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10515353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6D344600CA for ; Mon, 9 Jul 2018 17:33:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5633E28DD2 for ; Mon, 9 Jul 2018 17:33:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4AB0E28DDB; Mon, 9 Jul 2018 17:33:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0C25B28DD2 for ; Mon, 9 Jul 2018 17:33:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1942C6E60E; Mon, 9 Jul 2018 17:33:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yb0-x241.google.com (mail-yb0-x241.google.com [IPv6:2607:f8b0:4002:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76F7D6E60E for ; Mon, 9 Jul 2018 17:33:45 +0000 (UTC) Received: by mail-yb0-x241.google.com with SMTP id a2-v6so7495852ybe.11 for ; Mon, 09 Jul 2018 10:33:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=NKhva+k9MOz3BPQrdva+VwI2nQ6lrNqX0ByEkWw8dp0=; b=M8mfW+G6bj1AzUKoPIiduITDM8iFBhaP+hvDy8uR1TU46dPur8FlTF5xDM51LY0k5O 49GRZ6956k/SM4SL3MnQvNUmX8Iaf/Q1n6POP8E8JuRzM5njPczgc5EUvZmIhN/MTO8r Q1su7K01D/I+tlsW07K5IcdLd9fDveYq2lavACrDq9TPbVW886TXBkhwtEKeTO5C7s3a Rf9wnNWau/vdNXLvaIDnIBTy8DTNRXTytflZort6sGgogueXniZtfl321JgZBI6P+mpB 2pVMfZmu6rkZjTPDE0pdK9CnR5BnF2GzcZN6ZNN2yuiceuL6quBI//L8zzTsVbon+wOq 7GVg== X-Gm-Message-State: APt69E23lRQVEpp7L0a/+B/fbCvHaklM0aj4+etNPf5aPCcBBWPNW4Ve oes4qqWEYUDRRWAFrqXNIbJVJA== X-Google-Smtp-Source: AAOMgpfiMYi6mQaXYkfOTVE2dfF8RZso+RpFkC0U7xnYaUBTjc5uetrLtLDZMOHHUbBYBnBJdKaVcg== X-Received: by 2002:a25:94c:: with SMTP id u12-v6mr11612313ybm.435.1531157624748; Mon, 09 Jul 2018 10:33:44 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id s206-v6sm5885495ywc.55.2018.07.09.10.33.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 10:33:44 -0700 (PDT) From: Sean Paul To: abhinavk@codeaurora.org, architt@codeaurora.org, chandanu@codeaurora.org, jsanka@codeaurora.org, jcrouse@codeaurora.org, ryadav@codeaurora.org, seanpaul@chromium.org, skolluku@codeaurora.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, airlied@linux.ie, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, nganji@codeaurora.org, hoegsberg@chromium.org, dovizu@chromium.org, robh+dt@kernel.org Subject: [PATCH 07/21] drm/msm/dsi: initialize postdiv_lock before use for 10nm pll Date: Mon, 9 Jul 2018 13:31:43 -0400 Message-Id: <20180709173200.238457-8-seanpaul@chromium.org> X-Mailer: git-send-email 2.18.0.203.gfac676dfb9-goog In-Reply-To: <20180709173200.238457-1-seanpaul@chromium.org> References: <20180709173200.238457-1-seanpaul@chromium.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Rajesh Yadav postdiv_lock spinlock was used before initialization for 10nm pll. It causes following spin_bug: "BUG: spinlock bad magic on CPU#0". Initialize spinlock before its usage. Signed-off-by: Rajesh Yadav Signed-off-by: Sean Paul Reviewed-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index c4c37a7df637..4c03f0b7343e 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c @@ -798,6 +798,8 @@ struct msm_dsi_pll *msm_dsi_pll_10nm_init(struct platform_device *pdev, int id) return ERR_PTR(-ENOMEM); } + spin_lock_init(&pll_10nm->postdiv_lock); + pll = &pll_10nm->base; pll->min_rate = 1000000000UL; pll->max_rate = 3500000000UL;