From patchwork Thu Jul 26 16:17:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546133 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5D2E5139A for ; Thu, 26 Jul 2018 16:18:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AF392A514 for ; Thu, 26 Jul 2018 16:18:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E95C2B88E; Thu, 26 Jul 2018 16:18:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E86362A514 for ; Thu, 26 Jul 2018 16:18:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C74F66E7CD; Thu, 26 Jul 2018 16:18:49 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10052.outbound.protection.outlook.com [40.107.1.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id E06E26E7CC for ; Thu, 26 Jul 2018 16:18:42 +0000 (UTC) Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:39 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Subject: [PATCH v2 05/10] drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:51 +0100 Message-Id: <20180726161756.1794-6-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e09337a-4bb6-4390-551f-08d5f3137341 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2552; 3:T8JzD9+yKGl1q81Akbn6WMiPfgEgUlp2AaLFNq3o0eLvUlxrlziWXjgYVax1cOZd/oT4pJBb7G4DU5f9ZLIbjQtzrvXM/J5bmklH2l2+1G0eVJkar3efaHAiv5gJWxZTYBbJZ3igfiZUt+LAkgRJtNgbIxI3I/+Kv1FX0tbQh8iw8MybIvsjRlDapat8FTppu1/zdoVX8uCk9Y1ryePRebdqx8sSIpj4VOgntDXaSDjmKz+5y4lP71GdL+sGHysl; 25:iM17UhEP7PicTXpCgQglOJIQ6e2DWAzIwzOlaIcza21p2R439hAwTDE+ZncJOlIt/m0LxHQxIUbnhjoBDTQ+7pXhHLXqqTIxps7AZeMU7ODxMyRBLl/C/AvfrYqRJf5yApTU+9UZKH/BUP7u6frwgrphemZwyuq5J8StADCGv2h2wsS7CSMgmfkZIu8X8JbD+pSqGX1A2WoNEHEIseQ4Qj8atE2Sv6S3+BaMJctPHw5yZ17Va3KNSepOoiW7GHq8lDJG2GsWwmxaO+W6BI9m/dd45zwzKqhKIdxaROuQN5vHTpupJX8NlaSMPfsTtpkZO6gAVuRzmVDF6uk+X30l7A==; 31:l/c/GfMteHCnZno2USS9vxqsBYEjiE3nOuHfbycYsRTxrK5SJdW1DXyc4qQv6iSEGZO7eK0my/VP6p1MSw4qx4KHHgTw8ZnB47tRCEV5aP7bb5Q8bg4jhloWo3th1V14M4rAssE9pkeKJlfd5xsuMbr4lC40HS5NJ6Vu7/9XPV5wS/TfJxcluRpABSREl49TBhaaXqYdW3HpjHLgxvKiK8fUHh6aXOH7yPoJd66NuHw= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2552; 20:CA7vTc1hQ65/v5RNd5pOivkFN4yfurt+1c1/C32yVjIbtlN22i8zHFGSciGQ48f9rfCHgB0jajt0B9DLdMzF5LWiPkJ4Q1wVaGiUtXrbr++d6FTUA46/ZG9R3ZeSiogqzz1yVoX5bKLIOkSTwYhIWdMAq5zei+U0Q4QFFxfKQEbVuYVTSvmK2w2z8Pt94H0N6hQgBsQyBxvZ6ZgEkchkBWDVfOrsByBXyuwbHSaTDF69lZ9caXFUXL/Ikxor3dZGiXv2Is1swi93UROS1Js8lyIu0uZT7WQ89wH5lIvfkWVxeYuyYYDtVQXWxwxbTy41a/7HtdzUCDTXHPcF2a4ZkA==; 4:CF2OCJtD9DtZMClhSJuPMaswmBVJuAkAVpLgY/E2QRFnV0RebGEvcF6CxtEaKhW62tqLqgThUMA48R5egfmVMYXguczJqcjVWAkWEdXtzkti6NYJc7RKvkEW3gFp0iNU15tuS7wNQxdt/FIdsyY+bE9ZAkU7Lncd7c0xpxZfjL3rdqSJlU+3EzbJh06wH3qGMhYzs7b/MpGRVuy1ZzB1nU/39/4TqU9ZSUWtJqjykOTCSZPb8LtJDfPhU7loG/8BjqgQVn99M+sXyNO9QKuyPSYZXYTudj6WEvEh0pi6ZxJhgBlgdP3RbWj+HBGPVSb2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DB6PR0802MB2552; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2552; H:e114479-lin.cambridge.arm.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0802MB2552; 23:jSDynYFxj74sKcBTZ0sAIohrAPEfzxb2xF+Fmes?= GeRqrMflw1Y+XKMsJrDNF9CmgRiucEwEL0vNHU0jvF3ej+keB99fs3bvn0e+ShQnztsKZMGZ8EgHfy2SpiAuhzyBfQeHTRSMdGn+vGbX7/DAznIUk9FMMfv00TsOS45oOuJZerRS/t2ViAsWnP51Zu8dNB231s+8QwFD2BVyyx1k4cs8kjNKATytvXES+t4jy0xv75xF84mtX4IwILNU/mTOo6Dh8oCD6S0tDwnbjptPhhVI5+EX4wVf3N/zmbzTKQXUpdleJJZHMvE4RotkIPBo6rh0dwE5LfFzpD9+Lnoq7Zl8zcTGyJJDOg7psiCR+fvx3YqQrcyTFscwKiW9tjSS9jaJEX9+jX62/nGQcKZt7zvxiiZ8I+1GsONA/AlLKUqSVukRNT2Lyx+FQ0Kggs5I9239Q2oIs2okVkNaWbpsjLnfD1iwdieel5+BcUYAXPMFRfKmIB8Ixxm1AxXhJebgbzBKdp53iPT7LxIHuMASUGNuwqaB94TlPqKw3Lan3Tn3e1G0tGw2Jk4JmEuvzoHTuk7LmmGRiQ/4X2Ir0xyHEU1ScoBHx7yaP1s8Z0ug3pg7BnnRm6bcGHEfLk8pbMjD1QN2ewFtUSjp0ya9NkPgGtX2Yx2lDBVqbh5oYaZ7+7kKVMOu6FvNmtVBRpyV7LWBovX5Jke2b4lp+gNqNAEmYD+MHgHuOuhdeEtjWZ67vHXp/jkfqcRZBEBdAPoINDfSGwIhwjAFp4CBNx2h4J8PySR5wIonU/HVFJUaOVJTT/TAKTr/zn8q7aFfW/5SAYrjpHAjUiB8EW3S8O+s62I4M/9wJzFWBu2xFPdvTIaw/enBIsSo5JbHtPh3edxrzmvUbNlYtaBrTZEpxKb57NJRQGxch0h7H1D/lnYsy+rfB3kM4yywaLyWPBLb2pTlNSUtCYrRX73ZfkoM9YR20Y4txkq5ovfIGrbBPhUgHH0/9CRCUTL8YIJToh//5RlMFfgyCE5G8evrd1mp4+8b6ZgCEqSRcLuOlLf0xv/gwI9sEI39XxfHhScafMslXMYWy5TLfAc3QMNx1hBhKtW67EDHrTxg5q0gfVaMQr7uynrJTL4MXTiP9Ax795dA2yxAx5OsK7EyC4t8ZP+Nx4A+OpXUyucuh2SGccGMXOHvYODHvxwZsbnta38Qaoi8gCFqiH8RDr94BCGZ1nwS11M+i+L6XcQHkuFB4Pi7dz6fORBZcwBo= X-Microsoft-Antispam-Message-Info: lhUD0kgzs4OKNC6m73cdltbBv/tN2kqjx+fWsvdomfN7Z/B+iPuf04MYP9syhi0ZgO/hsapnoOXUe9OZ7cTmHNdMdzCYjoomYUGb44h2wndlj66LUL3OB1gtazZL/gPUsR21i5tMDMukMw3IbecoI1cEAT7190Ju+PoNHrxvsJpmdHWLCB1HJoszd6ipT6T8eh3T1s4x8Bn4jHwgJsMZhajoMNRPGVad2Scc/jjIBQc2x3yU0Y45m97WTYpiblLiT+y0jEs4RpIPqNZit0KIYb6Mk6eJjaQwTtrpl5F3ox+g30EgmkK8Cwo3fYBb5wMJtS+XhYzwra/LJqRbjQRZ9k/uTyHmV6hpCmfbycmIfNQ= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2552; 6:u1JkEGksPSVSkT6vgOKvhdMvj8dW9/lYQ4DqKAgHWehLYSOFdqUJ8vOkdkthaYsG1lV+rk6cp/NMOnVgQEDs00XKSraKmtp/V5lGhG2MkPZ8UAPLkQsX9M2LtsUYLNL3heNWmqeRfV/qIKv+XVhk4lzMVpmFUFdNdGYLwegDgvGCA0Lg9x1+1W/nngeu6ZQXEmR0xC4DkVu83Dmq8DlCudG1QSugHOmivKGeSRYK6sUCkRlRcbBcB45laO1vd/71yGGfIdWo1IhNO2Dps43bkqKuKi/FXWS965brnEAd+E+dxgFX9qcjpteVyq14TC6xnILmzUsANOtxT1AJvlIgaPN1rSjZp6NKBAK+NKRiDeGWc5vhKx/rnt7IpVR11Dhqu2qPpf6KBT/IjYeiSDakKECl2CeKGOsWMMwHWoY6iM2ETgCXp19moOS8YYwYabnZbDuUlMM5ZWLADpmxjuX6mQ==; 5:FMjwJffSQuJ+Vh8Ep+gXDNTKWbTIpzTiZcvKznVPYH/2f7RSZYffQfZKTZwCLh/PTQ8BucHQYRHiG7h7FYP9HpNlOpniTiUeZDY884owve7wWDxY09yXc8KDiWWAjp9e9HOF8q/xMk3ICPt5PG43D0Km8ONmlLfF2KM/9vwsK3o=; 7:03NJ2JAJd4hJKiJOVcIV2JBeYIigHlxv2GDZCL0zIxGaB5Dlb3RI1qztazVmQODvS96AwrbRcfSfRHCQqz/WknlnZzfs4TOp6ywbzHMaYMvK/0OPvqDjm4Atmx/OU6PutaFjBXHiJCNdYkaGowz6Wf8+fLx0KZgt9ydYus/2NBJ+4itU6p6cUttYJ8b5qJEe7msOUgwAeWFi7drtpbNT+jHuIf3xkeyg/Q1IRHk0FNjR9pPVJMmY+RyGb1T2mrKZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:39.2181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e09337a-4bb6-4390-551f-08d5f3137341 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Alexandru Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c index eb9915da7dec..681328fbe7de 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c @@ -139,8 +139,7 @@ static void exynos_drm_plane_reset(struct drm_plane *plane) exynos_state = kzalloc(sizeof(*exynos_state), GFP_KERNEL); if (exynos_state) { - plane->state = &exynos_state->base; - plane->state->plane = plane; + __drm_atomic_helper_plane_reset(plane, &exynos_state->base); plane->state->zpos = exynos_plane->config->zpos; } }