| Message ID | 20180730192326.GA31354@jordon-HP-15-Notebook-PC (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Remove drm_fbdev_cma_set_suspend() | expand |
On Tue, Jul 31, 2018 at 12:53 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote: > drm_fbdev_cma_set_suspend() is not getting called from > any other places. If there is no plan to use it in future > we can remove this API. > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- Any comment on this patch ? > drivers/gpu/drm/drm_fb_cma_helper.c | 15 --------------- > include/drm/drm_fb_cma_helper.h | 1 - > 2 files changed, 16 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index 186d00a..4c283d9 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -516,21 +516,6 @@ void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma) > EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event); > > /** > - * drm_fbdev_cma_set_suspend - wrapper around drm_fb_helper_set_suspend > - * @fbdev_cma: The drm_fbdev_cma struct, may be NULL > - * @state: desired state, zero to resume, non-zero to suspend > - * > - * Calls drm_fb_helper_set_suspend, which is a wrapper around > - * fb_set_suspend implemented by fbdev core. > - */ > -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state) > -{ > - if (fbdev_cma) > - drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state); > -} > -EXPORT_SYMBOL(drm_fbdev_cma_set_suspend); > - > -/** > * drm_fbdev_cma_set_suspend_unlocked - wrapper around > * drm_fb_helper_set_suspend_unlocked > * @fbdev_cma: The drm_fbdev_cma struct, may be NULL > diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h > index d532f88a..52f09dc 100644 > --- a/include/drm/drm_fb_cma_helper.h > +++ b/include/drm/drm_fb_cma_helper.h > @@ -32,7 +32,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev, > > void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma); > void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma); > -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state); > void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma, > bool state); > > -- > 1.9.1 >
On Tue, Jul 31, 2018 at 12:53:26AM +0530, Souptick Joarder wrote: > drm_fbdev_cma_set_suspend() is not getting called from > any other places. If there is no plan to use it in future > we can remove this API. > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> cma version of fbdev helpers are indeed getting subsumed by fbdev helpers at large, so this makes sense I think. Applied for 4.20, thanks for your patch. -Daniel > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 15 --------------- > include/drm/drm_fb_cma_helper.h | 1 - > 2 files changed, 16 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index 186d00a..4c283d9 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -516,21 +516,6 @@ void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma) > EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event); > > /** > - * drm_fbdev_cma_set_suspend - wrapper around drm_fb_helper_set_suspend > - * @fbdev_cma: The drm_fbdev_cma struct, may be NULL > - * @state: desired state, zero to resume, non-zero to suspend > - * > - * Calls drm_fb_helper_set_suspend, which is a wrapper around > - * fb_set_suspend implemented by fbdev core. > - */ > -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state) > -{ > - if (fbdev_cma) > - drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state); > -} > -EXPORT_SYMBOL(drm_fbdev_cma_set_suspend); > - > -/** > * drm_fbdev_cma_set_suspend_unlocked - wrapper around > * drm_fb_helper_set_suspend_unlocked > * @fbdev_cma: The drm_fbdev_cma struct, may be NULL > diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h > index d532f88a..52f09dc 100644 > --- a/include/drm/drm_fb_cma_helper.h > +++ b/include/drm/drm_fb_cma_helper.h > @@ -32,7 +32,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev, > > void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma); > void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma); > -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state); > void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma, > bool state); > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index 186d00a..4c283d9 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -516,21 +516,6 @@ void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma) EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event); /** - * drm_fbdev_cma_set_suspend - wrapper around drm_fb_helper_set_suspend - * @fbdev_cma: The drm_fbdev_cma struct, may be NULL - * @state: desired state, zero to resume, non-zero to suspend - * - * Calls drm_fb_helper_set_suspend, which is a wrapper around - * fb_set_suspend implemented by fbdev core. - */ -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state) -{ - if (fbdev_cma) - drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state); -} -EXPORT_SYMBOL(drm_fbdev_cma_set_suspend); - -/** * drm_fbdev_cma_set_suspend_unlocked - wrapper around * drm_fb_helper_set_suspend_unlocked * @fbdev_cma: The drm_fbdev_cma struct, may be NULL diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h index d532f88a..52f09dc 100644 --- a/include/drm/drm_fb_cma_helper.h +++ b/include/drm/drm_fb_cma_helper.h @@ -32,7 +32,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev, void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma); void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma); -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state); void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma, bool state);
drm_fbdev_cma_set_suspend() is not getting called from any other places. If there is no plan to use it in future we can remove this API. Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- drivers/gpu/drm/drm_fb_cma_helper.c | 15 --------------- include/drm/drm_fb_cma_helper.h | 1 - 2 files changed, 16 deletions(-)