From patchwork Sat Aug 4 16:15:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10555797 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 55BEF13BB for ; Sat, 4 Aug 2018 16:16:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44D9729C0C for ; Sat, 4 Aug 2018 16:16:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3786329CF5; Sat, 4 Aug 2018 16:16:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DBCEA29C0C for ; Sat, 4 Aug 2018 16:16:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCF3F6E149; Sat, 4 Aug 2018 16:16:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10053.outbound.protection.outlook.com [40.107.1.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB0106E146 for ; Sat, 4 Aug 2018 16:16:13 +0000 (UTC) Received: from e114479-lin.cambridge.arm.com (217.140.106.49) by AM5PR0802MB2547.eurprd08.prod.outlook.com (2603:10a6:203:a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.14; Sat, 4 Aug 2018 16:16:09 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Subject: [PATCH v3 04/10] drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Sat, 4 Aug 2018 17:15:24 +0100 Message-Id: <20180804161530.12275-5-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> References: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.106.49] X-ClientProxiedBy: DB6P189CA0005.EURP189.PROD.OUTLOOK.COM (2603:10a6:6:2e::18) To AM5PR0802MB2547.eurprd08.prod.outlook.com (2603:10a6:203:a0::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23c1f8b4-6e40-49ac-e42b-08d5fa2597d7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0802MB2547; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0802MB2547; 3:zvgcXUHcMCpCcFFwDypLBTaITNyA0tdIld951mwvWUhm+KUl34GAwX9PzOzfwGg5IRW3JnFZgMR73ZThQX6669/jZalxjz3OaRQkNFtJZpdMjp/6MoOGeGclgEfYVDj6vDQKz9v2k4pqbz1MxIkxnR29BcaZTEmptdrpNwTGuze6/elFtuZenVvwJv07NB83czoqJ9+WAC1B5MCZBWcQ07IBmdnI8XY6HABg7b34u4CMI5Sx8d0xY5YpbjOYVtRt; 25:qzLl4XvwfUnLI8oMW948SpcR04IiGceTpqAuz0p9vqsAlojP78EKvPC10pa+lxGs2+mHnaU5rPubXtd3V/jFLxKWW804wLt8KB9ZjpEC8LjuZlyfdpEJRZehgb5BX8jilmhDDBDHgx8wV5/AaLmvpU/2Dp1kcTx0SWMiBWAh3VxVBWzoWMFexpKU+RGCZ4vapfgQhmI7DnZD9bIeWgxvCcgkacwkvKHoXDKGsNEMf9JjYGPNAVmX72teSY4JQhpFJXIQRkeVlMfalJxuOxs5wf8hBH3mjmHnoNL1bwvYTyhHanuokW90/R57Mf9nu1VRpG+ZZEzKTcahpzeeFg8EVw==; 31:MvWUx4qMB3Av5sweBfonIY+FP6L6LIYKsJsxRNruDJVOJdmkNmXamJ7qJFHNQlmeTpF+14RbA8MR6K8hBDOFVp1+au/g1a5D+1dSEvXS2Tl8tc1Udip2jd/0gV8z00O3uWrgZEC8/MK23jyCSAo7Eyzk/bmPTYxMFM2TruSS7pZwzkVjQbhJjHs/RnIjWWJu65YjWwahw971rq+tMnOwCzCoW/muCihInHiQ6VFCKcU= X-MS-TrafficTypeDiagnostic: AM5PR0802MB2547: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; AM5PR0802MB2547; 20:8dJc97xqHeG3Vh1hPq1NAaRaJDKoDz0To/m1h1WjtPFeFz3GG3GEwXIHOeQTafFuOE94tWTVV0YqOPm0eF2Xdz4XUdQnW1bWIkXKpcYTXxaSxAZJfzGu/cBwq3rADAe6/zEIkEcC8/p93oFcI02lRSxdU7PYF+9FRMDV2+FOdVsrUnLeVCzlteWR2LGha5uFTTtw7c0MnfjFZLQk8fEAUx5lfqslW+sOe0fq99Yl8Yn3+BoFtD1yR7+TTLHKds6AQuaSyEAB1U1JUL5e6YeCfPgY6tr5DzBpgLlf9D1Y3giguiBuhDnbfKRFWfIh77Y1J9zuyn5dmcumkFtwyNjSnQ==; 4:sQBUBFnyv/OcgmvruArWmfR5/r26x+kDWch9dNYkEEru+EYoeMBEyYL9l5f8851X3FAMQiMM2C1LkOpS1crhp18t8aZ1DExBkDXA9ywRAoOck5MBf95M1SCFjF60W5Sq5Qq5A2nWyTh1K/JQzPSAT63NijI1GFdTCpM1s0JmMAsxU7zCeLmMCnKRhYmZ/HLMlXFLScGK0qi9Ymhpso5aaz3ofvu2bcJben4hyQ+yp5nNCV6meyDmu2VCEojcXY2AmWDTfMmVopzWVS2ZyiXWeVALQVvlY7L4KEBjVAvohL8t3WLsEATnP2Cs1GoM/00+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0802MB2547; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0802MB2547; X-Forefront-PRVS: 0754F7E325 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(346002)(366004)(396003)(376002)(136003)(39860400002)(189003)(199004)(51416003)(86362001)(76176011)(7736002)(4326008)(66066001)(47776003)(52116002)(97736004)(7696005)(305945005)(25786009)(16526019)(186003)(105586002)(6116002)(3846002)(956004)(106356001)(7416002)(5660300001)(446003)(1076002)(11346002)(26005)(6666003)(2616005)(7406005)(478600001)(53936002)(72206003)(68736007)(486006)(8936002)(36756003)(50226002)(316002)(50466002)(81166006)(476003)(16586007)(81156014)(48376002)(386003)(2906002)(8676002)(6486002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0802MB2547; H:e114479-lin.cambridge.arm.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0802MB2547; 23:gUQPoqdCNEvc3W/8WBNjMN4Y3Ky2kV0LIWKVGjq?= 7qrmsRj5cBnlcF7L2KsAgv9mVI1haGl/IQl07va5tE3P3b8zlPN5ba4DZpzUooWXHKivRcGaqnoXk2C/vynUsMrXaFpC+p5LiQ+TYoxNeaEMmX0h9HtiuDm54Ypzf+dFwCZW+nt2TQpCV10rRcbgk9joUTl6y0Qr2Jgar0EGk1kUipCDbtj81lq0+XMsgmAwgQtOUVhs3B6jhnm+qh3ynMby0OdsZpKbASWONsLUrz6a3Nx9dH4mNQW+5PU7LkkfNyag0hUXDPFXkBwEkdDEpgC0vh857EK+bU0e5hClXYjLiFVnvl1AkYQeka1lWtF1IOdGKQTgg6CueKxLrz0UwODg4tCW6QNZx/HlqpcekXlCChGP5HPnJwjPWTtP9gRCIxSsWDnIQKU6SPgOEl1FshQ05BM8MqGgWIGrz6hXyxEqZOq1yPjg7hF0qNnYc508BlDwKKii/g0R2BgxE1tois2BHb3iVfTR2p+0s1loTCI69VajlN5bxDeKUVjJaAV/Bp5oqQtX58h9HP1rngYKDsmPPFZopMbYqVkJGYilgk32EFoZ5Eop5YT+wUMTnwSJfghA4P6434YluHuex8iHInX21np4XSMWyOpH28Z5oSTjuXdIKm2nLvkuej6oXoB7J4Gtr3HRaMpYCikfzbZfNj5rCT3OGbp/w+1sbJBImCxN3Dla8gKHSOOe+wTvxG/X+bZQSlYvC9FC9CwS76D6PoA7cTUIgacv0eL+m1Uo7vqxp6zn202rafd12mjYTMpMut/7+XUjb5IffjlUtASveRuNMzGjmU+avWTS8XJGlfwEBMxMMzSMXtYQgQ2lnuOQ5qULSwKgbSfNUG0hzeYDPZxFclLcxkEAj/ZNfwsb0Xmx49OQTIfxTfDw3DsG1+fKrFLxgfrRrzwbu+HpieiyTBQ+HGupcxnzr0BJNcn8kBABGJ0ekuJ8Dik5jrNBc91kzi+BUu36/aSrZMAV2q8OIH7Yi3yAWrJjZmhK+Bww7OFqHuPy/cHGbUCoSBfQi9sv0zm3bsSS1myny4q6CuyAg4pwCHcbKt0dy7YhkMK9iGRX0pwIx+Nu4hY8WJuaCzfjoQ+RvM2exluaSr5dcj4PQ6DO7CSqKDAgk5lcjgjhmVjLoKOypcPoa2JBnfqVjyubrSyCUwFXdMKhoyV96w0Qcg0Z1B537MIs8AgMisi1IWXIKtD73ZRO/h4e69vf+bEdTnhTfA+Wl0W2rmRNpmi2gNEHg X-Microsoft-Antispam-Message-Info: TPFhNBPN/BWdEll67fZbB5HM4mSjmD2TtmwqS4WXtfqjuSR78+7Ai/9ZH4wuN17/lnqDWTBQZM796EdTLB7P/6b/oDBmPmCKyxT3eaYlclHBhn1Sdre5ojzt7pDOKD/w2WRr00mIjIR75GNZBH1u3+qZVBnRNkZBj7UF3RUI5E0d1NHGTEzBwvzSQpIhZndzvU9pJ2EowQO2lbO3ThOPRj3v0tE73jiN5jkGWR0JWJj2XkxCI9ytBIx93foWYefZ7cEIXnMm5Mposu/Ftw9H/GVjeZd6mrIVfIgYBxqXarNLZMKSL/5lCD/yyorkTuuwNSObB0JQB9NpCtFNT8nlb5Ce68aQQ40SxilfS9viKJk= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0802MB2547; 6:FnaCZvK6tZRvuGhGBjTY9OVBwiXFoBhDn57AzhTGdwuzGOsV6NkiejN6fQP+VUltTjJj+okautEk0f7NkqObXfdO6/dlXQov30jkUanbc/7iNdZH7n0McHAIexfX3N3nVYoYRGKUUALRXXr1p5Q4PCpM9YsegKwDO+0UZ3RRSDLu3QhFRHtV+aCzj5LLocRxjH9iqoZqz9iJsNItonTWYPl/ohl9TZVe1nnytO0ZqIinG710jzgVFcsLfTOi1Zzd57vYo1jxVVl8xFYzWQeDLqbElfBNLmCp/oSYsrUJfp8RAG9iDBDrId/UIRgsCsNiGjThyFeUaH/Qe2XIUYoUd6uR7Zs73D1TBWFPIZ4dqYWVXhJPtZ3ahIxCPfh9DzQOAwGcaR3fvPJDUxVVkv10qSqDKQPMWvxv9omh3oTcuEVpLWyS0o/7XLIFBOHinU+09y6Su4yalyeXGVodVwseyw==; 5:OS0v8jQMJAjmsKGMnv4CUzNSmbSe/+2Vi+y2WvUSulukitSC8zPwr3xRKysvEl6NjRIP6etHG/Hx7DrlA0RqtGcqpsfob8NJfiXKzjzgRylV1r/KAfSH0Ft+Vp6t3qjZkUO17eGFlUqRqyqw43j5kN3SqDG4ytcaEDQ4K1VyIzY=; 7:iggMg64va4/tIqczTJptrISe/cGmXDGZ5LCvcOG15W6CUrJZ8fhGUCkZMkKoCN+agYs3LFO2MsCCQq4H/sf5NC1J+XTdudzD3cSlvbH/JWEnKUJ5b79OW1xnyW8HDTN8SzfhcXS6tuuVAUDnqxJ70BXh8/Cyatovcpf7Ypj066mOGznMchR77yJnQHCCBESMK9YmTXHxU9YPMojj1PZDdCcuelq/1FXNiR6qZPPiJoCMkaO/vH80+OtcE1s1jNcS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2018 16:16:09.9105 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23c1f8b4-6e40-49ac-e42b-08d5fa2597d7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2547 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Alexandru Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. __drm_atomic_helper_plane_reset initializes the alpha property to its max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, so nothing changes regarding the alpha value. Acked-by: Boris Brezillon Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c index 04440064b9b7..9330a076e15a 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -942,10 +942,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p) "Failed to allocate initial plane state\n"); return; } - - p->state = &state->base; - p->state->alpha = DRM_BLEND_ALPHA_OPAQUE; - p->state->plane = p; + __drm_atomic_helper_plane_reset(p, &state->base); } }