From patchwork Fri Aug 10 17:50:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10562967 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB75B14E2 for ; Fri, 10 Aug 2018 17:51:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B8E9C2BE49 for ; Fri, 10 Aug 2018 17:51:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AAA3B2BE57; Fri, 10 Aug 2018 17:51:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56F792BE49 for ; Fri, 10 Aug 2018 17:51:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6229C6E0EC; Fri, 10 Aug 2018 17:51:16 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40044.outbound.protection.outlook.com [40.107.4.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D13F6E0EC for ; Fri, 10 Aug 2018 17:51:14 +0000 (UTC) Received: from e114479-lin.cambridge.arm.com (217.140.106.52) by HE1PR0802MB2556.eurprd08.prod.outlook.com (2603:10a6:3:e1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.17; Fri, 10 Aug 2018 17:51:07 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, gustavo@padovan.org Subject: [PATCH] drm: Clarify DRM_MODE_REFLECT_X/Y documentation Date: Fri, 10 Aug 2018 18:50:31 +0100 Message-Id: <20180810175031.5956-1-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: MA1PR01CA0079.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::19) To HE1PR0802MB2556.eurprd08.prod.outlook.com (2603:10a6:3:e1::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4e35f87-82ff-45a2-998b-08d5fee9dbca X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0802MB2556; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2556; 3:hPhmPFFLE/pp3/MPwB8FQa4mD5I19k6t219cYGq3R30pB3rJQPCU3hx3iHRXyiEO5N3diIcm5GCtu7tDmYmDVLjYhUO3IQ196D80iGKAGp66hoOd/AhJQckp6NP85xil8v4kyTgCm8Tg5mvUOUY60o2SDJsAZEI99PlhH6GcZv3NrekcBdVra88jt2LuJ67aDZX77zqesSntLoXehqS+hHsZglc6Mnif/qyzZop6uIroVSxF7SYnjKe6m4H3njaG; 25:nLlTkWY3f4Ck369oOogKHVZCzjTD5b5GL5efdquADInyqO7VXBGik9pqJezcbOLVxsSYVWmlHIxxhgCVGMIJl4SaQxl0jKrhDSD2FrzuFNuhuhyrmwzDYitU0NRgu/w2jgZHcw906SiR49WBgODvDG9M7IrjnPo/zr5jzbB2ISsXvaOUfdXDMqGanctG+yVOGVNdtpSPzZn2JjzfeNqNZGL2siGUuIGtQfOdihlhI5LiBXNgjd4wQxudmWHUIil2RR1h4xG138RODSrNkPnYHemqiRYKtT7jrG2WMhBDk/9bKqVpI4qCRnpQYkMItIxgw2dcSrTUvLGCIhpIpu2phQ==; 31:5z1KC7nTrjldnxlQ56H2wQWdzaWPC8DhDrrO0l3ZGH84uOgh7uf5Syg6HEr3t70Vax/GJVcDvxNJdk14Kxafz3QZfV6/dAI6DQtAC572pV/BFYzwPoG0frHbpV2BHxgrGC3P/HvabBmXOIWtqbVouJsxGCUuzwbaFVlmfXOYPX8pgCxFLBC3riy5onHW15lg0wlypAilBwpMArk2oD8lgUe7ssnLg0QnT2DGTclAE7I= X-MS-TrafficTypeDiagnostic: HE1PR0802MB2556: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2556; 20:5lPFv8W8KN0clx2FpYW9XUcgoQYDk/Ypgvttw4NG1anymp+GCRUw9iowQNNM4KTHVwioitLs+pDWmbhhlg3ngNCRsoQHeu0CxGmKTbRw56NmxwJzw664VurAL+7I2OBAc/KsDz/0dIkYskHQTvVcOK19OgQq1IkJFMa8lVUdvhLUIx9VA/GYf+qHUrY0oVD0lqoYi6X0Q1daWx3cy4T0y4WgVvI0UdLGOQfjulQWXotcXJlai7Tw0GJejpfpm09fQHKSoupa1Ce0rJdCw+htQMxVxaYM/8yjo2daaYiASlzA0OlUvlcaBBa6rn98e4ACJkOwtnpZ5ehKvbTchKzGKA==; 4:rji2zVLJUdQAwAE7FlY8fQfUd5n69Di8RPJBh66RNIWXYNweip4JFogk6UWpTv7T/01OXNe8D56rgRfe5VvyBo3YelhpMfM8bjnlt1bjoemOOxaeI0+J52VnO9Z74vAPebuIpnaao3oknqP8AuVyrVdZXrK47GsikkPoKAfCXoHjVtGynRTxhnttkgzWTjFCS7leyjZzU/SmBwWXzPCJlnEPcKxdhALJnfCokA5vxUtulPblaHG/7s2W5ezYBCxrVbh3EZHjqXb/x+05hLIXpf3gaMK2ubL5jAPR7HyecGNBxu2nraqkX0lVMfXGK/UN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0802MB2556; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0802MB2556; X-Forefront-PRVS: 07607ED19A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(346002)(39860400002)(376002)(396003)(366004)(136003)(189003)(199004)(72206003)(26005)(6116002)(16586007)(68736007)(16526019)(4326008)(478600001)(8936002)(25786009)(1857600001)(8676002)(186003)(81166006)(81156014)(316002)(3846002)(86362001)(50226002)(6486002)(53936002)(66066001)(47776003)(5660300001)(6666003)(52116002)(51416003)(7696005)(97736004)(956004)(1076002)(36756003)(2616005)(106356001)(14444005)(386003)(48376002)(7736002)(305945005)(50466002)(2906002)(105586002)(486006)(476003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2556; H:e114479-lin.cambridge.arm.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0802MB2556; 23:7xC4Qy9yt8aiLwYDJev2IOeYQ9jRwJk437xYuXA?= HJIHF4pskDI6VD72irMBQOHH/sL6KAB412KgES8z38BZNmBu/aML0Q0znrgt47TfSrjTR/moS2hKS8SPEluKvvXrlsIzngR55mzUmx3FL2x+g9jUobaZ/MSYv7ACmcmherITFYHwdykSllRvK1CRbPgGPhY+Ikdd/AVdcuWD0Fhb7tfHntft79gEPlpV84paIiBl9zpp3TNebCqsZhYUTOjtTycmvo+aWiaW6qks4t2T8uJ7WYQvo7iEmtrw3pdbKophDejOgkQjXHVR3wZQBOA1wFTHMBh2tZJCIDV0InSiX9ljJCG3Lpt5n9UBo9/GH5tkdG86K0EwfBmle8m8t6OC3yQzjiW+ZVQw2pKf+Ob8IiulY7FM32NhhCBtZta42LlbpFdxBefxRN2bI8bFUtUhpWWy763fIagogVBJOhxxw4Pd8uy/OKjuXFNDmyuKBIsE5M5nwlwyyOWEwrSFLla7LjoH0nGgik+wEXXATynSwP9/mWn3uAqvOYcwbM8e2yk3hnSlUEIDynx4IBribCMiJdgZZ9UH0fag7jBHlVMXXgm0zSGNLTyEx5bLsqnv35dtJyj6pbHi5k2OM/dPTO0Vm+fh7rV8W46H4jUG4GEXXAq5A+/0Gp/MNP+esrY0xpLNRRVrjrBYgsmOlYd036RbK4YslUERYYxRqP8VgA43qpXsJmEU5PKBhhaxRijLToEy+KcyLDxcytZIK0yLXNx8FeCmvYE7UVFQ2MVJQ777neG2cDmRKDWRYGpnq/VKUX5O1aukmfbpbZnFWvAlxVn/FOQToK2hUHuQxAqjLa9ZBD/PxAwKBTS17w0LeSHDOijuis/aVvl/JXiKu4FnrDQkm9xCtU7A52VN1Szuid2a6bdestqAEdFlRrWgLWDqPwFMozdmZziKNnOmIaWIuTqCf/JMAoBp5lakcj7QqdEUmdDHgmUu6RLjqvdjXYXxWPlBwLL1x6WmyH5mNhfeg3TJt9VcOv1JwxeApRQ0ZNWJ4UKIQsh19ZycHcnWhTaIdbjjPVE1wqDjC/6ZI2syJT+msOkNdWEWhBpc5qMDzSLJBMURPkA60AsOjIFl3nDDZe8XeF+57MaVwV4b9smqin2ofSHYLeQytmt7Cl9bUSbwXDk+E3ypV+WG2YgU3GWhJRb9CGOyDBPDhHohieMSt4AB66Pqd/MDsorzNqjn/Ag5BvR7lj6oB1Y1aWcuHjcD1CRc= X-Microsoft-Antispam-Message-Info: uPTKsML88oeok1yl1nD0/erxL5Rp1eDSlt37YLQmC89BpLG4n/xu/xNc3A8CsasCbZuvjwgC8+CX48rhXwh05IOEUGob2dhm1lJfdjeIa8BDwQ5aFy4HGczIPGUkYfjzWTIZKdoZAcxZ1jis2yFWDih+agiRutpIFyxR0GgOaWs+mmVutAI2pZxHGQ4qhgBgULRzui0+7ch7gdoGkA7WA5KZju8pnfZE2ZR8qy9jMamwzJUUZO9SSacwlmM5WweYIwWOENmqp/3v7Ifm9PQOuK/liayQ1h53o2Yoe23AWGGwG+JjXWDCSgLawLU/MIFUmKofm/ssIImaakF/RV5zAIRvtX5yoeGfA9rW3YdvKfI= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2556; 6:YWsVPkJPjaTdyl+BLSVyxbdCVBdQNBvSr8lHfUhuNXWsRN8tiBlBZSwnv32l05Gk9Y+t1dw5H2+luVFbT+ciOp2MyoHedxR3RWcRikTRaIhNuVEQ9w8MBD/JCeSxkIaJyYxCeeapSBWfP0+YzV0FHf/LAtEdD97pXEm7LFyGhO11Srf+KM3jeVjzoWD70WfAAC+S4BgLy3IJpLPDGDHff2IvpxNbUss1uHXPiOWT8R8GV/TnmiU2kuAdjlEjYMWANgBNykxz51OvZIgotdH0udHpQ1hCAkludaSlF17FMxfvjAC9jR/LY571aPvToCSEFaZGbqIioPxiurYw4v3PHNgu647iB9K15epyYWDSTKsFEwJ3fCztTjxNC3D/cucZ6Bht62KjsXwm//vBMbFDiu1lKkBtKtMKEXkfUHvr9rZD9cMz/AkatBEd7wUctMZhUydjOiq5fa9n6v8Hz1Cn9A==; 5:WobGWyOgXPocZu88NlHgNiUYofexepIwWq4to5t0XFaRd5EbNz09+O+DMgllfKD3jYsAoq77puTujo8Hy9q4u0LljpdX5aQM06UKBBfJeKu6fR9Fu6HF2UT6Pu84DQqhzuqu6lhFT0l6DZNbHHGdkTJKuKxMsyt22y0NYO5vNdY=; 7:bGdvBUAXanwg6excc99MwrkefvB3YKmibht5Xr+MUgdfZulxIpsHpvW3+R5u0y0Qeb/wkI9n+SmrVn99DDlRTT29PTLEDI+eSQqVLofPM5nIwaByKVUIsnR8KSE6xqGq8HWX7hnLITBVFlcSVMH3lsJjxQc4qvbUnKB3hmnWpbnpPEWfe35lHbNvFHZYSAEjqhdI8D+F0aIUaG2bx61+oNyvw2IyVcHmOzjov9fUoS76dbwADjsA0zgoLZbU8ca4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2018 17:51:07.9660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4e35f87-82ff-45a2-998b-08d5fee9dbca X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2556 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Alexandru Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear to me, so try to clarify that with a bit of ascii graphics. Signed-off-by: Alexandru Gheorghe Reviewed-by: Sean Paul Reviewed-by: Daniel Vetter --- include/uapi/drm/drm_mode.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 8d67243952f4..ac5de85c93eb 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -186,9 +186,18 @@ extern "C" { /* * DRM_MODE_REFLECT_ * - * Signals that the contents of a drm plane is reflected in the axis, + * Signals that the contents of a drm plane is reflected along the axis, * in the same way as mirroring. * + * DRM_MODE_REFLECT_X + * |o | | o| + * | | -> | | + * | v| |v | + * + * DRM_MODE_REFLECT_Y + * |o | | ^| + * | | -> | | + * | v| |o | * This define is provided as a convenience, looking up the property id * using the name->prop id lookup is the preferred method. */