diff mbox series

drm: Describe pixel_blend_mode in drm_plane_state

Message ID 20180831150934.202332-1-sean@poorly.run (mailing list archive)
State New, archived
Headers show
Series drm: Describe pixel_blend_mode in drm_plane_state | expand

Commit Message

Sean Paul Aug. 31, 2018, 3:09 p.m. UTC
From: Sean Paul <seanpaul@chromium.org>

Adds docs for pixel_blend_mode in drm_plane_state. Fixes the warning
found by kbuild test robot:

htmldocs: include/drm/drm_plane.h:189: warning: Function parameter or member 'pixel_blend_mode' not described in 'drm_plane_state'

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Lowry Li <lowry.li@arm.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 include/drm/drm_plane.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Maarten Lankhorst Aug. 31, 2018, 3:24 p.m. UTC | #1
Op 31-08-18 om 17:09 schreef Sean Paul:
> From: Sean Paul <seanpaul@chromium.org>
>
> Adds docs for pixel_blend_mode in drm_plane_state. Fixes the warning
> found by kbuild test robot:
>
> htmldocs: include/drm/drm_plane.h:189: warning: Function parameter or member 'pixel_blend_mode' not described in 'drm_plane_state'
>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Lowry Li <lowry.li@arm.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  include/drm/drm_plane.h | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index 35ef64a9398b..16f5b66684ca 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -117,6 +117,13 @@ struct drm_plane_state {
>  	 * details.
>  	 */
>  	u16 alpha;
> +
> +	/**
> +	 * @pixel_blend_mode:
> +	 * The alpha blending equation selection, describing how the pixels from
> +	 * the current plane are composited with the background. Value can be
> +	 * one of DRM_MODE_BLEND_*
> +	 */
>  	uint16_t pixel_blend_mode;
>  
>  	/**

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Sean Paul Aug. 31, 2018, 3:48 p.m. UTC | #2
On Fri, Aug 31, 2018 at 05:24:46PM +0200, Maarten Lankhorst wrote:
> Op 31-08-18 om 17:09 schreef Sean Paul:
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > Adds docs for pixel_blend_mode in drm_plane_state. Fixes the warning
> > found by kbuild test robot:
> >
> > htmldocs: include/drm/drm_plane.h:189: warning: Function parameter or member 'pixel_blend_mode' not described in 'drm_plane_state'
> >
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Lowry Li <lowry.li@arm.com>
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> >  include/drm/drm_plane.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> > index 35ef64a9398b..16f5b66684ca 100644
> > --- a/include/drm/drm_plane.h
> > +++ b/include/drm/drm_plane.h
> > @@ -117,6 +117,13 @@ struct drm_plane_state {
> >  	 * details.
> >  	 */
> >  	u16 alpha;
> > +
> > +	/**
> > +	 * @pixel_blend_mode:
> > +	 * The alpha blending equation selection, describing how the pixels from
> > +	 * the current plane are composited with the background. Value can be
> > +	 * one of DRM_MODE_BLEND_*
> > +	 */
> >  	uint16_t pixel_blend_mode;
> >  
> >  	/**
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Applied to -misc-next, thanks Maarten!

Sean

>
Alexandru-Cosmin Gheorghe Sept. 3, 2018, 10:37 a.m. UTC | #3
Hi Sean,

On Fri, Aug 31, 2018 at 11:09:25AM -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> Adds docs for pixel_blend_mode in drm_plane_state. Fixes the warning
> found by kbuild test robot:
> 
> htmldocs: include/drm/drm_plane.h:189: warning: Function parameter or member 'pixel_blend_mode' not described in 'drm_plane_state'
> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Lowry Li <lowry.li@arm.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>

Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>

> ---
>  include/drm/drm_plane.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index 35ef64a9398b..16f5b66684ca 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -117,6 +117,13 @@ struct drm_plane_state {
>  	 * details.
>  	 */
>  	u16 alpha;
> +
> +	/**
> +	 * @pixel_blend_mode:
> +	 * The alpha blending equation selection, describing how the pixels from
> +	 * the current plane are composited with the background. Value can be
> +	 * one of DRM_MODE_BLEND_*
> +	 */
>  	uint16_t pixel_blend_mode;
>  
>  	/**
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
index 35ef64a9398b..16f5b66684ca 100644
--- a/include/drm/drm_plane.h
+++ b/include/drm/drm_plane.h
@@ -117,6 +117,13 @@  struct drm_plane_state {
 	 * details.
 	 */
 	u16 alpha;
+
+	/**
+	 * @pixel_blend_mode:
+	 * The alpha blending equation selection, describing how the pixels from
+	 * the current plane are composited with the background. Value can be
+	 * one of DRM_MODE_BLEND_*
+	 */
 	uint16_t pixel_blend_mode;
 
 	/**