From patchwork Thu Sep 6 15:14:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10590715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1B1AA5A4 for ; Thu, 6 Sep 2018 15:18:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 009392AD97 for ; Thu, 6 Sep 2018 15:18:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E8C082AD9F; Thu, 6 Sep 2018 15:18:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 75EF52AD97 for ; Thu, 6 Sep 2018 15:18:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFF036E6DA; Thu, 6 Sep 2018 15:18:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3ACAD6E6DA for ; Thu, 6 Sep 2018 15:18:37 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id n2-v6so11843360wrw.7 for ; Thu, 06 Sep 2018 08:18:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9BujHZF6teQVZu0BN9Vz44korLhI6ALKPJCULXoIpJc=; b=kms+BRmxvJpLlzDCXjmJHwmyyE2zXXq0ttzvQ3ZWFM+6kJiFk9PrGf5ORLDSvBKHr7 q44e80uD3pZmMJCZQCMY/svKZJcBv2Jz3L+26jSLnskweZWZngOdfi6r+MagXIaSuiIU 1+MzsaH2qKdWFbLYyEFQoev7W/hNV9vY93NjQ3O5OQM0/dKpo9E9UOJMSIgObb1M4jcx N/bgwtd4UXrDj4RMj/zKw9BZUWwn816ShzpGqVjt2sKD6LMwtA4eVhirzistZ85jrSsX U7ukMyihVdmDK79IgNcTGBkv7o/vW/ueX7mp1LJV7+5fTyouxUJ4Opt5NzmG1dE6kN/3 wW6g== X-Gm-Message-State: APzg51AakJISTBY45HXKzOXy3+UzyMHH147tIIU1STaGb44NyyMGm2d2 lsM62Ve0E6sgHmY1faEdN0CCQO89 X-Google-Smtp-Source: ANB0VdYmIRmU+pUWsIlxabxQVR/f7COOHQVYgIcSbPO3FiL1YlplFs55Sw9hFTgmUJMwhGj0USb+kw== X-Received: by 2002:a5d:404a:: with SMTP id w10-v6mr2674868wrp.147.1536247115711; Thu, 06 Sep 2018 08:18:35 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id f13-v6sm6047521wrt.9.2018.09.06.08.18.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 08:18:34 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH libdrm] intel: annotate the intel genx helpers as private Date: Thu, 6 Sep 2018 16:14:07 +0100 Message-Id: <20180906151407.9744-1-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.18.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Engestrom , Lucas De Marchi , Rodrigo Vivi , emil.l.velikov@gmail.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov They're used internally and never meant to be part of the API. Add the drm_private notation, which should resolve that. Cc: Eric Engestrom Cc: Lucas De Marchi Cc: Chris Wilson Cc: Rodrigo Vivi Fixes: 4e81d4f9c9b ("intel: add generic functions to check PCI ID") Signed-off-by: Emil Velikov Acked-by: Lucas De Marchi --- intel/intel_chipset.c | 4 ++-- intel/intel_chipset.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index d5c33cc5..5aa4a2f2 100644 --- a/intel/intel_chipset.c +++ b/intel/intel_chipset.c @@ -44,7 +44,7 @@ static const struct pci_device { INTEL_SKL_IDS(9), }; -bool intel_is_genx(unsigned int devid, int gen) +drm_private bool intel_is_genx(unsigned int devid, int gen) { const struct pci_device *p, *pend = pciids + sizeof(pciids) / sizeof(pciids[0]); @@ -66,7 +66,7 @@ bool intel_is_genx(unsigned int devid, int gen) return false; } -bool intel_get_genx(unsigned int devid, int *gen) +drm_private bool intel_get_genx(unsigned int devid, int *gen) { const struct pci_device *p, *pend = pciids + sizeof(pciids) / sizeof(pciids[0]); diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index 9b1e64f1..63ddde7a 100644 --- a/intel/intel_chipset.h +++ b/intel/intel_chipset.h @@ -330,8 +330,8 @@ /* New platforms use kernel pci ids */ #include -bool intel_is_genx(unsigned int devid, int gen); -bool intel_get_genx(unsigned int devid, int *gen); +drm_private bool intel_is_genx(unsigned int devid, int gen); +drm_private bool intel_get_genx(unsigned int devid, int *gen); #define IS_GEN9(devid) intel_is_genx(devid, 9) #define IS_GEN10(devid) intel_is_genx(devid, 10)