From patchwork Mon Sep 10 17:29:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10594625 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 994366CB for ; Mon, 10 Sep 2018 17:30:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 817942933A for ; Mon, 10 Sep 2018 17:30:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7558E2933F; Mon, 10 Sep 2018 17:30:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 19FA52933A for ; Mon, 10 Sep 2018 17:30:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 249A589DBC; Mon, 10 Sep 2018 17:30:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00061.outbound.protection.outlook.com [40.107.0.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2A9E89DBC for ; Mon, 10 Sep 2018 17:30:22 +0000 (UTC) Received: from e114479-lin.cambridge.arm.com (217.140.106.53) by HE1PR0802MB2554.eurprd08.prod.outlook.com (2603:10a6:3:e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.15; Mon, 10 Sep 2018 17:30:11 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, maarten.lankhorst@linux.intel.com, liviu.dudau@arm.com, brian.starkey@arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, gustavo@padovan.org, ayan.halder@arm.com, daniel.vetter@ffwll.ch Subject: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation Date: Mon, 10 Sep 2018 18:29:46 +0100 Message-Id: <20180910172946.18539-1-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-Originating-IP: [217.140.106.53] X-ClientProxiedBy: MWHPR17CA0054.namprd17.prod.outlook.com (2603:10b6:300:93::16) To HE1PR0802MB2554.eurprd08.prod.outlook.com (2603:10a6:3:e1::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1721900d-96c9-4bbd-0b60-08d61743120c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0802MB2554; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2554; 3:Sqj5keq72P5AtFzuEDgGHl2jUdK/F9yGPUII572gt69ids5A6qR/JbtBepjGC7WeOA6geesDHkqz3amyLyhvGFKUMCrrmp3uoSb3VdimL/H6KYpZdzTJXsG5bWlFUyZavLYXjaaUoY0B2L+LUiF/RnE3uDNagrDfCqGgAZlspUWntha6Hdr+qvygNJYGSa25767DumOx8PANRFkRO/vpCDNmhIsbFfAgRmGF/rwok1man4WE6xSUQsYCbTzpPeN7; 25:5sUqoeywnsg8JGDOr8pRcF4bnahsTcxUF1NCdUrqoVI2FOrUkUmsCikDoAqex4FAmBtevM4M8h0mRsO/T63z+y4NJmA1Zz2Spp7SApiWUtASW7tzIzhYUa7Mik8cJ0MA80RazqbU1osvwgTD1vFgNfKKsazXxc7ADIO0BtBP1VlngsaYgCsAZ6/2e47Qk91uS6iJVtWECCRsizDcogyLNMLVrUZ05+eC7ZgEuPDdMtJhMYB8xvJcWV/RWLNFyzU6zIHleYXJNqcS7rwV3AUAfIPbCgfm8vyWr36wGrpcRiZ2LG+cbdPPxXOQqWuYPyPCR7LWGiERUggC2eHfoSmrgQ==; 31:RYahhr/MOHSkLYGPl5H9UwoKHIQPc316quMFFb1zYq1iB/nAm/R3FnmXlDlAGzCRSRIktKRRpZfjFGbkBtp71Ug/9jBsTczsJmpb3WGR0sattu3dXppTX++5CkXJZeZ9gQSF2kxTZ+sXoFsepm/x7OCXZ7fpea43E4GbncVrwqNtNBJb1ZtKt8HwiCOJN9UVZeRA5OHbMngCiBbnnaoMImMPEzCaxsUpOub70r5jG7w= X-MS-TrafficTypeDiagnostic: HE1PR0802MB2554: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2554; 20:rEf5jjqGqnCED1cDp2g3BTsXKbd6EuF5qX6Qz1+Rfutrh+Ji4xFIYaoWA75Sze7qdZEFWwrqXkJRNJfiz78MNF6ry7LITdtfZ5rQqPXGBYJiMHgUfRbV7IZ9r+AMnpqpiXbFkfyi8EsDouCkDwplZQpzQpZu726WCQZukgZKGwzoCOot3dG2sR/DIfFzIGlW8H5JxpqDlOWwsxwSZJ+I7VmGU5hZFHb2EEad5jTVJxpRpEdaseKiOV/8z710+BoO3QwrAbIFczDBAxQvfMuaJ6WYSHCu0IjpL+0ecypwlV31EwOztVdqy/zviwTcmZfnE97yKPpwJLsZjfmoMcChBFhLzXwhx0W9j1M5sSXMRft+XkuUidwSghCHqJYg1XEK52kde/EIDfxiZ741sNPuW/pK2uZOHmv8kxz+XlszFT8=; 4:rF4pP3EHR8EIpBx5PFyH5DuQUjXOz6HofnEGyR1HclYTifx8z1uX+GYLgai11wG1rKd6O3zf1joNK6QR9ODL7UmhKPif98l4azBo6rv0GedWsLbwjPo8e+6jGW8l5Ilfwfx6rOZ5uFyw+24MfDO3YotHGjBK4XY91iOf2MWBacOUT8+MOBI6VHGmS3jb8w2n3yLmtkIg4xoIJ/ilhI/EvlJfONr3oQX9LxgZs3OcUSK9pyXy2EmAtX+G4+dsc8+oKGdqY24zgJrg2FJXLR+N1CNHAZ6sUNF1K40FhzKWgmkvfZNY8GdDbnnBzjhIlDfr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301075)(93006095)(93001095)(3002001)(10201501046)(3231344)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699050); SRVR:HE1PR0802MB2554; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0802MB2554; X-Forefront-PRVS: 07915F544A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(396003)(346002)(39860400002)(199004)(189003)(478600001)(72206003)(476003)(26005)(68736007)(186003)(50466002)(50226002)(305945005)(2616005)(7736002)(16526019)(956004)(8936002)(48376002)(1076002)(25786009)(2906002)(4326008)(8676002)(486006)(6346003)(7696005)(47776003)(316002)(52116002)(51416003)(6486002)(36756003)(66066001)(6666003)(53936002)(14444005)(106356001)(97736004)(81166006)(5660300001)(16586007)(386003)(105586002)(3846002)(6116002)(575784001)(86362001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2554; H:e114479-lin.cambridge.arm.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0802MB2554; 23:XJP/cDbNaElJ/V0E3RxH3PUubRSjiSW1AbjafaS?= VI8GUgnCfJ8B3Nbz8iFpyyKAWxT2KIiGZU42cKXPpHv+Nx9V7FaIN6n2Mmrv8uzXk0kEyYvAp/zsD5C2qg4P0It+8HTp3I7a6JNJ1r8t7+xwwClrqCiT0rLbYdGadXfZRgQx1pi7PhUl+WNvLNbBUT+k7HK+O2VSaGkLZZoRbc3gb0yT6PWP3IyisgE6lMlAvK6fmpyUcsAanmE1ALpO46sCuklLPsPd+C0ZZWN1jWFXH+o9Od1jZS1vW8dF98goRu516NOl+HvKD1vp1QGKOwZRVSCfyf4vzZZKsvQs07oYFkJFGvS/oKYGWAf1hTkP95MFr1WqgtvcAhp2ZHnAyzIXCoqWC6pBvcux1jPlCsOg02nW8xaGAeqYWZN19dILXVcBj+eoIiE3bSUFy4rk8dNPGUAsYkxiMxpgkuE3pRdPMo5NwfUjxcnRtv8hl71nJF9kpfUlolRdBBbMEDdkcwZlFUaQIw6T5QBMJhxgWWfKMgh/gLmQBWmYFHHRGL7290FCbtAGKwmnmePXmlHZYVsPgYRgJkg92ZPzsazU7BgtD36vGTwLFofTAxd9BuU3RPkrGVOuTZHqSx8c8H5ufk9kO3wKCKOl+QXEbJREF6awZ70bT73VISSrepjVpPPM9itCooh6HuEjRRye+Rh/vf5/Suh3FEgalpfXvGmnObhtJp1FyrSjKzygrqxR7V36sTF4qsI9ttW8A8a9QGZt9pKGCGcqGjg6Kqt9LHEsDL17unq3ddBfJsJ5gDp7vePqGXh6CjRDlzY5qeeb3LBytfdJCiE6N/3jgJ/B/tGns84dnBtZwqZnM0NC7DPzoygwcHGvqyLX32UDHhAet4jdgqWlKpa15NTlnl+VEperI0yTVk5ghA/q0i3erLKaDE/pFu4O7rGb/K2DPY92CRQmDDrF03EEmxd/9uYtOb5uWb3lyNdcLyHNqvjF1mOnRLskzdAxutRq+XBHXNb/QHPRHKeUpdHGAfLHGi7f8ne8BA1muWg11Z8XwL0Yj0JYACnMDU40Fja5zH8E0fa/w+OQ/pNLuOPfQDgIC4BUSDEmRFQMOlm6CknyPjThNlJYboD/nHZIOVK8b5xNd9w5E+ApTErq34V/0WPuuNF94EmcODw6Gdc/qVXsT83pbmTeXXQn9AyM= X-Microsoft-Antispam-Message-Info: hXXfRmEVYRYKYEPaZ4kV2QjTpaZdUAwje7Js0vmWg8U8dUoPqC/tmZslFWRfvlhVCi1snj+yyvKNosEhwGm7QzX5SM3itjl+fgjkTmkFn0qPOve04WYX1CO1D4RBti6y2rhB6i63RkZgt+gB8W9F06USvpzwYlwZif8ikJP5AWkmrhbpFmmJVPocwzXXhPX9nTxl6lnyLQG9QbdJk72u+hWPaEaT4f4EbbmMkvCW1mrUBBz7cdyPZGQOEyw68oWUKfGBT30hoL87F4ovi2MUZnHBaHPO+LhKZ5gdcBbwC4FEl7QxX4AEqut25KOSxVMEGe2kPRXD6pFRqzibuNZaa6xSykiYlcaNVleNfqAorjs= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2554; 6:9EAciH9nDQIrpnEDcQHhEdOxGreOGjY+MWnPNrHX3pUyI90o6u6hM0p2unVsjVFLzCJswSeimaZptdJOyIBA4dQRwn5HN8nFePiPle7UCaQ0ndtoAZBU4jlSbIFBYfhPRnGrInsjsP+/imLdxt+iCDHBL1rFMGNP+H08sD75ih9xYxBm3IZ9GPYQ05uzT63s1wo9tWoRQR9Jc8pIh7sfXlPNuAKkX98XljGcqFG6R934Ew1cKjzYPV/tyaOI1IwSLnrKq55WfiLPdaDf0KKbbUKJ/G6s4riw87QsRE8Chy5bjebthzCNJwcQugPAnkqowSRVQI7sY/PI76prvvgihbQfIGH2mCUjYLv3Ww2Xd3VTpNlTH4dXnSGUEq+iNPJTrfmZ4Szoe4EPZNm+5qfPvVXkAeMyOBcrzICTUObCyidWZmdjKFX95OLuCSQne8igoeZEWzZoOhNdjtLPQMfEpA==; 5:rI9fsfDqBjZE8pqDrKLkWFv+daa3LtrKdtflE68snzOhQhI2UBxpo534d3pbdi2/WlgzMbKh55RI4Og77N6Q+VScYxXOktgKhr6FP1gGI8GzpZqhGxy/Hat32UsM31fRJzVI9diGYiJLYQyWgaa3lg0BW6Gm9JKAKpyYAOEEvn0=; 7:z2c9zAPLRaX1zu7X7grCP8PNSX6lc7ukFKT2VJRIBSuYmPMR1/VcL7Fgsab51wTQEXp/1mcjF81qi+WdAdIA6sDiMwgU9grzSFBodA+fnVjm5ZvabDYpf3sy8g8KmOzkFFRfYznpTZ63shMILS9fot2eQ+yrCIRHumiOnVA7Q3ATNQGHwR27QUd/8WI132EyLwbtZX6b5EK1df+7DGHvdu81OGdcgIxYAfn1lqkyk0nDRkRT3N9qo4ls+XBHJkdf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2018 17:30:11.0897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1721900d-96c9-4bbd-0b60-08d61743120c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2554 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Alexandru Gheorghe Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear to me, so try to clarify that with a bit of ascii graphics. Changes since v1: - Move the ascii graphics in the kerneldoc where all plane properties are already documented and make sure it's properly rendered, suggestested by Daniel Vetter. Signed-off-by: Alexandru Gheorghe Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_blend.c | 22 ++++++++++++++++++++++ include/uapi/drm/drm_mode.h | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index 402b62d3f072..92f75c5c93ac 100644 --- a/drivers/gpu/drm/drm_blend.c +++ b/drivers/gpu/drm/drm_blend.c @@ -101,6 +101,28 @@ * Without this property the rectangle is only scaled, but not rotated or * reflected. * + * Possbile values: + * + * "rotate-": + * Signals that a drm plane is rotated degrees in counter + * clockwise direction. + * + * "reflect-": + * Signals that the contents of a drm plane is reflected along the + * axis, in the same way as mirroring. + * + * reflect-x:: + * + * |o | | o| + * | | -> | | + * | v| |v | + * + * reflect-y:: + * + * |o | | ^| + * | | -> | | + * | v| |o | + * * zpos: * Z position is set up with drm_plane_create_zpos_immutable_property() and * drm_plane_create_zpos_property(). It controls the visibility of overlapping diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 8d67243952f4..d3e0fe31efc5 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -186,8 +186,9 @@ extern "C" { /* * DRM_MODE_REFLECT_ * - * Signals that the contents of a drm plane is reflected in the axis, + * Signals that the contents of a drm plane is reflected along the axis, * in the same way as mirroring. + * See kerneldoc chapter "Plane Composition Properties" for more details. * * This define is provided as a convenience, looking up the property id * using the name->prop id lookup is the preferred method.