From patchwork Thu Oct 4 09:09:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 10625747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B8DA313BB for ; Thu, 4 Oct 2018 09:09:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7CA828C6D for ; Thu, 4 Oct 2018 09:09:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C13928C95; Thu, 4 Oct 2018 09:09:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 63F5A28C6D for ; Thu, 4 Oct 2018 09:09:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69E166E58B; Thu, 4 Oct 2018 09:09:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lb2-smtp-cloud8.xs4all.net (lb2-smtp-cloud8.xs4all.net [194.109.24.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76B8D6E58B for ; Thu, 4 Oct 2018 09:09:07 +0000 (UTC) Received: from tschai.fritz.box ([212.251.195.8]) by smtp-cloud8.xs4all.net with ESMTPA id 7zcygC0KD0ZZE7zd4gjczB; Thu, 04 Oct 2018 11:09:06 +0200 From: Hans Verkuil To: linux-media@vger.kernel.org Subject: [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count Date: Thu, 4 Oct 2018 11:09:00 +0200 Message-Id: <20181004090900.32915-6-hverkuil@xs4all.nl> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181004090900.32915-1-hverkuil@xs4all.nl> References: <20181004090900.32915-1-hverkuil@xs4all.nl> X-CMAE-Envelope: MS4wfDuW7RS1VHuSI0MM4OdFe0KxeV8+bFnWqELeau4jqHewkfUrZ2GiisZ2SVuQENJRIqeIJG+YZd85AT5UOuwb4fzt2n6no5GF5q447QzxfemR/rbaI+1i DHHTkJvnR+JTzRhkLbNntlDML7Cp5CVRzFkwpW+BXTcCOhYND0rNIekrKlYz/irCAkAkACqYZLbTcgofRcr5QA9PZD5SuP6o6KNvOsBrpc7Zui9CCwoVK6vC YyK3jPY8C2JnXMlZrFjWOXusrMQSOMZBW6DmYb1FbaW5LyIMPv0bBzWkVEHtRyue X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Hans Verkuil , dri-devel@lists.freedesktop.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Hans Verkuil The HDMI_CEC_DBG_3 register does have a retransmit count, but you can't write to it, those bits are read-only. So drop the attempt to set the retransmit count, since it doesn't work. Signed-off-by: Hans Verkuil Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c index dee66a5101b5..00407f1995a8 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c @@ -280,9 +280,6 @@ static int hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 attempts, hdmi_write_reg(core->base, HDMI_CEC_INT_STATUS_1, HDMI_CEC_RETRANSMIT_CNT_INT_MASK); - /* Set the retry count */ - REG_FLD_MOD(core->base, HDMI_CEC_DBG_3, attempts - 1, 6, 4); - /* Set the initiator addresses */ hdmi_write_reg(core->base, HDMI_CEC_TX_INIT, cec_msg_initiator(msg));