From patchwork Fri Oct 26 10:13:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 10657195 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9BFE7109C for ; Fri, 26 Oct 2018 10:13:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88BD92BF84 for ; Fri, 26 Oct 2018 10:13:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7CFA52C217; Fri, 26 Oct 2018 10:13:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3B0C32BF84 for ; Fri, 26 Oct 2018 10:13:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D03056E444; Fri, 26 Oct 2018 10:13:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC7076E444 for ; Fri, 26 Oct 2018 10:13:45 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181026101344euoutp02cc2fad15027c149ed2053c632cb8dc44~hIP5jfA5V2364623646euoutp02b; Fri, 26 Oct 2018 10:13:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181026101344euoutp02cc2fad15027c149ed2053c632cb8dc44~hIP5jfA5V2364623646euoutp02b Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181026101344eucas1p2659f7be097722257ab27282b151930b9~hIP5G0J1v1773017730eucas1p2x; Fri, 26 Oct 2018 10:13:44 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 1C.11.04806.7D8E2DB5; Fri, 26 Oct 2018 11:13:43 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181026101343eucas1p21bb8caff42737b8907527f5d1617e2b0~hIP4SMRQm2053920539eucas1p2m; Fri, 26 Oct 2018 10:13:43 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-e3-5bd2e8d7cb59 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id BB.C3.04284.6D8E2DB5; Fri, 26 Oct 2018 11:13:42 +0100 (BST) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0PH700KN3B2PZ140@eusync3.samsung.com>; Fri, 26 Oct 2018 11:13:42 +0100 (BST) From: Andrzej Hajda To: Inki Dae Subject: [PATCH 2/2] drm/exynos/fbdev: do not skip fbdev init if there are no connectors Date: Fri, 26 Oct 2018 12:13:28 +0200 Message-id: <20181026101328.26242-2-a.hajda@samsung.com> X-Mailer: git-send-email 2.18.0 In-reply-to: <20181026101328.26242-1-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsWy7djPc7rXX1yKNji9Vtvi1rpzrBYbZ6xn tbjy9T2bxaT7E1gsZpzfx2Sx9shddgc2j/vdx5k8+rasYvT4vEkugDmKyyYlNSezLLVI3y6B K2NP6wqmgmMcFRsfHWZqYFzF3sXIySEhYCLxvWMWSxcjF4eQwApGiZbJTWwQzmdGicdTrjDC VDU0NTFBJJYxShw4f40FJCEk8J9RYvkZLxCbTUBT4u/mm2wgtoiAssSqfe3sIA3MApcYJdZc vQY2SVggSuLZ30nMIDaLgKrE8RvzweK8AhYS7cfXskJsk5d4eLwdKM7BwSlgKbG6mRNkjoTA R1aJQ60noC5ykXj58gMzhC0s8er4Fqh/ZCQ6Ow4yQdj1Ek0zrzBDNHcwSpxYvJwNImEtcfj4 RbBlzAJ8EpO2TWcGWSYhwCvR0SYEUeIh8efdEWi49DBKLHxwmHUCo+QCRoZVjOKppcW56anF xnmp5XrFibnFpXnpesn5uZsYgTF2+t/xrzsY9/1JOsQowMGoxMM74dvFaCHWxLLiytxDjBIc zEoivH7ACBXiTUmsrEotyo8vKs1JLT7EKM3BoiTOu2zexmghgfTEktTs1NSC1CKYLBMHp1QD o2yFbMy1Be8ZfD6eahE+NTX8dr5w8O7UVf46Hf/UF3rE3kpOuZS9+MoR4UKOuGYTlsnRQa1M 7zdsPLYyW7Rl637NuWue2d9d/dvIOFed6e6cuwEhJnYPb7QL3mKUaOjb0NrHe/n7H421Vos9 cls+J1xRvXX92UU+Zf/jWXtCS1d+v+PWOmtLihJLcUaioRZzUXEiABEB0watAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBJMWRmVeSWpSXmKPExsVy+t/xq7rXXlyKNjj9wMji1rpzrBYbZ6xn tbjy9T2bxaT7E1gsZpzfx2Sx9shddgc2j/vdx5k8+rasYvT4vEkugDmKyyYlNSezLLVI3y6B K2NP6wqmgmMcFRsfHWZqYFzF3sXIySEhYCLR0NTE1MXIxSEksIRRYtLHhWwQTiOTxN+nE1lB qtgENCX+br7JBmKLCChLrNrXzg5SxCxwhVHi94UJTCAJYYEoiWcHToE1sAioShy/MZ8RxOYV sJBoP76WFWKdvMTD4+1AcQ4OTgFLidXNnCBhIaCSS1/+MU1g5FnAyLCKUSS1tDg3PbfYUK84 Mbe4NC9dLzk/dxMjMDy2Hfu5eQfjpY3BhxgFOBiVeHgnfLsYLcSaWFZcmXuIUYKDWUmEt+ja pWgh3pTEyqrUovz4otKc1OJDjNIcLErivOcNKqOEBNITS1KzU1MLUotgskwcnFINjKZfmZ8u f9Wo3lDq93vvrpteLC6zGnkF53/Uuq+y1n6G27m+C8W/M2pn3dn4/8XlK7OCDWTeci331U4/ k/b/2pUj0govVgoEymxpM9E55piUfjavMC0xZu3q2xMXJMve/9cqPTPdKYvzpuJn7Rpv9lf+ z5a773rEHP6gKyXQhHtJgrF5sMpPLSWW4oxEQy3mouJEAGwbpGoLAgAA X-CMS-MailID: 20181026101343eucas1p21bb8caff42737b8907527f5d1617e2b0 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181026101343eucas1p21bb8caff42737b8907527f5d1617e2b0 References: <20181026101328.26242-1-a.hajda@samsung.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Szyprowski , linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Since connectors can be created dynamically, fbdev should be initialized even if there are no connectors at the moment. Otherwise fbdev will not be created even after connector's appearance. The patch fixes lack of fbdev on rinato and trats boards. Fixes: 6afb7721e2a0 ("drm/exynos: move connector creation to attach callback") Reported-by: Marek Szyprowski Signed-off-by: Andrzej Hajda Tested-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 918dd2c82209..01d182289efa 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -192,7 +192,7 @@ int exynos_drm_fbdev_init(struct drm_device *dev) struct drm_fb_helper *helper; int ret; - if (!dev->mode_config.num_crtc || !dev->mode_config.num_connector) + if (!dev->mode_config.num_crtc) return 0; fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);