From patchwork Thu Nov 29 15:52:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10704835 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6456513AD for ; Thu, 29 Nov 2018 15:52:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55A722F4B3 for ; Thu, 29 Nov 2018 15:52:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 49CEB2F4CF; Thu, 29 Nov 2018 15:52:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 06AE82F4B3 for ; Thu, 29 Nov 2018 15:52:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 172F16E52F; Thu, 29 Nov 2018 15:52:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 436DE6E536 for ; Thu, 29 Nov 2018 15:52:51 +0000 (UTC) Received: by mail-yb1-xb42.google.com with SMTP id g9-v6so923256ybh.7 for ; Thu, 29 Nov 2018 07:52:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5YbImJLgvXpHMCm9ocN1DSeQ3qJAm9X3astsJcqsRH8=; b=LE2xr4zyvceNMsVgl+sJGW1FPsRaBIsOkyPq39JJ63yX1I9aaFTpaDYggcUNLK1uM7 nbLf+602X5rwhoqLRbpVZ2VjTjpT+uDTwxOGotDde0KrPYVjg0oWObTP0WQ2OVt2ryFY eZ0q2UClXo79DVJUyDux4g9OS1zLZe4mxC9WLoMYSiRmEU6sNQ9DWi0xsmk+FPa7IIW0 mIKrNE1MloGRw3vzjiGp07g33WCAUTKSB1zcGk9SwSa5MXiiBViQGiDNKRXBlLbzhv1C JbHpYh+v30zd2JGHCZLjQ2SHbTErA3wapCvmhvMYtEDfgrHty9NuznxRR9GIW0PrtXH9 N7dg== X-Gm-Message-State: AA+aEWbYftHanAjjUUm0K1AUqLYs1Yl/BjxbAbfVArjC+4KlpWcQIyNR BDT0dqmTYLIclQ2S1w8PayUO4vKJPokT8Q== X-Google-Smtp-Source: AFSGD/WEIFOmCirwenIbKa1TTbSBTyHC/JhDTyV1nVKUWKftudwHNtNJPGDH4ge8Me8DhJtURVKXZQ== X-Received: by 2002:a25:7c83:: with SMTP id x125-v6mr1809399ybc.152.1543506770271; Thu, 29 Nov 2018 07:52:50 -0800 (PST) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id f191-v6sm988214ywh.98.2018.11.29.07.52.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 07:52:49 -0800 (PST) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst Date: Thu, 29 Nov 2018 10:52:40 -0500 Message-Id: <20181129155249.30096-1-sean@poorly.run> X-Mailer: git-send-email 2.20.0.rc0.387.gc7a69e6b6c-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, Maxime Ripard , David Airlie , Sean Paul , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul We should also get the drivers using the helpers. Seems like a good intermediate TODO item. Cc: Daniel Vetter Signed-off-by: Sean Paul Acked-by: Daniel Vetter --- Documentation/gpu/todo.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ab347dec50796..1a6dc586fb156 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -241,6 +241,18 @@ struct drm_gem_object_funcs GEM objects can now have a function table instead of having the callbacks on the DRM driver struct. This is now the preferred way and drivers can be moved over. +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate +--------------------------------------------------------- + +For cases where drivers are attempting to grab the modeset locks with a local +acquire context. Replace the boilerplate code surrounding +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and +DRM_MODESET_LOCK_ALL_END() instead. + +As a reference, take a look at the conversions already completed in drm core. + +Contact: Sean Paul, respective driver maintainers + Core refactorings =================