Documentation: drm: Remove dangling pointer from drm-mm.rst

Commit Message

Sean Paul Nov. 29, 2018, 3:55 p.m. UTC

From: Sean Paul <[e-mail]>

Fixes htmldocs build error:
Error: Cannot open file ../drivers/gpu/drm/drm_global.c

Fixes: 2bb42410b1bd ("drm: Remove drm_global.{c,h} v2")
Cc: Thomas Zimmermann <[e-mail]>
Cc: Christian König <[e-mail]>
Cc: Junwei Zhang <[e-mail]>
Cc: Alex Deucher <[e-mail]>
Cc: Maarten Lankhorst <[e-mail]>
Cc: Maxime Ripard <[e-mail]>
Cc: Sean Paul <[e-mail]>
Cc: David Airlie <[e-mail]>
Cc: Christian Koenig <[e-mail]>
Cc: Huang Rui <[e-mail]>
Cc: [e-mail]
Signed-off-by: Sean Paul <[e-mail]>
---
 Documentation/gpu/drm-mm.rst | 3 ---
 1 file changed, 3 deletions(-)

Comments

Christian König Nov. 29, 2018, 3:57 p.m. UTC | #1

Am 29.11.18 um 16:55 schrieb Sean Paul:
> From: Sean Paul <[e-mail]>
>
> Fixes htmldocs build error:
> Error: Cannot open file ../drivers/gpu/drm/drm_global.c
>
> Fixes: 2bb42410b1bd ("drm: Remove drm_global.{c,h} v2")
> Cc: Thomas Zimmermann <[e-mail]>
> Cc: Christian König <[e-mail]>
> Cc: Junwei Zhang <[e-mail]>
> Cc: Alex Deucher <[e-mail]>
> Cc: Maarten Lankhorst <[e-mail]>
> Cc: Maxime Ripard <[e-mail]>
> Cc: Sean Paul <[e-mail]>
> Cc: David Airlie <[e-mail]>
> Cc: Christian Koenig <[e-mail]>
> Cc: Huang Rui <[e-mail]>
> Cc: [e-mail]
> Signed-off-by: Sean Paul <[e-mail]>

Reviewed-by: Christian König <[e-mail]>

> ---
>   Documentation/gpu/drm-mm.rst | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
> index d0f3c6b032009..54a696d961a7c 100644
> --- a/Documentation/gpu/drm-mm.rst
> +++ b/Documentation/gpu/drm-mm.rst
> @@ -79,9 +79,6 @@ count for the TTM, which will call your initialization function.
>   
>   See the radeon_ttm.c file for an example of usage.
>   
> -.. kernel-doc:: drivers/gpu/drm/drm_global.c
> -   :export:
> -
>   
>   The Graphics Execution Manager (GEM)
>   ====================================

Sean Paul Nov. 29, 2018, 4:11 p.m. UTC | #2

On Thu, Nov 29, 2018 at 10:58 AM Koenig, Christian
<[e-mail]> wrote:
>
> Am 29.11.18 um 16:55 schrieb Sean Paul:
> > From: Sean Paul <[e-mail]>
> >
> > Fixes htmldocs build error:
> > Error: Cannot open file ../drivers/gpu/drm/drm_global.c
> >
> > Fixes: 2bb42410b1bd ("drm: Remove drm_global.{c,h} v2")
> > Cc: Thomas Zimmermann <[e-mail]>
> > Cc: Christian König <[e-mail]>
> > Cc: Junwei Zhang <[e-mail]>
> > Cc: Alex Deucher <[e-mail]>
> > Cc: Maarten Lankhorst <[e-mail]>
> > Cc: Maxime Ripard <[e-mail]>
> > Cc: Sean Paul <[e-mail]>
> > Cc: David Airlie <[e-mail]>
> > Cc: Christian Koenig <[e-mail]>
> > Cc: Huang Rui <[e-mail]>
> > Cc: [e-mail]
> > Signed-off-by: Sean Paul <[e-mail]>
>
> Reviewed-by: Christian König <[e-mail]>
>

Thanks for the review. Perhaps the best course of action for this
patch is to have Dave pick it directly and then we can backmerge it
into amdgpu/drm-misc-next from there? I could also spin a topic branch
that we could all merge.

Thoughts?

Sean

> > ---
> >   Documentation/gpu/drm-mm.rst | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
> > index d0f3c6b032009..54a696d961a7c 100644
> > --- a/Documentation/gpu/drm-mm.rst
> > +++ b/Documentation/gpu/drm-mm.rst
> > @@ -79,9 +79,6 @@ count for the TTM, which will call your initialization function.
> >
> >   See the radeon_ttm.c file for an example of usage.
> >
> > -.. kernel-doc:: drivers/gpu/drm/drm_global.c
> > -   :export:
> > -
> >
> >   The Graphics Execution Manager (GEM)
> >   ====================================
>

Christian König Nov. 29, 2018, 4:14 p.m. UTC | #3

Am 29.11.18 um 17:11 schrieb Sean Paul:
> On Thu, Nov 29, 2018 at 10:58 AM Koenig, Christian
> <[e-mail]> wrote:
>> Am 29.11.18 um 16:55 schrieb Sean Paul:
>>> From: Sean Paul <[e-mail]>
>>>
>>> Fixes htmldocs build error:
>>> Error: Cannot open file ../drivers/gpu/drm/drm_global.c
>>>
>>> Fixes: 2bb42410b1bd ("drm: Remove drm_global.{c,h} v2")
>>> Cc: Thomas Zimmermann <[e-mail]>
>>> Cc: Christian König <[e-mail]>
>>> Cc: Junwei Zhang <[e-mail]>
>>> Cc: Alex Deucher <[e-mail]>
>>> Cc: Maarten Lankhorst <[e-mail]>
>>> Cc: Maxime Ripard <[e-mail]>
>>> Cc: Sean Paul <[e-mail]>
>>> Cc: David Airlie <[e-mail]>
>>> Cc: Christian Koenig <[e-mail]>
>>> Cc: Huang Rui <[e-mail]>
>>> Cc: [e-mail]
>>> Signed-off-by: Sean Paul <[e-mail]>
>> Reviewed-by: Christian König <[e-mail]>
>>
> Thanks for the review. Perhaps the best course of action for this
> patch is to have Dave pick it directly and then we can backmerge it
> into amdgpu/drm-misc-next from there? I could also spin a topic branch
> that we could all merge.
>
> Thoughts?

My preference is that I pick it up and push it to Dave through Alex 
fixes push.

But just because the patch which broke this came the same way as well.

Either way works for me,
Christian.

>
> Sean
>
>>> ---
>>>    Documentation/gpu/drm-mm.rst | 3 ---
>>>    1 file changed, 3 deletions(-)
>>>
>>> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
>>> index d0f3c6b032009..54a696d961a7c 100644
>>> --- a/Documentation/gpu/drm-mm.rst
>>> +++ b/Documentation/gpu/drm-mm.rst
>>> @@ -79,9 +79,6 @@ count for the TTM, which will call your initialization function.
>>>
>>>    See the radeon_ttm.c file for an example of usage.
>>>
>>> -.. kernel-doc:: drivers/gpu/drm/drm_global.c
>>> -   :export:
>>> -
>>>
>>>    The Graphics Execution Manager (GEM)
>>>    ====================================
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Sean Paul Nov. 29, 2018, 4:21 p.m. UTC | #4

On Thu, Nov 29, 2018 at 11:14 AM Christian König
<[e-mail]> wrote:
>
> Am 29.11.18 um 17:11 schrieb Sean Paul:
> > On Thu, Nov 29, 2018 at 10:58 AM Koenig, Christian
> > <[e-mail]> wrote:
> >> Am 29.11.18 um 16:55 schrieb Sean Paul:
> >>> From: Sean Paul <[e-mail]>
> >>>
> >>> Fixes htmldocs build error:
> >>> Error: Cannot open file ../drivers/gpu/drm/drm_global.c
> >>>
> >>> Fixes: 2bb42410b1bd ("drm: Remove drm_global.{c,h} v2")
> >>> Cc: Thomas Zimmermann <[e-mail]>
> >>> Cc: Christian König <[e-mail]>
> >>> Cc: Junwei Zhang <[e-mail]>
> >>> Cc: Alex Deucher <[e-mail]>
> >>> Cc: Maarten Lankhorst <[e-mail]>
> >>> Cc: Maxime Ripard <[e-mail]>
> >>> Cc: Sean Paul <[e-mail]>
> >>> Cc: David Airlie <[e-mail]>
> >>> Cc: Christian Koenig <[e-mail]>
> >>> Cc: Huang Rui <[e-mail]>
> >>> Cc: [e-mail]
> >>> Signed-off-by: Sean Paul <[e-mail]>
> >> Reviewed-by: Christian König <[e-mail]>
> >>
> > Thanks for the review. Perhaps the best course of action for this
> > patch is to have Dave pick it directly and then we can backmerge it
> > into amdgpu/drm-misc-next from there? I could also spin a topic branch
> > that we could all merge.
> >
> > Thoughts?
>
> My preference is that I pick it up and push it to Dave through Alex
> fixes push.
>
> But just because the patch which broke this came the same way as well.
>

Yeah, unfortunately it's proliferated, and I'd rather not add hops to
getting drm-misc-next fixed. Let's just do a topic branch and set a PR
to Dave from that. We can both merge the topic branch asap and let
Dave pick it up at his leisure.

Sean

> Either way works for me,
> Christian.
>
> >
> > Sean
> >
> >>> ---
> >>>    Documentation/gpu/drm-mm.rst | 3 ---
> >>>    1 file changed, 3 deletions(-)
> >>>
> >>> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
> >>> index d0f3c6b032009..54a696d961a7c 100644
> >>> --- a/Documentation/gpu/drm-mm.rst
> >>> +++ b/Documentation/gpu/drm-mm.rst
> >>> @@ -79,9 +79,6 @@ count for the TTM, which will call your initialization function.
> >>>
> >>>    See the radeon_ttm.c file for an example of usage.
> >>>
> >>> -.. kernel-doc:: drivers/gpu/drm/drm_global.c
> >>> -   :export:
> >>> -
> >>>
> >>>    The Graphics Execution Manager (GEM)
> >>>    ====================================
> > _______________________________________________
> > dri-devel mailing list
> > [e-mail]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

Christian König Nov. 29, 2018, 4:26 p.m. UTC | #5

Am 29.11.18 um 17:21 schrieb Sean Paul:
> On Thu, Nov 29, 2018 at 11:14 AM Christian König
> <[e-mail]> wrote:
>> Am 29.11.18 um 17:11 schrieb Sean Paul:
>>> On Thu, Nov 29, 2018 at 10:58 AM Koenig, Christian
>>> <[e-mail]> wrote:
>>>> Am 29.11.18 um 16:55 schrieb Sean Paul:
>>>>> From: Sean Paul <[e-mail]>
>>>>>
>>>>> Fixes htmldocs build error:
>>>>> Error: Cannot open file ../drivers/gpu/drm/drm_global.c
>>>>>
>>>>> Fixes: 2bb42410b1bd ("drm: Remove drm_global.{c,h} v2")
>>>>> Cc: Thomas Zimmermann <[e-mail]>
>>>>> Cc: Christian König <[e-mail]>
>>>>> Cc: Junwei Zhang <[e-mail]>
>>>>> Cc: Alex Deucher <[e-mail]>
>>>>> Cc: Maarten Lankhorst <[e-mail]>
>>>>> Cc: Maxime Ripard <[e-mail]>
>>>>> Cc: Sean Paul <[e-mail]>
>>>>> Cc: David Airlie <[e-mail]>
>>>>> Cc: Christian Koenig <[e-mail]>
>>>>> Cc: Huang Rui <[e-mail]>
>>>>> Cc: [e-mail]
>>>>> Signed-off-by: Sean Paul <[e-mail]>
>>>> Reviewed-by: Christian König <[e-mail]>
>>>>
>>> Thanks for the review. Perhaps the best course of action for this
>>> patch is to have Dave pick it directly and then we can backmerge it
>>> into amdgpu/drm-misc-next from there? I could also spin a topic branch
>>> that we could all merge.
>>>
>>> Thoughts?
>> My preference is that I pick it up and push it to Dave through Alex
>> fixes push.
>>
>> But just because the patch which broke this came the same way as well.
>>
> Yeah, unfortunately it's proliferated, and I'd rather not add hops to
> getting drm-misc-next fixed. Let's just do a topic branch and set a PR
> to Dave from that. We can both merge the topic branch asap and let
> Dave pick it up at his leisure.

Works for me as well,
Christian.

>
> Sean
>
>> Either way works for me,
>> Christian.
>>
>>> Sean
>>>
>>>>> ---
>>>>>     Documentation/gpu/drm-mm.rst | 3 ---
>>>>>     1 file changed, 3 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
>>>>> index d0f3c6b032009..54a696d961a7c 100644
>>>>> --- a/Documentation/gpu/drm-mm.rst
>>>>> +++ b/Documentation/gpu/drm-mm.rst
>>>>> @@ -79,9 +79,6 @@ count for the TTM, which will call your initialization function.
>>>>>
>>>>>     See the radeon_ttm.c file for an example of usage.
>>>>>
>>>>> -.. kernel-doc:: drivers/gpu/drm/drm_global.c
>>>>> -   :export:
>>>>> -
>>>>>
>>>>>     The Graphics Execution Manager (GEM)
>>>>>     ====================================
>>> _______________________________________________
>>> dri-devel mailing list
>>> [e-mail]
>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
index d0f3c6b032009..54a696d961a7c 100644
--- a/Documentation/gpu/drm-mm.rst
+++ b/Documentation/gpu/drm-mm.rst
@@ -79,9 +79,6 @@  count for the TTM, which will call your initialization function.
 
 See the radeon_ttm.c file for an example of usage.
 
-.. kernel-doc:: drivers/gpu/drm/drm_global.c
-   :export:
-
 
 The Graphics Execution Manager (GEM)
 ====================================