| Message ID | 20181205195050.4759-7-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: imx: Use of_node_name_eq for node name comparisons | expand |
On Wed, Dec 5, 2018 at 1:50 PM Rob Herring <robh@kernel.org> wrote: > > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For instances using of_node_cmp, this has the side effect of now using > case sensitive comparisons. This should not matter for any FDT based > system which this is. > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Philipp, can I get an ack on this? I can commit it. Rob
Hi Rob, On Wed, 2019-02-13 at 12:07 -0600, Rob Herring wrote: > On Wed, Dec 5, 2018 at 1:50 PM Rob Herring <robh@kernel.org> wrote: > > > > Convert string compares of DT node names to use of_node_name_eq helper > > instead. This removes direct access to the node name pointer. > > > > For instances using of_node_cmp, this has the side effect of now using > > case sensitive comparisons. This should not matter for any FDT based > > system which this is. > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Philipp, can I get an ack on this? I can commit it. Thank you, Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 0e6942f21a4e..99ec6e5f89dc 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -198,7 +198,7 @@ static int compare_of(struct device *dev, void *data) } /* Special case for LDB, one device for two channels */ - if (of_node_cmp(np->name, "lvds-channel") == 0) { + if (of_node_name_eq(np, "lvds-channel")) { np = of_get_parent(np); of_node_put(np); }
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. For instances using of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is. Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)