From patchwork Mon Jan 14 20:40:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 10764045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E80F13B5 for ; Tue, 15 Jan 2019 07:58:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6229B2AEE7 for ; Tue, 15 Jan 2019 07:58:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 56E842AEE9; Tue, 15 Jan 2019 07:58:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1B9852AEE7 for ; Tue, 15 Jan 2019 07:58:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79B346EBCD; Tue, 15 Jan 2019 07:57:46 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id F26226E41A for ; Mon, 14 Jan 2019 20:40:50 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id q18so429660wrx.9 for ; Mon, 14 Jan 2019 12:40:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=yiTzvOsBbU68HbKrMMBK2Tr5Tf5KHxDi+fruJqdMvPQ=; b=ST84XMUlMapBqIvLRHcp9Iu46sHuZ5m6MocOcHxFCB5zYsKzRQgjX8ts4dtQq2bfTz RaLiyLN8veIagzi9A2YEyf/dCJy5dNioi1h6a6BMt1/HPfbT31vgVD20FbDHfiuRwwAo 4Ae6GM5/+SCOFDw+vkuGf0+ycYPKM/hF3sifsnfiaJFIUenRsxONsdnVLf0Rm7bWsErQ SqJx80AvMfgUrB6GZBoqvWdB3yUxE2N0U/AwR2q4qgFRrjX0dQk5Jv+Vja3Tk3rriOtd nM3eqw0oQZeanUkXFq9buo6t5qtHqQ0r7MuM6rt31KiJorzDDPozymyS1F9/QyY6DnCv D1Kw== X-Gm-Message-State: AJcUukfM0nvH5Y30xH2E3V7efbwowltJyokSUEdGD884jPgd2k3aZO5w fSrb6Vazb0J4bUcmaw1eHMNaXm69 X-Google-Smtp-Source: ALg8bN7Ufx1yqDYCv8+hnYZCJwneHtn+lNizrVxSBFRt/pcLoPIbpGcDn96f+oAuQzhbdJ8CFrCsKQ== X-Received: by 2002:adf:f8cf:: with SMTP id f15mr202335wrq.265.1547498449523; Mon, 14 Jan 2019 12:40:49 -0800 (PST) Received: from macbookpro.malat.net ([2a01:e34:ee1e:860:6f23:82e6:aa2d:bbd1]) by smtp.gmail.com with ESMTPSA id c202sm37000661wmd.40.2019.01.14.12.40.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 12:40:48 -0800 (PST) Received: by macbookpro.malat.net (Postfix, from userid 1000) id CBAEB11422AD; Mon, 14 Jan 2019 21:40:47 +0100 (CET) From: Mathieu Malaterre To: Bartlomiej Zolnierkiewicz Subject: [PATCH] video: offb: annotate implicit fall throughs Date: Mon, 14 Jan 2019 21:40:44 +0100 Message-Id: <20190114204044.20528-1-malat@debian.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 15 Jan 2019 07:57:40 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Malaterre , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP There is a plan to build the kernel with -Wimplicit-fallthrough and these places in the code produced warnings (W=1). Fix them up. This commit remove the following warnings: drivers/video/fbdev/offb.c:211:5: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/offb.c:142:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre Acked-by: Gustavo A. R. Silva --- drivers/video/fbdev/offb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c index 31f769d67195..e0f0c5351306 100644 --- a/drivers/video/fbdev/offb.c +++ b/drivers/video/fbdev/offb.c @@ -141,6 +141,7 @@ static int offb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, /* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */ out_le32(par->cmap_adr + 0x58, in_le32(par->cmap_adr + 0x58) & ~0x20); + /* fall through */ case cmap_r128: /* Set palette index & data */ out_8(par->cmap_adr + 0xb0, regno); @@ -210,6 +211,7 @@ static int offb_blank(int blank, struct fb_info *info) /* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */ out_le32(par->cmap_adr + 0x58, in_le32(par->cmap_adr + 0x58) & ~0x20); + /* fall through */ case cmap_r128: /* Set palette index & data */ out_8(par->cmap_adr + 0xb0, i);