From patchwork Thu Jan 17 20:40:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 10769551 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB6966C2 for ; Fri, 18 Jan 2019 08:33:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A8FD2E978 for ; Fri, 18 Jan 2019 08:33:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8ECEB2E97F; Fri, 18 Jan 2019 08:33:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0EE842E990 for ; Fri, 18 Jan 2019 08:33:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4680A6F64E; Fri, 18 Jan 2019 08:33:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13F076F572; Thu, 17 Jan 2019 20:40:53 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id g67so2477113wmd.2; Thu, 17 Jan 2019 12:40:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=L/grezJULwv9Knxf1C+1plOEJ1PG9MZ5huJPitH+iAs=; b=p1OAsb/wTTRoABAMiMAN7kgnx3M51cP3TVIc+vobAXNrlvJE7BlvFzXRjvQQT92pIz /vU4o+La5fXfRpE8bkgUeJ6OrKCOf70hiDz/cKOwpKIk2nmM0ORvaFGyDiWLJdvEvNK0 yIZuZcbMc1YT1jI0vv4Sg6mrNn6s/OnfeigH2lktaq7xJXLkVUolPro/Wzj/oh7QO8Kg QHKUI+jn8r6wrLWV7mkwRCXuLk9E3oRnQakWt7P+RIioClqxaN8Sln+GSDPDXsX0W5qE hRM7X7IFX6jXHTl9/hCqyK82Vr96Q4jcN6P7E4vQt8C8tkHb5DuskPooj6bPkGCfix1I owTQ== X-Gm-Message-State: AJcUukdTR3fy7WF8qm+FQKIMRoOJYVxbUmQkXDaF7ks8f38FPwfdjumE B6fu+dUpzWeNkqjnNYJhn4w= X-Google-Smtp-Source: ALg8bN6cz6sa2sEvhl5gFhTeM48lO7SXAXKbqjRh4/be8CMEI0EnMr/7qOI6+7n61g8Go6HC90TMrw== X-Received: by 2002:a7b:c0c5:: with SMTP id s5mr13691610wmh.40.1547757651485; Thu, 17 Jan 2019 12:40:51 -0800 (PST) Received: from macbookpro.malat.net (bru31-1-78-225-224-134.fbx.proxad.net. [78.225.224.134]) by smtp.gmail.com with ESMTPSA id y1sm47183040wme.1.2019.01.17.12.40.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 12:40:50 -0800 (PST) Received: by macbookpro.malat.net (Postfix, from userid 1000) id 7C6D3114257D; Thu, 17 Jan 2019 21:40:49 +0100 (CET) From: Mathieu Malaterre To: Alex Deucher Subject: [PATCH v2] drm: radeon: add a missing break in evergreen_cs_handle_reg Date: Thu, 17 Jan 2019 21:40:47 +0100 Message-Id: <20190117204047.1262-1-malat@debian.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190114202652.15204-1-malat@debian.org> References: <20190114202652.15204-1-malat@debian.org> MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 18 Jan 2019 08:33:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Malaterre , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP In commit dd220a00e8bd ("drm/radeon/kms: add support for streamout v7") case statements were added without a terminating break statement. This commit adds the missing break. This was discovered during a compilation with W=1. This commit removes the following warning: drivers/gpu/drm/radeon/evergreen_cs.c:1301:11: warning: this statement may fall through [-Wimplicit-fallthrough=] Suggested-by: Alex Deucher Fixes: dd220a00e8bd ("drm/radeon/kms: add support for streamout v7") Signed-off-by: Mathieu Malaterre --- v2: Add missing break statement, instead of marking it as fall through drivers/gpu/drm/radeon/evergreen_cs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c index f471537c852f..1e14c6921454 100644 --- a/drivers/gpu/drm/radeon/evergreen_cs.c +++ b/drivers/gpu/drm/radeon/evergreen_cs.c @@ -1299,6 +1299,7 @@ static int evergreen_cs_handle_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) return -EINVAL; } ib[idx] += (u32)((reloc->gpu_offset >> 8) & 0xffffffff); + break; case CB_TARGET_MASK: track->cb_target_mask = radeon_get_ib_value(p, idx); track->cb_dirty = true;