| Message ID | 20190121235214.28455-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu | expand |
Thank you, Nathan. I applied your patch to amd-staging-drm-next. Sorry for the late response. I'm catching up with my email backlog after a vacation. Regards, Felix On 2019-01-21 6:52 p.m., Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning: > 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef] > #if CONFIG_X86_64 > ^ > 1 warning generated. > > Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)") > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > > Resending as I forgot to add the lists... > > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > index 5d85ff341385..2e7c44955f43 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > @@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, > return 0; > } > > -#if CONFIG_X86_64 > +#ifdef CONFIG_X86_64 > static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, > uint32_t *num_entries, > struct crat_subtype_iolink *sub_type_hdr)
Alex, can you get this into next and resend the pull? I don't like adding warnings. Dave. On Fri, 1 Feb 2019 at 06:10, Kuehling, Felix <Felix.Kuehling@amd.com> wrote: > > Thank you, Nathan. I applied your patch to amd-staging-drm-next. > > Sorry for the late response. I'm catching up with my email backlog after > a vacation. > > Regards, > Felix > > On 2019-01-21 6:52 p.m., Nathan Chancellor wrote: > > Clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning: > > 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef] > > #if CONFIG_X86_64 > > ^ > > 1 warning generated. > > > > Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)") > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > --- > > > > Resending as I forgot to add the lists... > > > > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > > index 5d85ff341385..2e7c44955f43 100644 > > --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > > @@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, > > return 0; > > } > > > > -#if CONFIG_X86_64 > > +#ifdef CONFIG_X86_64 > > static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, > > uint32_t *num_entries, > > struct crat_subtype_iolink *sub_type_hdr) > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 5d85ff341385..2e7c44955f43 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c @@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, return 0; } -#if CONFIG_X86_64 +#ifdef CONFIG_X86_64 static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, uint32_t *num_entries, struct crat_subtype_iolink *sub_type_hdr)
Clang warns: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning: 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef] #if CONFIG_X86_64 ^ 1 warning generated. Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- Resending as I forgot to add the lists... drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)