From patchwork Wed May 22 15:47:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10956153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF96216C1 for ; Wed, 22 May 2019 15:48:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D13DB28925 for ; Wed, 22 May 2019 15:48:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C5DCC28C1F; Wed, 22 May 2019 15:48:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4116928925 for ; Wed, 22 May 2019 15:48:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DF3189BF6; Wed, 22 May 2019 15:48:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0682789BBE for ; Wed, 22 May 2019 15:48:32 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id m3so2875514wrv.2 for ; Wed, 22 May 2019 08:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dgKnb+ZMAHPqo6jMH0ZRWvWPrzNuLtMxTP5x4mydrM8=; b=f9t0VhCSH8EYnks+KAjRs4IZssKxhGH2H3gTMvauURQ24PcJk6XXvbjUVsIbxhjluA YN/TR5K6/HuV3g7ZOM/xtsLoYIYlWVk4b4rqyAeDOdo+4FxFUr2Zk9jjJ9EnQLhsEruH DyUlvP8hlcpxqiS/FK5nwf+so5J6m35KPErn2AhWXdY/MnvuvTAxFhqCIi3tHx/5Q4AQ nQHJvtGluWqbUgqtwRfToSRQEfWinArKGCB6bHOK/p/d5s3K/KcWhiXJZDcAxZQGBOao BN6+kHdMyE9qVFqauOwIcCsA6+OUPkWh/NfrarBSTZoJAKckJ7RR8P57k6GPisXJB5bc BgeA== X-Gm-Message-State: APjAAAU/uSjDaDCT0Fs4st1ALTxekuv5BZ5ePndHsCrN4U9q9zAemhPb jSLtY6NE5qrH+wUi+WBGx0JuklrM X-Google-Smtp-Source: APXvYqx8HI+IZhhKjevA7awIPqbHQcCeXf2djysEOqMBFtegldOzcbbsJcAtx96/yLFrNIydc/KRww== X-Received: by 2002:adf:d088:: with SMTP id y8mr18602094wrh.286.1558540110418; Wed, 22 May 2019 08:48:30 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id t6sm12567117wmt.34.2019.05.22.08.48.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 08:48:29 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 4/4] drm/TODO: add a task to kill DRM_UNLOCKED Date: Wed, 22 May 2019 16:47:02 +0100 Message-Id: <20190522154702.16269-4-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190522154702.16269-1-emil.l.velikov@gmail.com> References: <20190522154702.16269-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dgKnb+ZMAHPqo6jMH0ZRWvWPrzNuLtMxTP5x4mydrM8=; b=SCj0bAWmdFdQ2Mw/RtMDceep46w8/2vWhqVYDeUhXpwoKr/qNB0g8bJO8QAXFzfdN6 3yBiWMt1sQJi1XFVTxVzN6HVrOA+vSxONYbtDeY1jHIlHapmsP+uGzElwmjEBzCAz+Im WFnDUysk3sXdfPV4LN+yWqJjf40yYJ+djqCGwWw4TMuSxgyQzuTZ/iHNq2M570E2YHAB BJ9AhySshIRjyZyXpytEXgyYKpcnOJ9+1negcNWkJthMQEaGQ5zXUSpUo85Nd/2DdxIt re1daW05IKscvAywPiq8kY1uwWralrF7nD8g/9xwTKNn2DjshznyzG+9ReDguMnOaRkn gk2w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov Should minimise the copy/paste mistakes, fixed with previous patches. Cc: Daniel Vetter Signed-off-by: Emil Velikov Reviewed-by: Daniel Vetter --- Daniel, not 100% sold on the idea. That plus listing you as a contact point ;-) What do you thing? Emil --- Documentation/gpu/todo.rst | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 66f05f4e469f..9e67d125f2fd 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -397,6 +397,25 @@ Some of these date from the very introduction of KMS in 2008 ... end, for which we could add drm_*_cleanup_kfree(). And then there's the (for historical reasons) misnamed drm_primary_helper_destroy() function. +Use DRM_LOCKED instead of DRM_UNLOCKED +-------------------------------------- + +DRM_UNLOCKED is a remainder from the legacy DRM drivers. Seemingly drivers get +tricked by it and it ends up in the driver private ioctls. + +Today no more legacy drivers are allowed and most core DRM ioctls are unlocked. + +Introduce DRM_LOCKED, use it to annotate only the relevant ioctls and kill the +old DRM_UNLOCKED. + +Patch series should be split as follows: + - Patch 1: drm: add the new DRM_LOCKED flag and honour it + - Patch 2: drm: convert core ioctls from DRM_UNLOCKED to DRM_LOCKED + - Patch 3-...: drm/driverX: convert driver ioctls from ... + - Patch X: drm: remove no longer used DRM_UNLOCKED, drop todo item + +Contact: Emil Velikov, Daniel Vetter + Better Testing ==============