| Message ID | 20190607213817.11767-1-dingchen.zhang@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: remove the newline for CRC source name. | expand |
Hi Dingchen. Patch is much better now. On Fri, Jun 07, 2019 at 05:38:17PM -0400, Dingchen Zhang wrote: > userspace may transfer a newline, and this terminating newline > is replaced by a '\0' to avoid followup issues. > > 'n-1' is the index to replace the newline of CRC source name. I am a little confused where 'n' comes from here? I you had written ' len - 1' then there was a clear connection to the patch. With this fixed: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > v2: update patch subject, body and format. (Sam) > > Cc: Leo Li <sunpeng.li@amd.com> > Cc: Harry Wentland <Harry.Wentland@amd.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com> > --- > drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c > index 585169f0dcc5..dac267e840af 100644 > --- a/drivers/gpu/drm/drm_debugfs_crc.c > +++ b/drivers/gpu/drm/drm_debugfs_crc.c > @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf, > if (IS_ERR(source)) > return PTR_ERR(source); > > - if (source[len] == '\n') > - source[len] = '\0'; > + if (source[len - 1] == '\n') > + source[len - 1] = '\0'; > > ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt); > if (ret) > -- > 2.17.1
Hi Sam, Thanks for the good catch. Actually it's a typo in email reply. It should be 'len - 1'. Regards, -----Original Message----- From: Sam Ravnborg <sam@ravnborg.org> Sent: Saturday, June 8, 2019 7:56 AM To: Zhang, Dingchen (David) <Dingchen.Zhang@amd.com> Cc: dri-devel@lists.freedesktop.org; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Wentland, Harry <Harry.Wentland@amd.com> Subject: Re: [PATCH] drm: remove the newline for CRC source name. Hi Dingchen. Patch is much better now. On Fri, Jun 07, 2019 at 05:38:17PM -0400, Dingchen Zhang wrote: > userspace may transfer a newline, and this terminating newline is > replaced by a '\0' to avoid followup issues. > > 'n-1' is the index to replace the newline of CRC source name. I am a little confused where 'n' comes from here? I you had written ' len - 1' then there was a clear connection to the patch. With this fixed: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > v2: update patch subject, body and format. (Sam) > > Cc: Leo Li <sunpeng.li@amd.com> > Cc: Harry Wentland <Harry.Wentland@amd.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com> > --- > drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_debugfs_crc.c > b/drivers/gpu/drm/drm_debugfs_crc.c > index 585169f0dcc5..dac267e840af 100644 > --- a/drivers/gpu/drm/drm_debugfs_crc.c > +++ b/drivers/gpu/drm/drm_debugfs_crc.c > @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf, > if (IS_ERR(source)) > return PTR_ERR(source); > > - if (source[len] == '\n') > - source[len] = '\0'; > + if (source[len - 1] == '\n') > + source[len - 1] = '\0'; > > ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt); > if (ret) > -- > 2.17.1
diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index 585169f0dcc5..dac267e840af 100644 --- a/drivers/gpu/drm/drm_debugfs_crc.c +++ b/drivers/gpu/drm/drm_debugfs_crc.c @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf, if (IS_ERR(source)) return PTR_ERR(source); - if (source[len] == '\n') - source[len] = '\0'; + if (source[len - 1] == '\n') + source[len - 1] = '\0'; ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt); if (ret)
userspace may transfer a newline, and this terminating newline is replaced by a '\0' to avoid followup issues. 'n-1' is the index to replace the newline of CRC source name. v2: update patch subject, body and format. (Sam) Cc: Leo Li <sunpeng.li@amd.com> Cc: Harry Wentland <Harry.Wentland@amd.com> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com> --- drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)