| Message ID | 20190608070230.55381-1-jitao.shi@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindngs: display: panel: Add BOE tv101wum-nl6 panel bindings | expand |
Hi Jitao Always good to see more panels added. On Sat, Jun 08, 2019 at 03:02:29PM +0800, Jitao Shi wrote: > Add documentation for boe tv101wum-n16 panel. The changelog says tv101wum-n16 but the compatible says tv101wum-nl6. Please pick the right one and be consistent. (number one '1' versus character 'l') > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > .../display/panel/boe,tv101wum-nl6.txt | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > new file mode 100644 > index 000000000000..2a84735d742d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > @@ -0,0 +1,34 @@ > +Boe Corporation 10.1" WUXGA TFT LCD panel > + > +Required properties: > +- compatible: should be "boe,tv101wum" The example uses "boe,tv101wum-nl6", which matches the filename. Please fix so it is the same all over. > +- reg: the virtual channel number of a DSI peripheral > +- enable-gpios: a GPIO spec for the enable pin > +- pp1800-supply: core voltage supply > +- avdd-supply: > +- avee-supply: Missing descriptions - please add. > +- backlight: phandle of the backlight device attached to the panel > + > +The device node can contain one 'port' child node with one child > +'endpoint' node, according to the bindings defined in > +media/video-interfaces.txt. This node should describe panel's video bus. > + > +Example: > +&dsi { > + ... > + panel@0 { > + compatible = "boe,tv101wum-nl6"; > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; > + backlight = <&backlight_lcd0>; > + status = "okay"; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > +}; > \ No newline at end of file Please add newline. Sam
On Sat, Jun 08, 2019 at 03:02:29PM +0800, Jitao Shi wrote: > Add documentation for boe tv101wum-n16 panel. Typo in the subject and checkpatch complains about trailing whitespace. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > .../display/panel/boe,tv101wum-nl6.txt | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > new file mode 100644 > index 000000000000..2a84735d742d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > @@ -0,0 +1,34 @@ > +Boe Corporation 10.1" WUXGA TFT LCD panel > + > +Required properties: > +- compatible: should be "boe,tv101wum" > +- reg: the virtual channel number of a DSI peripheral > +- enable-gpios: a GPIO spec for the enable pin > +- pp1800-supply: core voltage supply > +- avdd-supply: > +- avee-supply: > +- backlight: phandle of the backlight device attached to the panel > + > +The device node can contain one 'port' child node with one child > +'endpoint' node, according to the bindings defined in > +media/video-interfaces.txt. This node should describe panel's video bus. > + > +Example: > +&dsi { > + ... > + panel@0 { > + compatible = "boe,tv101wum-nl6"; > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; > + backlight = <&backlight_lcd0>; > + status = "okay"; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > +}; > \ No newline at end of file Fix this.
diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt new file mode 100644 index 000000000000..2a84735d742d --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt @@ -0,0 +1,34 @@ +Boe Corporation 10.1" WUXGA TFT LCD panel + +Required properties: +- compatible: should be "boe,tv101wum" +- reg: the virtual channel number of a DSI peripheral +- enable-gpios: a GPIO spec for the enable pin +- pp1800-supply: core voltage supply +- avdd-supply: +- avee-supply: +- backlight: phandle of the backlight device attached to the panel + +The device node can contain one 'port' child node with one child +'endpoint' node, according to the bindings defined in +media/video-interfaces.txt. This node should describe panel's video bus. + +Example: +&dsi { + ... + panel@0 { + compatible = "boe,tv101wum-nl6"; + reg = <0>; + enable-gpios = <&pio 45 0>; + avdd-supply = <&ppvarn_lcd>; + avee-supply = <&ppvarp_lcd>; + pp1800-supply = <&pp1800_lcd>; + backlight = <&backlight_lcd0>; + status = "okay"; + port { + panel_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + }; +}; \ No newline at end of file
Add documentation for boe tv101wum-n16 panel. Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> --- .../display/panel/boe,tv101wum-nl6.txt | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt