From patchwork Tue Jun 11 16:08:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10987685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D0001708 for ; Tue, 11 Jun 2019 16:10:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F139328389 for ; Tue, 11 Jun 2019 16:09:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E53BF286DD; Tue, 11 Jun 2019 16:09:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7E7872863B for ; Tue, 11 Jun 2019 16:09:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C04489255; Tue, 11 Jun 2019 16:09:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by gabe.freedesktop.org (Postfix) with ESMTPS id 848CA89254 for ; Tue, 11 Jun 2019 16:09:56 +0000 (UTC) Received: by mail-qt1-x843.google.com with SMTP id s15so15169053qtk.9 for ; Tue, 11 Jun 2019 09:09:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=84AZ1qzhWwhqGLJfreQPMMiAL6l+Ryk8Xjl8Qwr94gE=; b=ZA7PSpFY5NYaytp5C9QRVdWMA8XEfqlCZ58njCunQSqThJAFSTt5q2iumC9WuyCiY8 eqi4bLg/U7UmH/GVOQXxMrPJTKAjMUFos06ElGRmNpaVu1jXv/UdAaeXH+5KtGtliSNi JY1H7Q+HKYPzu3MKSHUZPMZ7bjh4TwFyhSYqw92tzQWlXDlcS6MG7X2eegtb18bCFQyH jP1P7GrzwBNPHGsZLj+7pNDh1VZL0ouoKUJ94JRrjIDiq5ryuBtPC7ys/Q6C3MX0ILT7 i30i1nZzqyv5IJVc8KsX276d4L+reC0XetBc8hg0YPOYxpS+w1lQ1wPQkH5d5XXznE09 jvCw== X-Gm-Message-State: APjAAAUiMZzSPG2a7Oi+O60oWHFIVxzwDCi6lVHF6gMRAjkPfcoFvZZK SA6chJQkHcZXZwXhNvTugn6TcyaZ/BI= X-Google-Smtp-Source: APXvYqzGY/B6xs6GrnF7f73Zb2DZamuvZy9MEBAUk3QRK73Lbvgd2Jm0nYj2Cxlr/eHbYenOMNxqPw== X-Received: by 2002:a05:6214:1024:: with SMTP id k4mr18841347qvr.124.1560269395598; Tue, 11 Jun 2019 09:09:55 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id d188sm6755094qkf.40.2019.06.11.09.09.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 09:09:55 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH v5 07/11] drm/rockchip: Check for fast link training before enabling psr Date: Tue, 11 Jun 2019 12:08:21 -0400 Message-Id: <20190611160844.257498-8-sean@poorly.run> X-Mailer: git-send-email 2.22.0.rc2.383.gf4fbbf30c2-goog In-Reply-To: <20190611160844.257498-1-sean@poorly.run> References: <20190611160844.257498-1-sean@poorly.run> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=84AZ1qzhWwhqGLJfreQPMMiAL6l+Ryk8Xjl8Qwr94gE=; b=F9TIoxODkwzaqItYN8EKNvZ1oofQ3Z7MX9PjZrJ5P3ORKpsAYx4563cM5M+Tr4urlQ Bc7xmY3GJcM0gbZpzTp2VqosyKKAo1GMXtOZzltQ3x9rroHnHSlBD+liJz5uuI8SG6vH tRfveHZc4y0sFsFSrzfioQhS9leIkVePOvC/8MmAGXeWEaQ4sb6ylvgdx9T1zbYr/TDJ lAmQJS2VSI2yZXby4CXI6KoB3eb68MH6SBgscBxiRoH8dasDPbKai7fgf4xNWwbaa086 z3KKc1TXKYkNzt7wMFzzRxUyTraVcfq1NWay3cDdLLO7eEiR4vBNHAxAfbeouo01WYkk t3Yg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zain Wang , David Airlie , Tomasz Figa , Sean Paul , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul Once we start shutting off the link during PSR, we're going to want fast training to work. If the display doesn't support fast training, don't enable psr. Changes in v2: - None Changes in v3: - None Changes in v4: - None Changes in v5: - None Link to v1: https://patchwork.freedesktop.org/patch/msgid/20190228210939.83386-3-sean@poorly.run Link to v2: https://patchwork.freedesktop.org/patch/msgid/20190326204509.96515-2-sean@poorly.run Link to v3: https://patchwork.freedesktop.org/patch/msgid/20190502194956.218441-9-sean@poorly.run Link to v4: https://patchwork.freedesktop.org/patch/msgid/20190508160920.144739-8-sean@poorly.run Cc: Zain Wang Cc: Tomasz Figa Tested-by: Heiko Stuebner Signed-off-by: Sean Paul --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index d2de98d441845..a07d19e08b803 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1040,16 +1040,17 @@ static int analogix_dp_commit(struct analogix_dp_device *dp) if (ret) return ret; + /* Check whether panel supports fast training */ + ret = analogix_dp_fast_link_train_detection(dp); + if (ret) + dp->psr_enable = false; + if (dp->psr_enable) { ret = analogix_dp_enable_sink_psr(dp); if (ret) return ret; } - /* Check whether panel supports fast training */ - ret = analogix_dp_fast_link_train_detection(dp); - if (ret) - dp->psr_enable = false; return ret; }