| Message ID | 20190704055217.45860-2-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | amdgpu clang warning fixes on next-20190703 | expand |
On Thu, Jul 4, 2019 at 7:52 AM Nathan Chancellor <natechancellor@gmail.com> wrote: > > clang warns: > > In file included from drivers/gpu/drm/amd/amdgpu/nv.c:53: > drivers/gpu/drm/amd/amdgpu/../amdgpu/mes_v10_1.h:24:9: warning: > '__MES_V10_1_H__' is used as a header guard here, followed by #define of > a different macro [-Wheader-guard] > #ifndef __MES_V10_1_H__ > ^~~~~~~~~~~~~~~ > drivers/gpu/drm/amd/amdgpu/../amdgpu/mes_v10_1.h:25:9: note: > '__MES_v10_1_H__' is defined here; did you mean '__MES_V10_1_H__'? > #define __MES_v10_1_H__ > ^~~~~~~~~~~~~~~ > __MES_V10_1_H__ > 1 warning generated. > > Capitalize the V. > > Fixes: 886f82aa7a1d ("drm/amdgpu/mes10.1: add ip block mes10.1 (v2)") > Link: https://github.com/ClangBuiltLinux/linux/issues/582 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> I ran into the same one now, and saw your version before sending an identical patch. Acked-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.h b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.h index 17b9b53fa892..9afd6ddb01e9 100644 --- a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.h +++ b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.h @@ -22,7 +22,7 @@ */ #ifndef __MES_V10_1_H__ -#define __MES_v10_1_H__ +#define __MES_V10_1_H__ extern const struct amdgpu_ip_block_version mes_v10_1_ip_block;
clang warns: In file included from drivers/gpu/drm/amd/amdgpu/nv.c:53: drivers/gpu/drm/amd/amdgpu/../amdgpu/mes_v10_1.h:24:9: warning: '__MES_V10_1_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] #ifndef __MES_V10_1_H__ ^~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../amdgpu/mes_v10_1.h:25:9: note: '__MES_v10_1_H__' is defined here; did you mean '__MES_V10_1_H__'? #define __MES_v10_1_H__ ^~~~~~~~~~~~~~~ __MES_V10_1_H__ 1 warning generated. Capitalize the V. Fixes: 886f82aa7a1d ("drm/amdgpu/mes10.1: add ip block mes10.1 (v2)") Link: https://github.com/ClangBuiltLinux/linux/issues/582 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/gpu/drm/amd/amdgpu/mes_v10_1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)