| Message ID | 20190717050946.18488-1-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpu: drm/tilcdc: Fix switch case fallthrough | expand |
On 17/07/2019 08:09, Keerthy wrote: > Fix the below build warning/Error > > drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’: > drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall > through [-Werror=implicit-fallthrough=] > reg |= LCDC_V2_TFT_24BPP_UNPACK; > ~~~~^~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here > case DRM_FORMAT_BGR888: > ^~~~ > cc1: all warnings being treated as errors > make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1 > make[4]: *** [drivers/gpu/drm/tilcdc] Error 2 > make[4]: *** Waiting for unfinished jobs.... > > Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()") > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 650d162e374b..c95b0652c6ab 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -382,7 +382,8 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) case DRM_FORMAT_XBGR8888: case DRM_FORMAT_XRGB8888: reg |= LCDC_V2_TFT_24BPP_UNPACK; - /* fallthrough */ + reg |= LCDC_V2_TFT_24BPP_MODE; + break; case DRM_FORMAT_BGR888: case DRM_FORMAT_RGB888: reg |= LCDC_V2_TFT_24BPP_MODE;
Fix the below build warning/Error drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’: drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall through [-Werror=implicit-fallthrough=] reg |= LCDC_V2_TFT_24BPP_UNPACK; ~~~~^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here case DRM_FORMAT_BGR888: ^~~~ cc1: all warnings being treated as errors make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1 make[4]: *** [drivers/gpu/drm/tilcdc] Error 2 make[4]: *** Waiting for unfinished jobs.... Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()") Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)