From patchwork Tue Jul 23 23:28:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Li X-Patchwork-Id: 11055443 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A8A71399 for ; Tue, 23 Jul 2019 23:29:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 589C028741 for ; Tue, 23 Jul 2019 23:29:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4AD4128749; Tue, 23 Jul 2019 23:29:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C59E528741 for ; Tue, 23 Jul 2019 23:29:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4501A6E3E7; Tue, 23 Jul 2019 23:29:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770085.outbound.protection.outlook.com [40.107.77.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2E0A6E3D2; Tue, 23 Jul 2019 23:29:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBskeBSrWMeKDpj0kLG5RThLi/G92S9kIldE08t3tZ80by518LUab6cBZBt52oF5zIzQ7pZdrkS8mOoyfgjl/w9nZbC7WqKI22A9WS2XyulkuFV4k3o0PJLdEQPBxsxC6Wv7Pq8ncqRTLy/cma2+KL4v70jDlmjVjjrbrmyFxYF4khvNL1KL0tGszL53vjtuGRwloxaa6sBPpGKQoudAU+dr0GFjBJvsmkEEmOmUznzzZWkjK/4Iku6ZX0O11jkDzwXU0YwQzj5trUSTvt7wshqrorpWYbFUhYhuLRRlpDmuEzQjwWju4YIel7SRrrgjv2wZJf6eHaPZRCrKuR7Osg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d+1U3k9GYsWrEV/m0WSElHM9u8VbSWfg9n36hVgrw/U=; b=H7MuwMu7nhnGHX3H4w6q0go0JLk3Bmr17NmhEF+Rrpk3AqI1jws/yACnMG57hLKr4xgO7VTNN7GVnnwCYvuW206mUl4sDXt/XPwy8jFOqPhdHvjs55CYJz6IE4nq9LKRYm9LLcathmhe6erfbglXA+US9/OobdGYdfrS/+/Qmd/Pn2JClwQDWGSD9FE9DdKo2lGne9LaAsucY1tSJvqSrajd24N0sJj2wAwpOiyrIYNkET8PCslk+56IQiGgZ7Aa0c+wS2hOBfSKKRFh7jAlWuoDeZBP0u3P2EoqtJ3mtcieJPETk8tti6lxufbIjOKU1p5ZBXgrT8+Ly70w+K8+iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=none (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com;dmarc=permerror action=none header.from=amd.com;dkim=none (message not signed);arc=none Received: from CY4PR1201CA0018.namprd12.prod.outlook.com (2603:10b6:910:16::28) by MWHPR12MB1583.namprd12.prod.outlook.com (2603:10b6:301:11::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Tue, 23 Jul 2019 23:29:07 +0000 Received: from DM3NAM03FT038.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e49::203) by CY4PR1201CA0018.outlook.office365.com (2603:10b6:910:16::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12 via Frontend Transport; Tue, 23 Jul 2019 23:29:06 +0000 Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXCHOV02.amd.com (165.204.84.17) by DM3NAM03FT038.mail.protection.outlook.com (10.152.83.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Tue, 23 Jul 2019 23:29:06 +0000 Received: from localhost.localdomain (10.180.168.240) by SATLEXCHOV02.amd.com (10.181.40.72) with Microsoft SMTP Server id 14.3.389.1; Tue, 23 Jul 2019 18:29:04 -0500 From: To: , Subject: [PATCH 4/9] drm/bridge/analogix-anx78xx: Use connector kdev as aux device parent Date: Tue, 23 Jul 2019 19:28:03 -0400 Message-ID: <20190723232808.28128-5-sunpeng.li@amd.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190723232808.28128-1-sunpeng.li@amd.com> References: <20190723232808.28128-1-sunpeng.li@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(136003)(346002)(39860400002)(2980300002)(428003)(199004)(189003)(54906003)(53936002)(110136005)(2906002)(50226002)(36756003)(51416003)(48376002)(76176011)(446003)(478600001)(5660300002)(70206006)(476003)(2876002)(5024004)(86362001)(70586007)(14444005)(26005)(186003)(47776003)(2616005)(1076003)(4326008)(305945005)(336012)(68736007)(11346002)(49486002)(8936002)(126002)(316002)(81166006)(81156014)(8676002)(2870700001)(356004)(50466002)(486006)(426003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR12MB1583; H:SATLEXCHOV02.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65c42161-7b3d-474d-275d-08d70fc58e6a X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328); SRVR:MWHPR12MB1583; X-MS-TrafficTypeDiagnostic: MWHPR12MB1583: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-Forefront-PRVS: 0107098B6C X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: QUdcxC14ZHnHLWp6CStNJixUWkBmtJTJTeAYqzmatiMsJV3FIRsLKguiLMtu+kwVsnMX/UHs0exnAWcEMAtz4UOnvgCs2b89YXMJmRbMW7EWy/GM1pMdqhVfOmFwrZFWZrh5OJ4E/UybMon23DNQkhTE17GuUqaBKxJOM4wxVKqhtGm3rNwv0dsYcXR75Vcf3FxQLVyy2nmFXKIaf06I30zTxVGWqtfQEWm66gfqN4xAMpL0zmja9KPSispbpBkbN1d8oQsuVHVXgV3uXG/eW7/C4fXYhF5wKLjNSFrN2WLJFuujQq7Uu8WBIVEQsAXv958X1ZKkwZh9LzhZNBQYUB1UrxwKaiB/N8RfE5/5XgyMeAk7WQVEkI6nu0sWHmFxBdcAp/vd/jxj47fU2Z+R1hsIj+54ZYuN7ufLPCMA6l0= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2019 23:29:06.5958 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65c42161-7b3d-474d-275d-08d70fc58e6a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXCHOV02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1583 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d+1U3k9GYsWrEV/m0WSElHM9u8VbSWfg9n36hVgrw/U=; b=QgNSmzjgJsfhf8oBJKj2f7I4h1j1mzxHu1+rWt7rJ7Wv9MWJQnWbyL/R/4Gx1cmue6n6o2OafV4M3Zz7V9JKNY1NkX+x9c/nmhGAYLubHv7NtPfv+2WIN7rdYnl0vl3AVh+xc+AfENeHQOn4yN2h8/jL8Gec43yfj/XlGD4ILK0= X-Mailman-Original-Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=permerror action=none header.from=amd.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Leo Li , Enric Balletbo i Serra , nicholas.kazlauskas@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Leo Li Set the connector's kernel device as the parent for the aux kernel device. This allows udev rules to access connector attributes when creating symlinks to aux devices. To do so, the connector needs to be registered beforehand. Therefore, shift aux registration to be after connector registration. Cc: Enric Balletbo i Serra Cc: Nicolas Boichat Signed-off-by: Leo Li --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c index 3c7cc5af735c..c2800cd3e2ee 100644 --- a/drivers/gpu/drm/bridge/analogix-anx78xx.c +++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c @@ -1008,17 +1008,6 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge) return -ENODEV; } - /* Register aux channel */ - anx78xx->aux.name = "DP-AUX"; - anx78xx->aux.dev = &anx78xx->client->dev; - anx78xx->aux.transfer = anx78xx_aux_transfer; - - err = drm_dp_aux_register(&anx78xx->aux); - if (err < 0) { - DRM_ERROR("Failed to register aux channel: %d\n", err); - return err; - } - err = drm_connector_init(bridge->dev, &anx78xx->connector, &anx78xx_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort); @@ -1038,6 +1027,17 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge) anx78xx->connector.polled = DRM_CONNECTOR_POLL_HPD; + /* Register aux channel */ + anx78xx->aux.name = "DP-AUX"; + anx78xx->aux.dev = anx78xx->connector.kdev; + anx78xx->aux.transfer = anx78xx_aux_transfer; + + err = drm_dp_aux_register(&anx78xx->aux); + if (err < 0) { + DRM_ERROR("Failed to register aux channel: %d\n", err); + return err; + } + err = drm_connector_attach_encoder(&anx78xx->connector, bridge->encoder); if (err) {