| Message ID | 20190731212944.3819-1-christian.gmeiner@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | etnaviv: fix whitespace errors | expand |
Hi Christian, On Wed, 2019-07-31 at 23:29 +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > --- > drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > index 4227a4006c34..06e6d3ee1c34 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > @@ -15,8 +15,8 @@ struct etnaviv_pm_signal { > u32 data; > > u32 (*sample)(struct etnaviv_gpu *gpu, > - const struct etnaviv_pm_domain *domain, > - const struct etnaviv_pm_signal *signal); > + const struct etnaviv_pm_domain *domain, > + const struct etnaviv_pm_signal *signal); That silences a checkpatch error, but now the alignment to the opening parenthesis is gone. How about using two tabs and six spaces instead? regards Philipp
Hi Philipp Am Do., 1. Aug. 2019 um 11:22 Uhr schrieb Philipp Zabel <p.zabel@pengutronix.de>: > > Hi Christian, > > On Wed, 2019-07-31 at 23:29 +0200, Christian Gmeiner wrote: > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > > --- > > drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > > index 4227a4006c34..06e6d3ee1c34 100644 > > --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > > +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > > @@ -15,8 +15,8 @@ struct etnaviv_pm_signal { > > u32 data; > > > > u32 (*sample)(struct etnaviv_gpu *gpu, > > - const struct etnaviv_pm_domain *domain, > > - const struct etnaviv_pm_signal *signal); > > + const struct etnaviv_pm_domain *domain, > > + const struct etnaviv_pm_signal *signal); > > That silences a checkpatch error, but now the alignment to the > opening parenthesis is gone. > How about using two tabs and six spaces instead? > Works for me - I think my git config was the problem here. [core] pager = less -x1,5 I removed this now and looks git diff looks better now.
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c index 4227a4006c34..06e6d3ee1c34 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c @@ -15,8 +15,8 @@ struct etnaviv_pm_signal { u32 data; u32 (*sample)(struct etnaviv_gpu *gpu, - const struct etnaviv_pm_domain *domain, - const struct etnaviv_pm_signal *signal); + const struct etnaviv_pm_domain *domain, + const struct etnaviv_pm_signal *signal); }; struct etnaviv_pm_domain {
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)