| Message ID | 20190910212909.18095-2-andreas@kemnade.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | backlight_lm3630a: add enable_gpios property | expand |
On Tue, Sep 10, 2019 at 11:29:08PM +0200, Andreas Kemnade wrote: > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > changes in v2: add example > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > index dc129d9a329e..1fa83feffe16 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -29,6 +29,10 @@ properties: > '#size-cells': > const: 0 > > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > required: > - compatible > - reg > @@ -92,6 +96,7 @@ examples: > i2c { > #address-cells = <1>; > #size-cells = <0>; > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; > > led-controller@38 { > compatible = "ti,lm3630a"; > -- > 2.20.1 >
Andreas On 9/11/19 5:08 AM, Daniel Thompson wrote: > On Tue, Sep 10, 2019 at 11:29:08PM +0200, Andreas Kemnade wrote: >> add enable-gpios to describe HWEN pin >> >> Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > >> --- >> changes in v2: add example >> .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >> index dc129d9a329e..1fa83feffe16 100644 >> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >> @@ -29,6 +29,10 @@ properties: >> '#size-cells': >> const: 0 >> >> + enable-gpios: >> + description: GPIO to use to enable/disable the backlight (HWEN pin). >> + maxItems: 1 >> + >> required: >> - compatible >> - reg >> @@ -92,6 +96,7 @@ examples: >> i2c { >> #address-cells = <1>; >> #size-cells = <0>; >> + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; This is in the wrong place. This is implying that the gpio is for the i2c parent This needs to go under the led-controller node below Dan >> >> led-controller@38 { >> compatible = "ti,lm3630a"; >> -- >> 2.20.1 >>
diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml index dc129d9a329e..1fa83feffe16 100644 --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml @@ -29,6 +29,10 @@ properties: '#size-cells': const: 0 + enable-gpios: + description: GPIO to use to enable/disable the backlight (HWEN pin). + maxItems: 1 + required: - compatible - reg @@ -92,6 +96,7 @@ examples: i2c { #address-cells = <1>; #size-cells = <0>; + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; led-controller@38 { compatible = "ti,lm3630a";
add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- changes in v2: add example .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ 1 file changed, 5 insertions(+)