From patchwork Thu Oct 24 16:45:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 11210315 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6491F14ED for ; Thu, 24 Oct 2019 16:46:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C74720659 for ; Thu, 24 Oct 2019 16:46:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C74720659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E55A06E503; Thu, 24 Oct 2019 16:46:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id B160F6E503 for ; Thu, 24 Oct 2019 16:46:47 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id c22so3283699wmd.1 for ; Thu, 24 Oct 2019 09:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xnrmAgjd57yL7bQcusoIEkE1OASAQ02Qykb8fz3n31M=; b=BYUQlftp3pMgA9oABhTtCe5VLC7S5/2G98S/qA59HmkJk+SyYYXBx6XJu/fruSf8HM kH9hvqcDRnGiHjt/VC689OvhG54kH6Ufy/tRTo6mnGU0CpZcyATRk1HOyp8FQr6tFdue QTp2LXgBzgW4KZJp0GXeJZ8m/nbv4lqeBQgxvt3BGOBEEsh1gVsKaVn7rKzNJbQ1p0sq V6Maz+k7LcUgA1XZODktoXJzAwIPKqM3rJF5cauQYhyB9vrQw+Xyn/s/vc4lqm4d6v+g ggbRKj+K3JpcdbBX2k2zGgDx6AOJZZxWbzq5/hVeWy/RkHrq1a0vNH4brH3iL5A9BvCk iICw== X-Gm-Message-State: APjAAAVBkaDjz9SpRQBEv3oZSgG+O2sJqbRfBrZyMxWmbqaOGn6XNx67 TJgOf+a64Hs1ijWuWV1DRM8= X-Google-Smtp-Source: APXvYqxZAXDPe/3JAnophhlvR/u4XCDRfpFhlc7VbOFvIhyKwORNTsCUZIjGYdNT3RJd3uUhy+9foQ== X-Received: by 2002:a1c:9d07:: with SMTP id g7mr5813102wme.53.1571935604846; Thu, 24 Oct 2019 09:46:44 -0700 (PDT) Received: from localhost (p2E5BE2CE.dip0.t-ipconnect.de. [46.91.226.206]) by smtp.gmail.com with ESMTPSA id d202sm2793119wmd.47.2019.10.24.09.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 09:46:43 -0700 (PDT) From: Thierry Reding To: Thierry Reding Subject: [PATCH 30/32] drm/tegra: sor: Avoid timeouts on unplug events Date: Thu, 24 Oct 2019 18:45:32 +0200 Message-Id: <20191024164534.132764-31-thierry.reding@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191024164534.132764-1-thierry.reding@gmail.com> References: <20191024164534.132764-1-thierry.reding@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xnrmAgjd57yL7bQcusoIEkE1OASAQ02Qykb8fz3n31M=; b=MZvBicSw9zipfnsTLsDJjAQ+KeqkoZ0fMDPFBlaj+HgXTCOnugmEXur/eBCIIsyCw4 /ts6A+LhkwqzykJWglYVjSj5RdrSg8WHX4ubiqyi7sxQPuMLxHVQSx/PiNAs/15Epflp nBJkwpsjNeDFSXmsCScMgWHRM4VwPTk096pjfwn5dr55yLDwPJUio3oNDXy3DQ8Vqe7n RyegAq2wyWdH40gOFovFJlVPjxC+cOjHsa0TkUf6m8yVMUb+u2bYGmP9rap5bC1awJOY hJXf63FZVrHHE3L1WZbo2cgOSdi+sECp5G6OLOLmcsUArsCuS6RoDgdMEJ+cKq2j0kg2 wozQ== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Thierry Reding When the SOR is disabled in DP mode as part of an unplug event, do not attempt to power the DP link down. Powering down the link requires the DPAUX to transmit AUX messages which only works if there's a connected sink. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/sor.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index 63831c37ad35..b81e6d39aa32 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -2663,9 +2663,16 @@ static void tegra_sor_dp_disable(struct drm_encoder *encoder) if (output->panel) drm_panel_disable(output->panel); - err = drm_dp_link_power_down(sor->aux, &sor->link); - if (err < 0) - dev_err(sor->dev, "failed to power down link: %d\n", err); + /* + * Do not attempt to power down a DP link if we're not connected since + * the AUX transactions would just be timing out. + */ + if (output->connector.status != connector_status_disconnected) { + err = drm_dp_link_power_down(sor->aux, &sor->link); + if (err < 0) + dev_err(sor->dev, "failed to power down link: %d\n", + err); + } err = tegra_sor_detach(sor); if (err < 0)