From patchwork Fri Nov 1 13:03:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11223109 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2831E1515 for ; Fri, 1 Nov 2019 13:05:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 107EE217F9 for ; Fri, 1 Nov 2019 13:05:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 107EE217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 74BBC6F7CE; Fri, 1 Nov 2019 13:05:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D0BB6E223 for ; Fri, 1 Nov 2019 13:05:13 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id t26so4934122wmi.4 for ; Fri, 01 Nov 2019 06:05:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3IVyhJFBg6AmCFnEdT3lCIZl0TWBzR6nJQgjh9Ae8SU=; b=XpXFcnIexO/2J9GdkISKvhWMvnheVhAIVlqJpd3qixE9nECjCxeNqVbEmvdDi+NbhH ZHhjviVqy9VUrZkFxoAgThVU1qlBFVnXVOfcnvp4R2wNIhvS0rE7/tMWcuQAGE9hc1Gi abwI6wG4e6cUUQYBL6Uj4005yRE6BfeN7sKkH/hCBhTfBzqnHdw20Z3IRVYtzjxSiOm3 uGAuM9KI/NXfQh67brdjH++J8AnFjejEQXOKil+X23BJjJtJ5sIzUglmKWR7LMEPRgkB t/4RWpV4NL7Jln4jpKThqKY1r/2eAQRUlZKNRPGqt31LmCccl3TZftU7yutCHbij6b2Z jzQQ== X-Gm-Message-State: APjAAAXFZVaMMA1WaTWZ0UMEeAKHWK3jvgyz3y2+JofcCW3guDxgAEW6 6d3goFd045TTTz05tmMhuqN0pnSc X-Google-Smtp-Source: APXvYqwiIH70sMtyI+njg4Wgzd3JLPXiBlya1sWilkS6Eo6q6QR0cMsP8916ExJelCDZCZ8vdqi9tw== X-Received: by 2002:a1c:4c11:: with SMTP id z17mr9616143wmf.59.1572613510923; Fri, 01 Nov 2019 06:05:10 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id a15sm2450562wmm.12.2019.11.01.06.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 06:05:10 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 4/5] drm/panfrost: remove DRM_AUTH and respective comment Date: Fri, 1 Nov 2019 13:03:12 +0000 Message-Id: <20191101130313.8862-4-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101130313.8862-1-emil.l.velikov@gmail.com> References: <20191101130313.8862-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3IVyhJFBg6AmCFnEdT3lCIZl0TWBzR6nJQgjh9Ae8SU=; b=ndOaYt+a6o98bEuRUvjDHtw9OlGyNIiOh3uBtLlwD7GvAidMvap+4Zwi1dy926/YFp jh9PO8UPxwCUM+GrTQD/gm5vdcD59AWFZJu9EpKfQUDhu0seBBcRUR9N0lfgBnsnI4By bigWwJx0SXGjqR+7slvX8aHd+TD8udICFQ9y/ezQ1UdOa+NxWBkV/0cBQWTK5u5XDrhb EHsYP9LiSTPVUQPhPf8ThnyIyZAJPtURWD+X/4jbFpzlzPiHqzdz3u9I8x5eP4HfUsDY u5k9vLCV0wo4OvP9XXOmyF3sq2A0/jhnzrNxVyr0GrBUEjaKpUZ50zVXzAnwG/RXPuTy 0mmQ== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , David Airlie , emil.l.velikov@gmail.com, Steven Price , Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Emil Velikov As of earlier commit we have address space separation. Yet we forgot to remove the respective comment and DRM_AUTH in the ioctl declaration. Cc: Tomeu Vizoso Cc: David Airlie Cc: Daniel Vetter Cc: Robin Murphy Cc: Steven Price Fixes: 7282f7645d06 ("drm/panfrost: Implement per FD address spaces") Signed-off-by: Emil Velikov Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_drv.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index bc2ddeb55f5d..c677b2c9e409 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -451,15 +451,11 @@ panfrost_postclose(struct drm_device *dev, struct drm_file *file) kfree(panfrost_priv); } -/* DRM_AUTH is required on SUBMIT for now, while all clients share a single - * address space. Note that render nodes would be able to submit jobs that - * could access BOs from clients authenticated with the master node. - */ static const struct drm_ioctl_desc panfrost_drm_driver_ioctls[] = { #define PANFROST_IOCTL(n, func, flags) \ DRM_IOCTL_DEF_DRV(PANFROST_##n, panfrost_ioctl_##func, flags) - PANFROST_IOCTL(SUBMIT, submit, DRM_RENDER_ALLOW | DRM_AUTH), + PANFROST_IOCTL(SUBMIT, submit, DRM_RENDER_ALLOW), PANFROST_IOCTL(WAIT_BO, wait_bo, DRM_RENDER_ALLOW), PANFROST_IOCTL(CREATE_BO, create_bo, DRM_RENDER_ALLOW), PANFROST_IOCTL(MMAP_BO, mmap_bo, DRM_RENDER_ALLOW),