From patchwork Tue Dec 3 16:19:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 11271545 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CBE80138C for ; Tue, 3 Dec 2019 16:19:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B41952080A for ; Tue, 3 Dec 2019 16:19:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B41952080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1EE76E83E; Tue, 3 Dec 2019 16:19:19 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id A32106E83E for ; Tue, 3 Dec 2019 16:19:18 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id t2so4448201wrr.1 for ; Tue, 03 Dec 2019 08:19:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vjYPQ2k6428g0Cg1s43bFBcw4e2+WGwefK1SwWebzQU=; b=qdGFbIudsgAw0Xy7Lca0PQmTSWp63mH5/+a901XoRDpg3itHKKJvaiTjvkjoXRaf+w iNzHdOvEES9nnIGcEKLYQqkEgzgw7SXDEub5bVGT74ksE2A9YAzHMh/BFC3GDUSQTnHc RawpdDu1iItBWzC8NgvwIl5x/+h3C15f0Z47mn2vzVdu0c1EOwKJrWLDi5yv8zkPNTj7 OEI5O6FP20YmtDXjrJxXCTCvJSFCFcrEGt+V/SpEdMdNoSNLsuwAvDCPkcMtj3JQosrY XHJc74dIIG7YyG5525GcvxU2r6r70bs0lYqiQSYpP21/PXc7W0Qng6kimCQctrQcXUh0 IM6g== X-Gm-Message-State: APjAAAXjbJATeyNLiq0R4M6KT2DtRzYRKqsMd1MCteeVTRWcNV1ehndl CBox8qjKoIJ8o5uygasoemE= X-Google-Smtp-Source: APXvYqwdCR2ddyErXa8r9O+qWPWJ+/tZW2/osXU5f7BU/Bytj2oFg0HdQ2sBwLYJVead4gikfjt+kQ== X-Received: by 2002:adf:fa0b:: with SMTP id m11mr4573223wrr.98.1575389957119; Tue, 03 Dec 2019 08:19:17 -0800 (PST) Received: from localhost (pD9E518ED.dip0.t-ipconnect.de. [217.229.24.237]) by smtp.gmail.com with ESMTPSA id l17sm3518398wme.45.2019.12.03.08.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 08:19:15 -0800 (PST) From: Thierry Reding To: Thierry Reding Subject: [PATCH v2 1/9] drm/tegra: hub: Remove bogus connection mutex check Date: Tue, 3 Dec 2019 17:19:06 +0100 Message-Id: <20191203161914.1312555-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vjYPQ2k6428g0Cg1s43bFBcw4e2+WGwefK1SwWebzQU=; b=W681X+pYik3350bfuhteJclqkTvrQYBYxsAGfZE3S4lrFo+RCgdGHU564bQsdGMfm/ 8Cjcg6tmXKoAI+3Z2mVVcWJ+scF9ZE0NyFtg6kvvy67fnI5uIwaxdJT2gybqDl6lkA2v /R3bt0HrLoeKNPGKIqhz9Zp1ooKY4L0JU0aZ9GrBWRbVgbLMAwHx0iM4XAFsa0X3JCUG 9Sz5EyPwMKE8GKpDO6rkbRUtj7Qq2W81LwQM15rqP4f03mhiZj2F0rI55qX8CDfw8dEt Vo12BUhV4SuW+2DgVoASxuHfUhqwXV4JOrDn5s2YLMIDAQ7SE7jJDnnhj4nxLhqgw921 uXQg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Daniel Vetter , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Thierry Reding The Tegra DRM never actually took that lock, so the driver was broken until generic locking was added in commit: commit b962a12050a387e4bbf3a48745afe1d29d396b0d Author: Rob Clark Date: Mon Oct 22 14:31:22 2018 +0200 drm/atomic: integrate modeset lock with private objects It's now no longer necessary to take that lock, so drop the check. v2: add rationale for why it is now safe to drop the check (Daniel) Reviewed-by: Daniel Vetter Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/hub.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c index 6aca0fd5a8e5..e56c0f7d3a13 100644 --- a/drivers/gpu/drm/tegra/hub.c +++ b/drivers/gpu/drm/tegra/hub.c @@ -615,11 +615,8 @@ static struct tegra_display_hub_state * tegra_display_hub_get_state(struct tegra_display_hub *hub, struct drm_atomic_state *state) { - struct drm_device *drm = dev_get_drvdata(hub->client.parent); struct drm_private_state *priv; - WARN_ON(!drm_modeset_is_locked(&drm->mode_config.connection_mutex)); - priv = drm_atomic_get_private_obj_state(state, &hub->base); if (IS_ERR(priv)) return ERR_CAST(priv);