| Message ID | 20191220213816.627188-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/of: Add missing static inline to get_dual_link_pixel_order stub | expand |
Hi Chris, Thank you for the patch. On Fri, Dec 20, 2019 at 09:38:16PM +0000, Chris Wilson wrote: > Mark up the stub drm_of_lvds_get_dual_link_pixel_order() as being a > static inline to avoid a double definition. > > Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I've already submitted [1] which fixes the same issue. Now that I look at it, I don't see Fabrizio's Reviewed-by reply in the mailing list archive or in patchwork. Fabrizio, could you try to resend it so it can be picked from patchwork ? [1] https://www.spinics.net/lists/dri-devel/msg241747.html > --- > include/drm/drm_of.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h > index 8ec7ca6d2369..b9b093add92e 100644 > --- a/include/drm/drm_of.h > +++ b/include/drm/drm_of.h > @@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const struct device_node *np, > return -EINVAL; > } > > -int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, > - const struct device_node *port2) > +static inline int > +drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, > + const struct device_node *port2) > { > return -EINVAL; > }
diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index 8ec7ca6d2369..b9b093add92e 100644 --- a/include/drm/drm_of.h +++ b/include/drm/drm_of.h @@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const struct device_node *np, return -EINVAL; } -int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, - const struct device_node *port2) +static inline int +drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, + const struct device_node *port2) { return -EINVAL; }
Mark up the stub drm_of_lvds_get_dual_link_pixel_order() as being a static inline to avoid a double definition. Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/drm/drm_of.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)