| Message ID | 20200114142012.14389-1-benjamin.gaignard@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: fix parameters documentation style | expand |
Hi, This all looks good except one item: (see below) On 1/14/20 6:20 AM, Benjamin Gaignard wrote: > Remove old documentation style and use new one to avoid warnings when > compiling with W=1 > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > drivers/gpu/drm/drm_dma.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dma.c b/drivers/gpu/drm/drm_dma.c > index e45b07890c5a..f90bdd4ac69d 100644 > --- a/drivers/gpu/drm/drm_dma.c > +++ b/drivers/gpu/drm/drm_dma.c > @@ -42,10 +42,10 @@ > #include "drm_legacy.h" > > /** > - * Initialize the DMA data. > + * drm_legacy_dma_setup() - Initialize the DMA data. > * > - * \param dev DRM device. > - * \return zero on success or a negative value on failure. > + * @dev: DRM device. > + * return zero on success or a negative value on failure. * Return: zero on success or a negative value on failure. > * > * Allocate and initialize a drm_device_dma structure. > */ > @@ -71,9 +71,9 @@ int drm_legacy_dma_setup(struct drm_device *dev) > } > > /** > - * Cleanup the DMA resources. > + * drm_legacy_dma_takedown() - Cleanup the DMA resources. > * > - * \param dev DRM device. > + * @dev: DRM device. > * > * Free all pages associated with DMA buffers, the buffers and pages lists, and > * finally the drm_device::dma structure itself. > @@ -120,10 +120,10 @@ void drm_legacy_dma_takedown(struct drm_device *dev) > } > > /** > - * Free a buffer. > + * drm_legacy_free_buffer() - Free a buffer. > * > - * \param dev DRM device. > - * \param buf buffer to free. > + * @dev: DRM device. > + * @buf: buffer to free. > * > * Resets the fields of \p buf. > */ > @@ -139,9 +139,10 @@ void drm_legacy_free_buffer(struct drm_device *dev, struct drm_buf * buf) > } > > /** > - * Reclaim the buffers. > + * drm_legacy_reclaim_buffers() - Reclaim the buffers. > * > - * \param file_priv DRM file private. > + * @dev: DRM device. > + * @file_priv: DRM file private. > * > * Frees each buffer associated with \p file_priv not already on the hardware. > */ > thanks.
diff --git a/drivers/gpu/drm/drm_dma.c b/drivers/gpu/drm/drm_dma.c index e45b07890c5a..f90bdd4ac69d 100644 --- a/drivers/gpu/drm/drm_dma.c +++ b/drivers/gpu/drm/drm_dma.c @@ -42,10 +42,10 @@ #include "drm_legacy.h" /** - * Initialize the DMA data. + * drm_legacy_dma_setup() - Initialize the DMA data. * - * \param dev DRM device. - * \return zero on success or a negative value on failure. + * @dev: DRM device. + * return zero on success or a negative value on failure. * * Allocate and initialize a drm_device_dma structure. */ @@ -71,9 +71,9 @@ int drm_legacy_dma_setup(struct drm_device *dev) } /** - * Cleanup the DMA resources. + * drm_legacy_dma_takedown() - Cleanup the DMA resources. * - * \param dev DRM device. + * @dev: DRM device. * * Free all pages associated with DMA buffers, the buffers and pages lists, and * finally the drm_device::dma structure itself. @@ -120,10 +120,10 @@ void drm_legacy_dma_takedown(struct drm_device *dev) } /** - * Free a buffer. + * drm_legacy_free_buffer() - Free a buffer. * - * \param dev DRM device. - * \param buf buffer to free. + * @dev: DRM device. + * @buf: buffer to free. * * Resets the fields of \p buf. */ @@ -139,9 +139,10 @@ void drm_legacy_free_buffer(struct drm_device *dev, struct drm_buf * buf) } /** - * Reclaim the buffers. + * drm_legacy_reclaim_buffers() - Reclaim the buffers. * - * \param file_priv DRM file private. + * @dev: DRM device. + * @file_priv: DRM file private. * * Frees each buffer associated with \p file_priv not already on the hardware. */
Remove old documentation style and use new one to avoid warnings when compiling with W=1 Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- drivers/gpu/drm/drm_dma.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)