From patchwork Mon Feb 3 11:20:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwan-gyeong Mun X-Patchwork-Id: 11362483 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2AF34112B for ; Mon, 3 Feb 2020 11:20:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12BF320721 for ; Mon, 3 Feb 2020 11:20:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12BF320721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9464B6E2DC; Mon, 3 Feb 2020 11:20:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E80F76E2CA; Mon, 3 Feb 2020 11:20:25 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 03:20:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,397,1574150400"; d="scan'208";a="263381118" Received: from unknown (HELO helsinki.fi.intel.com) ([10.237.66.150]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2020 03:20:23 -0800 From: Gwan-gyeong Mun To: intel-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/i915/dp: Add checking of YCBCR420 Pass-through to YCBCR420 outputs. Date: Mon, 3 Feb 2020 13:20:22 +0200 Message-Id: <20200203112022.105392-1-gwan-gyeong.mun@intel.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, "../kernel_patch/dp_dongle_01/0001-drm-Add-a-detailed-DP-HDMI-branch-info-on-debugfs.patch"@freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When a DP downstream uses a DP to HDMI active converter, the active converter needs to support YCbCr420 Pass-through to enable DP YCbCr 4:2:0 outputs. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_dp.c | 26 +++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index f4dede6253f8..824ed8096426 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -2298,6 +2298,22 @@ intel_dp_compute_link_config(struct intel_encoder *encoder, return 0; } +static bool +intel_dp_downstream_is_hdmi_detailed_cap_info(struct intel_dp *intel_dp) +{ + int type = intel_dp->downstream_ports[0] & DP_DS_PORT_TYPE_MASK; + bool detailed_cap_info = intel_dp->dpcd[DP_DOWNSTREAMPORT_PRESENT] & + DP_DETAILED_CAP_INFO_AVAILABLE; + + return type == DP_DS_PORT_TYPE_HDMI && detailed_cap_info; +} + +static bool +intel_dp_downstream_supports_ycbcr_420_passthru(struct intel_dp *intel_dp) +{ + return intel_dp->downstream_ports[3] & DP_DS_YCBCR420_PASSTHRU_SUPPORT; +} + static int intel_dp_ycbcr420_config(struct intel_dp *intel_dp, struct drm_connector *connector, @@ -2314,6 +2330,16 @@ intel_dp_ycbcr420_config(struct intel_dp *intel_dp, !connector->ycbcr_420_allowed) return 0; + /* + * When a DP downstream uses a DP to HDMI active converter, + * the active converter needs to support YCbCr420 Pass-through. + */ + if (drm_dp_is_branch(intel_dp->dpcd)) { + if (intel_dp_downstream_is_hdmi_detailed_cap_info(intel_dp) && + !intel_dp_downstream_supports_ycbcr_420_passthru(intel_dp)) + return 0; + } + crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR420; /* YCBCR 420 output conversion needs a scaler */