| Message ID | 20200204161916.28744-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] drm: shmobile: Platform data shan't include kernel.h | expand |
On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote: > On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote: > > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote: > > > Replace with appropriate types.h. > > > > Thanks for your patch! > > > > I have only one very short question: why? > > Likewise :-) The patch itself looks fine, but the commit message is a > bit terse. The kernel.h for a long time being a dump of a lot of things. I started cleaning it up a bit. During this I notice that developers too far too lazy to use appropriate headers. For platform data kernel.h by definition is not appropriate. Any suggestion what should I put to commit message?
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h index fe815d7d9f58..08605fdb2226 100644 --- a/include/linux/platform_data/shmob_drm.h +++ b/include/linux/platform_data/shmob_drm.h @@ -10,7 +10,7 @@ #ifndef __SHMOB_DRM_H__ #define __SHMOB_DRM_H__ -#include <linux/kernel.h> +#include <linux/types.h> #include <drm/drm_mode.h>
Replace with appropriate types.h. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/platform_data/shmob_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)