| Message ID | 20200207135950.6655-5-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Try to fix encoder possible_clones/crtc | expand |
Hi Am 07.02.20 um 14:59 schrieb Ville Syrjala: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > It's not at all clear what cloning options this driver supports. > So let's just clear possible_clones instead of setting it to some > bogus value. > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index da87c70e413b..a0a709dfba34 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, > encoder->possible_crtcs = crtc_mask; > > /* FIXME: this is the mask of outputs which can clone this output. */ > - encoder->possible_clones = ~0; > + encoder->possible_clones = 0; Maybe remove the comment as well. It's pointless. Best regards Thomas > > return 0; > } >
On Fri, Feb 07, 2020 at 03:20:44PM +0100, Thomas Zimmermann wrote: > Hi > > Am 07.02.20 um 14:59 schrieb Ville Syrjala: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > It's not at all clear what cloning options this driver supports. > > So let's just clear possible_clones instead of setting it to some > > bogus value. > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > index da87c70e413b..a0a709dfba34 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, > > encoder->possible_crtcs = crtc_mask; > > > > /* FIXME: this is the mask of outputs which can clone this output. */ > > - encoder->possible_clones = ~0; > > + encoder->possible_clones = 0; > > Maybe remove the comment as well. It's pointless. Maybe change it to "FIXME: cloning support not clear, disable it all for now". With that Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Best regards > Thomas > > > > > return 0; > > } > > > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index da87c70e413b..a0a709dfba34 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, encoder->possible_crtcs = crtc_mask; /* FIXME: this is the mask of outputs which can clone this output. */ - encoder->possible_clones = ~0; + encoder->possible_clones = 0; return 0; }