| Message ID | 20200219203544.31013-12-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Put drm_display_mode on diet | expand |
On Wed, Feb 19, 2020 at 10:35:43PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > gma500 needs 4 bits (to store a pixel multiplier) in the > mode->private_flags, i915 currently has three bits defined. > No one else uses this. Reduce the size to u8. > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> There seems to be talk about dropping use of private_flags from i915 and gma500 (IIRC). So maybe drop this patch as we are about to get rid of private_flags - which is much better? Sam > --- > include/drm/drm_modes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > index b585074945b5..dadb0f3e5b0b 100644 > --- a/include/drm/drm_modes.h > +++ b/include/drm/drm_modes.h > @@ -378,7 +378,7 @@ struct drm_display_mode { > * by atomic drivers since they can store any additional data by > * subclassing state structures. > */ > - int private_flags; > + u8 private_flags; > > /** > * @picture_aspect_ratio: > -- > 2.24.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Feb 21, 2020 at 05:15:20PM +0100, Sam Ravnborg wrote: > On Wed, Feb 19, 2020 at 10:35:43PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > gma500 needs 4 bits (to store a pixel multiplier) in the > > mode->private_flags, i915 currently has three bits defined. > > No one else uses this. Reduce the size to u8. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > There seems to be talk about dropping use of private_flags > from i915 and gma500 (IIRC). > So maybe drop this patch as we are about to get rid of > private_flags - which is much better? Hmm. Yeah, this is patch 11/12 so I guess I might as well drop it. > > Sam > > > --- > > include/drm/drm_modes.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index b585074945b5..dadb0f3e5b0b 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -378,7 +378,7 @@ struct drm_display_mode { > > * by atomic drivers since they can store any additional data by > > * subclassing state structures. > > */ > > - int private_flags; > > + u8 private_flags; > > > > /** > > * @picture_aspect_ratio: > > -- > > 2.24.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index b585074945b5..dadb0f3e5b0b 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -378,7 +378,7 @@ struct drm_display_mode { * by atomic drivers since they can store any additional data by * subclassing state structures. */ - int private_flags; + u8 private_flags; /** * @picture_aspect_ratio: