diff mbox series

[v7,04/54] drm/bridge: Document the drm_encoder.bridge_chain field as private

Message ID 20200222150106.22919-5-laurent.pinchart@ideasonboard.com (mailing list archive)
State New, archived
Headers show
Series drm/omap: Replace custom display drivers with drm_bridge and drm_panel | expand

Commit Message

Laurent Pinchart Feb. 22, 2020, 3 p.m. UTC
The drm_encoder.bridge_chain is not meant to be touched manually by
drivers. Make this clear in the documentation.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/drm/drm_encoder.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Boris Brezillon Feb. 25, 2020, 3:25 p.m. UTC | #1
On Sat, 22 Feb 2020 17:00:16 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> The drm_encoder.bridge_chain is not meant to be touched manually by
> drivers. Make this clear in the documentation.

Thanks for this clarification:

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  include/drm/drm_encoder.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h
> index 5623994b6e9e..4370e039c015 100644
> --- a/include/drm/drm_encoder.h
> +++ b/include/drm/drm_encoder.h
> @@ -174,7 +174,8 @@ struct drm_encoder {
>  	struct drm_crtc *crtc;
>  
>  	/**
> -	 * @bridge_chain: Bridges attached to this encoder.
> +	 * @bridge_chain: Bridges attached to this encoder. Drivers shall not
> +	 * access this field directly.
>  	 */
>  	struct list_head bridge_chain;
>
diff mbox series

Patch

diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h
index 5623994b6e9e..4370e039c015 100644
--- a/include/drm/drm_encoder.h
+++ b/include/drm/drm_encoder.h
@@ -174,7 +174,8 @@  struct drm_encoder {
 	struct drm_crtc *crtc;
 
 	/**
-	 * @bridge_chain: Bridges attached to this encoder.
+	 * @bridge_chain: Bridges attached to this encoder. Drivers shall not
+	 * access this field directly.
 	 */
 	struct list_head bridge_chain;