| Message ID | 20200408202711.1198966-2-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Regressions for "imply" behavior change | expand |
diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig index 6a700d34019e..52806ef20d2d 100644 --- a/drivers/net/ethernet/cavium/Kconfig +++ b/drivers/net/ethernet/cavium/Kconfig @@ -27,7 +27,7 @@ config THUNDER_NIC_PF config THUNDER_NIC_VF tristate "Thunder Virtual function driver" - imply CAVIUM_PTP + select CAVIUM_PTP if POSIX_TIMERS depends on 64BIT && PCI ---help--- This driver supports Thunder's NIC virtual function
The 'imply' selection means the driver can still be a loadable module even if the main driver is built-in, leading to a link error: aarch64-linux-ld: drivers/net/ethernet/cavium/thunder/nicvf_main.o: in function `nicvf_remove': nicvf_main.c:(.text+0x25c): undefined reference to `cavium_ptp_put' aarch64-linux-ld: drivers/net/ethernet/cavium/thunder/nicvf_main.o: in function `nicvf_probe': nicvf_main.c:(.text+0x3080): undefined reference to `cavium_ptp_get' Use a 'select' statement instead. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/cavium/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)