From patchwork Wed Apr 8 20:27:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11480841 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EDC0D92A for ; Wed, 8 Apr 2020 20:27:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3E6420753 for ; Wed, 8 Apr 2020 20:27:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3E6420753 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A8456EAF6; Wed, 8 Apr 2020 20:27:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35A046EAF1 for ; Wed, 8 Apr 2020 20:27:46 +0000 (UTC) Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1MnaY1-1ivA0D1Xk5-00jcjI; Wed, 08 Apr 2020 22:27:20 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Masahiro Yamada , Nicolas Pitre Subject: [RFC 2/6] net/mlx5e: fix VXLAN dependency Date: Wed, 8 Apr 2020 22:27:07 +0200 Message-Id: <20200408202711.1198966-3-arnd@arndb.de> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200408202711.1198966-1-arnd@arndb.de> References: <20200408202711.1198966-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:uksvWMPl7e6M4tD/Jwdoi/VMWCKlsBX2f2Iv1OdecI6D9qke0UX H8JDHSq9tH9gdAImB1WlOCwGw2juxksbW0T1qPC/P8/TcGZb/MCvO8DynkYcvjJ8nPSRDqN MW7IsSzrNXsuHRWtvMtvasLD+JPJGabCH2cqP5roVa2BQ766CRRiBekpQVNwmRgvG8cSVNn FzXdiP8/Lanh60jj+f2Ng== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+pcOhHlaitk=:zKS80sKudtNtQuZ1iQybEO wR9woHPAZHzLc5HwPQBHERiTXNsHPvLlSFLLPyYLD2rLxRtJ0Mpr/58sYHIITmcsY/Kr9k1Vu cCbVLzrbl1zD3+n4O6enNKSBMWBevs2J2Y9MamrLlYrEiBuZOQGPOJM0XzBzb/PyzBYhhU5+c xIcDV3bkFc+wLZ1vC9/XsK5CBpa5pS64Z6ytzN0yJ3VF5KTFDZsz6466WnD89PacJbtMug/bL 8C8lnesNMro0k1UiKregFx5o6f3U6HY73wqmcGVdS00G2Iknb7Nslx3Bj96wqAWJjejMJR7xI H6HgOx0glLxanJ4WykB8tpm2yWxYqBMIFL8qxiS9hUx50qs7TJChcneGGt+2OZ45AKT3cn5Om UTu8AbTDWLWYnAApETQg38+ImM4r2Hws7U1FkqDsQi5Lz/Hsowg36urTW+kMe1+aJ55GPypXI zpQOgvlpPFO0fBWrauV4iQ8F6SjCNu/Q+zsV8SpAVvp+ESoYLma6GR2oTAJ1eJzV0IjKzU4iD GRDz0VvNwL3JtpjdesDHUS95Hdd4dS1r4bkxKdrS1KKXiLNciMj8OyY6+PEHTK4+d7LDBkJuF 6YgMtsw5FfLzm7UviRd1IkV5Dbd8L2DrU7pgp2uibPI9gJg5A4BTBMAkX3exImlErl+no4RVa t9sWJy2+yCx6SL6BGHCCPQD0fnNfQK2JcqnaEHTVOxZsnSwxdv/pyfgMIADONeZVilF6AEd7W 72LP2HuNDtWiGd56e8YlUH+iqDjcDEUW0ZbmQUJatHpliCkuFgCvZzgnDf/mtvTMKe9CiFIYH AmuXQn2RKNyCix3iwEGv808kO+9zjt/UKc1O4W2x3YXfaKSx8E= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Leon Romanovsky , Arnd Bergmann , Jonas Karlman , David Airlie , netdev@vger.kernel.org, Neil Armstrong , Saeed Mahameed , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Kieran Bingham , Laurent Pinchart , "David S. Miller" , linux-rdma@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The 'imply' statement does not prevent MLX5 to be built-in and fail when VXLAN=m: aarch64-linux-ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function `mlx5_init_once': main.c:(.text+0x7cc): undefined reference to `mlx5_vxlan_create' main.c:(.text+0x958): undefined reference to `mlx5_vxlan_destroy' Use a normal dependency instead. Fixes: c5791ab0abec ("net/mlx5e: vxlan.c depends on CONFIG_VXLAN") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig index 312e0a1ad43d..849b0be0ca9a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig @@ -8,7 +8,7 @@ config MLX5_CORE depends on PCI select NET_DEVLINK imply PTP_1588_CLOCK - imply VXLAN + depends on VXLAN || !VXLAN imply MLXFW imply PCI_HYPERV_INTERFACE default n