| Message ID | 20200517193655.3895087-1-emil.l.velikov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] drm/arm: Kconfig annotate drivers as COMPILE_TEST | expand |
On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote: > Add the COMPILE_TEST conditional, so that people can at least build test > the drivers. > > Cc: Liviu Dudau <liviu.dudau@arm.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Cc: Brian Starkey <brian.starkey@arm.com> > Cc: Mali DP Maintainers <malidp@foss.arm.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > --- > Please merge through the ARM tree. We're not using the ARM tree anymore, we push patches through drm-misc. I'm happy if you want to push the whole series or I can do the 2 patches that I've been Cc-ed on. Best regards, Liviu > > Aside: would make sense to have the tree drivers in separate folders > alongside each other. > > With lima and panfrost in-tree, there's little point in the extra > "display" for komeda. Might as well remove that one. > --- > drivers/gpu/drm/arm/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig > index a204103b3efb..3a9e966e0e78 100644 > --- a/drivers/gpu/drm/arm/Kconfig > +++ b/drivers/gpu/drm/arm/Kconfig > @@ -3,7 +3,7 @@ menu "ARM devices" > > config DRM_HDLCD > tristate "ARM HDLCD" > - depends on DRM && OF && (ARM || ARM64) > + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) > depends on COMMON_CLK > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > @@ -24,7 +24,7 @@ config DRM_HDLCD_SHOW_UNDERRUN > > config DRM_MALI_DISPLAY > tristate "ARM Mali Display Processor" > - depends on DRM && OF && (ARM || ARM64) > + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) > depends on COMMON_CLK > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, 18 May 2020 at 12:10, Liviu Dudau <liviu.dudau@arm.com> wrote: > > On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote: > > Add the COMPILE_TEST conditional, so that people can at least build test > > the drivers. > > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > > > Cc: Brian Starkey <brian.starkey@arm.com> > > Cc: Mali DP Maintainers <malidp@foss.arm.com> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > --- > > Please merge through the ARM tree. > > We're not using the ARM tree anymore, we push patches through drm-misc. > > I'm happy if you want to push the whole series or I can do the 2 patches > that I've been Cc-ed on. > The third patch should be taken care of. So 1/3 + 2/3 need taking care of. Please do a quick runtime test for 2/3. As you can see I've only compiled it. -Emil
Hi Emil, On Wed, May 20, 2020 at 12:54:17AM +0100, Emil Velikov wrote: > On Mon, 18 May 2020 at 12:10, Liviu Dudau <liviu.dudau@arm.com> wrote: > > > > On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote: > > > Add the COMPILE_TEST conditional, so that people can at least build test > > > the drivers. > > > > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > > > > > Cc: Brian Starkey <brian.starkey@arm.com> > > > Cc: Mali DP Maintainers <malidp@foss.arm.com> > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > > --- > > > Please merge through the ARM tree. > > > > We're not using the ARM tree anymore, we push patches through drm-misc. > > > > I'm happy if you want to push the whole series or I can do the 2 patches > > that I've been Cc-ed on. > > > The third patch should be taken care of. So 1/3 + 2/3 need taking care of. > Please do a quick runtime test for 2/3. As you can see I've only compiled it. For 1/3 + 2/3: Tested-by: Liviu Dudau <liviu.dudau@arm.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu > > -Emil > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, 1 Jun 2020 at 18:42, Liviu Dudau <liviu.dudau@arm.com> wrote: > > Hi Emil, > > On Wed, May 20, 2020 at 12:54:17AM +0100, Emil Velikov wrote: > > On Mon, 18 May 2020 at 12:10, Liviu Dudau <liviu.dudau@arm.com> wrote: > > > > > > On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote: > > > > Add the COMPILE_TEST conditional, so that people can at least build test > > > > the drivers. > > > > > > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > > > > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > > > > > > > Cc: Brian Starkey <brian.starkey@arm.com> > > > > Cc: Mali DP Maintainers <malidp@foss.arm.com> > > > > Cc: dri-devel@lists.freedesktop.org > > > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > > > --- > > > > Please merge through the ARM tree. > > > > > > We're not using the ARM tree anymore, we push patches through drm-misc. > > > > > > I'm happy if you want to push the whole series or I can do the 2 patches > > > that I've been Cc-ed on. > > > > > The third patch should be taken care of. So 1/3 + 2/3 need taking care of. > > Please do a quick runtime test for 2/3. As you can see I've only compiled it. > > For 1/3 + 2/3: > > Tested-by: Liviu Dudau <liviu.dudau@arm.com> > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Thank you Liviu. Added the tags and pushed to drm-misc. -Emil
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index a204103b3efb..3a9e966e0e78 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -3,7 +3,7 @@ menu "ARM devices" config DRM_HDLCD tristate "ARM HDLCD" - depends on DRM && OF && (ARM || ARM64) + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER @@ -24,7 +24,7 @@ config DRM_HDLCD_SHOW_UNDERRUN config DRM_MALI_DISPLAY tristate "ARM Mali Display Processor" - depends on DRM && OF && (ARM || ARM64) + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER
Add the COMPILE_TEST conditional, so that people can at least build test the drivers. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Brian Starkey <brian.starkey@arm.com> Cc: Mali DP Maintainers <malidp@foss.arm.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- Please merge through the ARM tree. Aside: would make sense to have the tree drivers in separate folders alongside each other. With lima and panfrost in-tree, there's little point in the extra "display" for komeda. Might as well remove that one. --- drivers/gpu/drm/arm/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)