diff mbox series

[v2,1/2] fbdev: annotate rivafb/nvidiafb as obsolete

Message ID 20200517220524.4036334-1-emil.l.velikov@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] fbdev: annotate rivafb/nvidiafb as obsolete | expand

Commit Message

Emil Velikov May 17, 2020, 10:05 p.m. UTC 
Drivers have not seen any love for years.

Be that fixes or improvements, or cosmetics like introducing symbolic
names, style and code-flow polish.

Seemingly the maintainer has also disappeared years ago :-\

Considering nouveau supports all that hardware (modulo nv03) just mark
these as obsolete/broken, referring to nouveau in the help text.

v2 (Bartlomiej):
 - split config changes into separate patch
 - spell out nouveau DRM driver
 - don't use BROKEN
 - add runtime warning

Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v1)
---
 MAINTAINERS                         | 3 +--
 drivers/video/fbdev/Kconfig         | 4 ++++
 drivers/video/fbdev/nvidia/nvidia.c | 3 +++
 drivers/video/fbdev/riva/fbdev.c    | 3 +++
 4 files changed, 11 insertions(+), 2 deletions(-)

Comments

kernel test robot May 17, 2020, 11:11 p.m. UTC | #1 
Hi Emil,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on tegra-drm/drm/tegra/for-next linus/master v5.7-rc5 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Emil-Velikov/fbdev-annotate-rivafb-nvidiafb-as-obsolete/20200518-060957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/video/fbdev/riva/fbdev.c:2167:8: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^
1 warning generated.
--
>> drivers/video/fbdev/nvidia/nvidia.c:1519:8: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^
1 warning generated.

vim +2167 drivers/video/fbdev/riva/fbdev.c

^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2152  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2153  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2154  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2155  /* ------------------------------------------------------------------------- *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2156   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2157   * modularization
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2158   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2159   * ------------------------------------------------------------------------- */
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2160  
48c68c4f1b5424 drivers/video/riva/fbdev.c       Greg Kroah-Hartman 2012-12-21  2161  static int rivafb_init(void)
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2162  {
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2163  	pr_warn("Legacy rivafb framebuffer driver will be removed in 2022\n"
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2164  		"Please switch to nouveau DRM driver\n");
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2165  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2166  #ifndef MODULE
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16 @2167  	char *option = NULL;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2168  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2169  	if (fb_get_options("rivafb", &option))
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2170  		return -ENODEV;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2171  	rivafb_setup(option);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2172  #endif
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2173  	return pci_register_driver(&rivafb_driver);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2174  }
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2175  

:::::: The code at line 2167 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
kernel test robot May 17, 2020, 11:11 p.m. UTC | #2 
Hi Emil,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on tegra-drm/drm/tegra/for-next linus/master v5.7-rc5 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Emil-Velikov/fbdev-annotate-rivafb-nvidiafb-as-obsolete/20200518-060957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/video/fbdev/riva/fbdev.c: In function 'rivafb_init':
>> drivers/video/fbdev/riva/fbdev.c:2167:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^~~~
--
drivers/video/fbdev/nvidia/nvidia.c: In function 'nvidiafb_init':
>> drivers/video/fbdev/nvidia/nvidia.c:1519:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^~~~

vim +2167 drivers/video/fbdev/riva/fbdev.c

^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2152  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2153  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2154  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2155  /* ------------------------------------------------------------------------- *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2156   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2157   * modularization
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2158   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2159   * ------------------------------------------------------------------------- */
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2160  
48c68c4f1b5424 drivers/video/riva/fbdev.c       Greg Kroah-Hartman 2012-12-21  2161  static int rivafb_init(void)
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2162  {
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2163  	pr_warn("Legacy rivafb framebuffer driver will be removed in 2022\n"
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2164  		"Please switch to nouveau DRM driver\n");
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2165  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2166  #ifndef MODULE
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16 @2167  	char *option = NULL;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2168  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2169  	if (fb_get_options("rivafb", &option))
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2170  		return -ENODEV;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2171  	rivafb_setup(option);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2172  #endif
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2173  	return pci_register_driver(&rivafb_driver);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2174  }
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2175  

:::::: The code at line 2167 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 938316092634..c9498dd15e4a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12055,9 +12055,8 @@  F:	include/linux/nubus.h
 F:	include/uapi/linux/nubus.h
 
 NVIDIA (rivafb and nvidiafb) FRAMEBUFFER DRIVER
-M:	Antonino Daplas <adaplas@gmail.com>
 L:	linux-fbdev@vger.kernel.org
-S:	Maintained
+S:	Obsolete
 F:	drivers/video/fbdev/nvidia/
 F:	drivers/video/fbdev/riva/
 
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index fa88e8b9a83d..ccddd06ab430 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -881,6 +881,8 @@  config FB_NVIDIA
 	select BITREVERSE
 	select VGASTATE
 	help
+	  Obsolete, use the nouveau DRM driver instead.
+
 	  This driver supports graphics boards with the nVidia chips, TNT
 	  and newer. For very old chipsets, such as the RIVA128, then use
 	  the rivafb.
@@ -928,6 +930,8 @@  config FB_RIVA
 	select BITREVERSE
 	select VGASTATE
 	help
+	  Obsolete, use the nouveau DRM driver instead.
+
 	  This driver supports graphics boards with the nVidia Riva/Geforce
 	  chips.
 	  Say Y if you have such a graphics board.
diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c
index c24de9107958..a958612ef75b 100644
--- a/drivers/video/fbdev/nvidia/nvidia.c
+++ b/drivers/video/fbdev/nvidia/nvidia.c
@@ -1512,6 +1512,9 @@  static struct pci_driver nvidiafb_driver = {
 
 static int nvidiafb_init(void)
 {
+	pr_warn("Legacy nvidiafb framebuffer driver will be removed in 2022\n"
+		"Please switch to nouveau DRM driver\n");
+
 #ifndef MODULE
 	char *option = NULL;
 
diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index 764ec3285e62..c2788e22f5c1 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c
@@ -2160,6 +2160,9 @@  static struct pci_driver rivafb_driver = {
 
 static int rivafb_init(void)
 {
+	pr_warn("Legacy rivafb framebuffer driver will be removed in 2022\n"
+		"Please switch to nouveau DRM driver\n");
+
 #ifndef MODULE
 	char *option = NULL;