| Message ID | 20200907102711.23748-1-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: dw-mipi-dsi: fix dw_mipi_dsi_debugfs_show/write warnings | expand |
On Mon, Sep 07, 2020 at 12:27:11PM +0200, Neil Armstrong wrote: > This fixes the following warnings while building in W=1 : > dw-mipi-dsi.c:1002:5: warning: no previous prototype for 'dw_mipi_dsi_debugfs_write' [-Wmissing-prototypes] > dw-mipi-dsi.c:1027:5: warning: no previous prototype for 'dw_mipi_dsi_debugfs_show' [-Wmissing-prototypes] > > Fixes: e2435d69204c ("drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs") > Reported-by: kernel test robot <lkp@intel.com> > Cc: Angelo Ribeiro <angelo.ribeiro@synopsys.com> > Cc: Maxime Ripard <maxime@cerno.tech> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index 0b3825a4fbdb..52f5c5a2ed64 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -999,7 +999,7 @@ static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > > #ifdef CONFIG_DEBUG_FS > > -int dw_mipi_dsi_debugfs_write(void *data, u64 val) > +static int dw_mipi_dsi_debugfs_write(void *data, u64 val) > { > struct debugfs_entries *vpg = data; > struct dw_mipi_dsi *dsi; > @@ -1024,7 +1024,7 @@ int dw_mipi_dsi_debugfs_write(void *data, u64 val) > return 0; > } > > -int dw_mipi_dsi_debugfs_show(void *data, u64 *val) > +static int dw_mipi_dsi_debugfs_show(void *data, u64 *val) > { > struct debugfs_entries *vpg = data; > > -- > 2.22.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 07/09/2020 20:04, Daniel Vetter wrote: > On Mon, Sep 07, 2020 at 12:27:11PM +0200, Neil Armstrong wrote: >> This fixes the following warnings while building in W=1 : >> dw-mipi-dsi.c:1002:5: warning: no previous prototype for 'dw_mipi_dsi_debugfs_write' [-Wmissing-prototypes] >> dw-mipi-dsi.c:1027:5: warning: no previous prototype for 'dw_mipi_dsi_debugfs_show' [-Wmissing-prototypes] >> >> Fixes: e2435d69204c ("drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs") >> Reported-by: kernel test robot <lkp@intel.com> >> Cc: Angelo Ribeiro <angelo.ribeiro@synopsys.com> >> Cc: Maxime Ripard <maxime@cerno.tech> >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Cc: Thomas Zimmermann <tzimmermann@suse.de> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Thanks, Applied > >> --- >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> index 0b3825a4fbdb..52f5c5a2ed64 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> @@ -999,7 +999,7 @@ static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { >> >> #ifdef CONFIG_DEBUG_FS >> >> -int dw_mipi_dsi_debugfs_write(void *data, u64 val) >> +static int dw_mipi_dsi_debugfs_write(void *data, u64 val) >> { >> struct debugfs_entries *vpg = data; >> struct dw_mipi_dsi *dsi; >> @@ -1024,7 +1024,7 @@ int dw_mipi_dsi_debugfs_write(void *data, u64 val) >> return 0; >> } >> >> -int dw_mipi_dsi_debugfs_show(void *data, u64 *val) >> +static int dw_mipi_dsi_debugfs_show(void *data, u64 *val) >> { >> struct debugfs_entries *vpg = data; >> >> -- >> 2.22.0 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 0b3825a4fbdb..52f5c5a2ed64 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -999,7 +999,7 @@ static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { #ifdef CONFIG_DEBUG_FS -int dw_mipi_dsi_debugfs_write(void *data, u64 val) +static int dw_mipi_dsi_debugfs_write(void *data, u64 val) { struct debugfs_entries *vpg = data; struct dw_mipi_dsi *dsi; @@ -1024,7 +1024,7 @@ int dw_mipi_dsi_debugfs_write(void *data, u64 val) return 0; } -int dw_mipi_dsi_debugfs_show(void *data, u64 *val) +static int dw_mipi_dsi_debugfs_show(void *data, u64 *val) { struct debugfs_entries *vpg = data;
This fixes the following warnings while building in W=1 : dw-mipi-dsi.c:1002:5: warning: no previous prototype for 'dw_mipi_dsi_debugfs_write' [-Wmissing-prototypes] dw-mipi-dsi.c:1027:5: warning: no previous prototype for 'dw_mipi_dsi_debugfs_show' [-Wmissing-prototypes] Fixes: e2435d69204c ("drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs") Reported-by: kernel test robot <lkp@intel.com> Cc: Angelo Ribeiro <angelo.ribeiro@synopsys.com> Cc: Maxime Ripard <maxime@cerno.tech> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)