| Message ID | 20200910170401.3857250-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vc4: Update type of reg parameter in vc4_hdmi_{read, write} | expand |
On Thu, Sep 10, 2020 at 10:04:02AM -0700, Nathan Chancellor wrote: > Clang warns 100+ times in the vc4 driver along the lines of: > > drivers/gpu/drm/vc4/vc4_hdmi_phy.c:518:13: warning: implicit conversion > from enumeration type 'enum vc4_hdmi_field' to different enumeration > type 'enum vc4_hdmi_regs' [-Wenum-conversion] > HDMI_WRITE(HDMI_TX_PHY_POWERDOWN_CTL, > ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ > > The HDMI_READ and HDMI_WRITE macros pass in enumerators of type > vc4_hdmi_field but vc4_hdmi_write and vc4_hdmi_read expect a enumerator > of type vc4_hdmi_regs, causing a warning for every instance of this. > Update the parameter type so there is no more mismatch. > > Fixes: 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction") > Link: https://github.com/ClangBuiltLinux/linux/issues/1149 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Applied, thanks! Maxime
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi_regs.h b/drivers/gpu/drm/vc4/vc4_hdmi_regs.h index 47364bd3960d..7c6b4818f245 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi_regs.h +++ b/drivers/gpu/drm/vc4/vc4_hdmi_regs.h @@ -392,7 +392,7 @@ void __iomem *__vc4_hdmi_get_field_base(struct vc4_hdmi *hdmi, } static inline u32 vc4_hdmi_read(struct vc4_hdmi *hdmi, - enum vc4_hdmi_regs reg) + enum vc4_hdmi_field reg) { const struct vc4_hdmi_register *field; const struct vc4_hdmi_variant *variant = hdmi->variant; @@ -417,7 +417,7 @@ static inline u32 vc4_hdmi_read(struct vc4_hdmi *hdmi, #define HDMI_READ(reg) vc4_hdmi_read(vc4_hdmi, reg) static inline void vc4_hdmi_write(struct vc4_hdmi *hdmi, - enum vc4_hdmi_regs reg, + enum vc4_hdmi_field reg, u32 value) { const struct vc4_hdmi_register *field;
Clang warns 100+ times in the vc4 driver along the lines of: drivers/gpu/drm/vc4/vc4_hdmi_phy.c:518:13: warning: implicit conversion from enumeration type 'enum vc4_hdmi_field' to different enumeration type 'enum vc4_hdmi_regs' [-Wenum-conversion] HDMI_WRITE(HDMI_TX_PHY_POWERDOWN_CTL, ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ The HDMI_READ and HDMI_WRITE macros pass in enumerators of type vc4_hdmi_field but vc4_hdmi_write and vc4_hdmi_read expect a enumerator of type vc4_hdmi_regs, causing a warning for every instance of this. Update the parameter type so there is no more mismatch. Fixes: 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction") Link: https://github.com/ClangBuiltLinux/linux/issues/1149 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- Note, the variable names in these functions do not really make much sense after this patch but attempting to flip the variable names made everything feel even weirder. Feel free to rewrite this in whatever way you prefer, I just don't want my builds to be chalk full of warnings :) drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 8c3c818c23a5bbce6ff180dd2ee04415241df77c