From patchwork Sun Oct 11 23:01:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 11831961 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1928E697 for ; Mon, 12 Oct 2020 08:59:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B26F0208FE for ; Mon, 12 Oct 2020 08:59:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KZ92qkKx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B26F0208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BEC456E0F1; Mon, 12 Oct 2020 08:59:05 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49CAD6E069 for ; Sun, 11 Oct 2020 23:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=/SmX1rf42AFciihmx5mExGuKYPWmjWxmU8bHlEGVC/A=; b=KZ92qkKx3S5NvDRn3N+UWYf8Nm 4JoYfRd/t2Z+I90nbAPF03Qp5OUqQ6SjHdF3sz3Wi6daAB0xMS282XHEITDe4BPdvVeTWtxtqTQ7b IP6Xj5V/o7QXlnU70rD0UmHQH60ZMlYNlxKxcvGZ/UE9cJ71275POBcaP6/0zpHqO1JWVufTrtraw TahAsmb2Ep//NxFfwTb3JhqgyXC2r1vaJ/5FXF8enwhMAt8XWZdf2YV1DxpZCCMVjL+lzq5yzZsSg Nnrh0+BfCA1XvbRNg08jRqjcddobG/cGK1z4bo5ggkJZe+59j6JgSQ4KjiiJKOETJi/tocsl7ZBcU 356jIS2Q==; Received: from [2601:1c0:6280:3f0::507c] (helo=smtpauth.infradead.org) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRkLT-000817-CQ; Sun, 11 Oct 2020 23:01:40 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Subject: [PATCH RESEND] drm/aspeed: fix Kconfig warning & subsequent build errors Date: Sun, 11 Oct 2020 16:01:31 -0700 Message-Id: <20201011230131.4922-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 12 Oct 2020 08:59:04 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , kernel test robot , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Daniel Vetter , David Airlie , Randy Dunlap , dri-devel@lists.freedesktop.org, Mike Rapoport , linux-mm@kvack.org, Joel Stanley , Andrew Morton , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" kernel test robot reported build errors (undefined references) that didn't make much sense. After reproducing them, there is also a Kconfig warning that is the root cause of the build errors, so fix that Kconfig problem. Fixes this Kconfig warning: WARNING: unmet direct dependencies detected for CMA Depends on [n]: MMU [=n] Selected by [m]: - DRM_ASPEED_GFX [=m] && HAS_IOMEM [=y] && DRM [=m] && OF [=y] && (COMPILE_TEST [=y] || ARCH_ASPEED) && HAVE_DMA_CONTIGUOUS [=y] and these dependent build errors: (.text+0x10c8c): undefined reference to `start_isolate_page_range' microblaze-linux-ld: (.text+0x10f14): undefined reference to `test_pages_isolated' microblaze-linux-ld: (.text+0x10fd0): undefined reference to `undo_isolate_page_range' Fixes: 76356a966e33 ("drm: aspeed: Clean up Kconfig options") Reported-by: kernel test robot Signed-off-by: Randy Dunlap Cc: Joel Stanley Cc: Andrew Jeffery Cc: Daniel Vetter Cc: Michal Simek Cc: Andrew Morton Cc: Mike Rapoport Cc: linux-mm@kvack.org Cc: linux-aspeed@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- First sent on 2020-09-07. Feel free to fix the Kconfig warning some other way... drivers/gpu/drm/aspeed/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20201009.orig/drivers/gpu/drm/aspeed/Kconfig +++ linux-next-20201009/drivers/gpu/drm/aspeed/Kconfig @@ -3,6 +3,7 @@ config DRM_ASPEED_GFX tristate "ASPEED BMC Display Controller" depends on DRM && OF depends on (COMPILE_TEST || ARCH_ASPEED) + depends on MMU select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DMA_CMA if HAVE_DMA_CONTIGUOUS