| Message ID | 20201030002850.6495-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fbdev/sh_mobile: Drop unused include | expand |
On Fri, Oct 30, 2020 at 1:30 AM Linus Walleij <linus.walleij@linaro.org> wrote: > The driver includes <linux/gpio.h> but doesn't use any symbols > from this file. > > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: linux-renesas-soc@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> on r8a77440/armadillo, where this is the last piece of non-DT support. Gr{oetje,eeting}s, Geert
Hi Linus, On Fri, Oct 30, 2020 at 01:28:50AM +0100, Linus Walleij wrote: > The driver includes <linux/gpio.h> but doesn't use any symbols > from this file. > > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: linux-renesas-soc@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Thanks, I went ahead and applied this to drm-misc-next. And then I remembered you have commit right too :-( Sam
On Sun, Nov 1, 2020 at 10:36 AM Sam Ravnborg <sam@ravnborg.org> wrote: > On Fri, Oct 30, 2020 at 01:28:50AM +0100, Linus Walleij wrote: > > The driver includes <linux/gpio.h> but doesn't use any symbols > > from this file. > > > > Cc: Magnus Damm <magnus.damm@gmail.com> > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > Cc: linux-renesas-soc@vger.kernel.org > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > Thanks, I went ahead and applied this to drm-misc-next. > And then I remembered you have commit right too :-( Thanks! It is always better if someone else does it anyways! Yours, Linus Walleij
diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c1043420dbd3..027c74d7c010 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -16,7 +16,6 @@ #include <linux/dma-mapping.h> #include <linux/delay.h> #include <linux/fbcon.h> -#include <linux/gpio.h> #include <linux/init.h> #include <linux/interrupt.h> #include <linux/ioctl.h>
The driver includes <linux/gpio.h> but doesn't use any symbols from this file. Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: linux-renesas-soc@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 1 - 1 file changed, 1 deletion(-)