| Message ID | 20201101173817.831769-1-boris.brezillon@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panfrost: Remove unused variables in panfrost_job_close() | expand |
On 01/11/2020 17:38, Boris Brezillon wrote: > Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on > open/close") left unused variables behind, thus generating a warning > at compilation time. Remove those variables. > > Fixes: a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close") > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Steven Price <steven.price@arm.com> > --- > My bad, I didn't notice this warning when rebasing Steven's patch on > top of drm-misc-next :-/ Partly my fault - I think I forgot to rebase the patch on drm-misc-next before posting. Thanks for fixing it. Steve > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index 14c11293791e..d58e5fe12cab 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -634,8 +634,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv) > > void panfrost_job_close(struct panfrost_file_priv *panfrost_priv) > { > - struct panfrost_device *pfdev = panfrost_priv->pfdev; > - struct panfrost_job_slot *js = pfdev->js; > int i; > > for (i = 0; i < NUM_JOB_SLOTS; i++) >
On Mon, 2 Nov 2020 08:39:29 +0000 Steven Price <steven.price@arm.com> wrote: > On 01/11/2020 17:38, Boris Brezillon wrote: > > Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on > > open/close") left unused variables behind, thus generating a warning > > at compilation time. Remove those variables. > > > > Fixes: a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close") > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > > Reviewed-by: Steven Price <steven.price@arm.com> Queued to drm-misc-next.
diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c index 14c11293791e..d58e5fe12cab 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -634,8 +634,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv) void panfrost_job_close(struct panfrost_file_priv *panfrost_priv) { - struct panfrost_device *pfdev = panfrost_priv->pfdev; - struct panfrost_job_slot *js = pfdev->js; int i; for (i = 0; i < NUM_JOB_SLOTS; i++)
Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close") left unused variables behind, thus generating a warning at compilation time. Remove those variables. Fixes: a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> --- My bad, I didn't notice this warning when rebasing Steven's patch on top of drm-misc-next :-/ --- drivers/gpu/drm/panfrost/panfrost_job.c | 2 -- 1 file changed, 2 deletions(-)