| Message ID | 20201109170601.21557-2-nikhil.nd@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tidss: Use new connector model for tidss | expand |
On 09/11/2020 19:05, Nikhil Devshatwar wrote: > bus_flags can be specified by a bridge in the timings. > If the bridge provides it, Override the bus_flags when propagating > from next bridge. > > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com> > --- > drivers/gpu/drm/drm_bridge.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index 64f0effb52ac..2bbd6ffe82ce 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -975,6 +975,14 @@ drm_atomic_bridge_propagate_bus_flags(struct drm_bridge *bridge, > * duplicate the "dummy propagation" logic. > */ > bridge_state->input_bus_cfg.flags = output_flags; > + > + /* > + * If the bus flags are provided in timing, use those even if the next > + * bridge specifies something > + */ > + if (bridge->timings && bridge->timings->input_bus_flags) > + bridge_state->input_bus_cfg.flags = > + bridge->timings->input_bus_flags; > } I think the comment could be more clear. Maybe something like: If legacy bus flags are provided in bridge->timings, use those as input flags instead of propagating the output flags. Other than that: Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 64f0effb52ac..2bbd6ffe82ce 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -975,6 +975,14 @@ drm_atomic_bridge_propagate_bus_flags(struct drm_bridge *bridge, * duplicate the "dummy propagation" logic. */ bridge_state->input_bus_cfg.flags = output_flags; + + /* + * If the bus flags are provided in timing, use those even if the next + * bridge specifies something + */ + if (bridge->timings && bridge->timings->input_bus_flags) + bridge_state->input_bus_cfg.flags = + bridge->timings->input_bus_flags; } /**
bus_flags can be specified by a bridge in the timings. If the bridge provides it, Override the bus_flags when propagating from next bridge. Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com> --- drivers/gpu/drm/drm_bridge.c | 8 ++++++++ 1 file changed, 8 insertions(+)