From patchwork Fri Nov 27 12:06:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Auld X-Patchwork-Id: 11936053 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65C2C64E7A for ; Fri, 27 Nov 2020 12:14:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B5CD208D5 for ; Fri, 27 Nov 2020 12:14:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B5CD208D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F4826EC95; Fri, 27 Nov 2020 12:12:01 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EEE06ED27; Fri, 27 Nov 2020 12:11:57 +0000 (UTC) IronPort-SDR: mw5Oe83fC04ZPPuHX0cchKGmTrQf1WkSm+EBxwIEMsP4E4NpUWdoqJOmweyw+QYx89G4PsywuS x7vblnCjJKLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9817"; a="257092969" X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="257092969" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 04:11:57 -0800 IronPort-SDR: FANwRbnkXGE8plQ89aEop5h8gcaZA8jDT2NXBq19IeDuqCFb+qZ+TbcxMQmthS3+AFObSeVsDr M1PcqOohvjng== X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="548029937" Received: from mjgleeso-mobl.ger.corp.intel.com (HELO mwauld-desk1.ger.corp.intel.com) ([10.251.85.2]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 04:11:55 -0800 From: Matthew Auld To: intel-gfx@lists.freedesktop.org Subject: [RFC PATCH 139/162] drm/i915/dg1: Keep engine awake across whole blit Date: Fri, 27 Nov 2020 12:06:55 +0000 Message-Id: <20201127120718.454037-140-matthew.auld@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201127120718.454037-1-matthew.auld@intel.com> References: <20201127120718.454037-1-matthew.auld@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Tvrtko Ursulin Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Tvrtko Ursulin Hold blitter engine power reference across the whole copy operation for efficiency. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c index 34bbefa6d67f..c84443e01ef1 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c @@ -1028,6 +1028,8 @@ int i915_window_blt_copy(struct drm_i915_gem_object *dst, spin_unlock(&i915->mm.window_queue.lock); + intel_engine_pm_get(ce->engine); + do { struct i915_request *rq; long timeout; @@ -1080,6 +1082,8 @@ int i915_window_blt_copy(struct drm_i915_gem_object *dst, flush_work(&ce->engine->retire_work); } while (remain); + intel_engine_pm_put(ce->engine); + spin_lock(&i915->mm.window_queue.lock); src_vma->size = BLT_WINDOW_SZ; dst_vma->size = BLT_WINDOW_SZ;