| Message ID | 20201209215807.75983-1-luben.tuikov@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sched: Add missing structure comment | expand |
Hi Luben, On Wed, 9 Dec 2020 16:58:07 -0500 Luben Tuikov <luben.tuikov@amd.com> wrote: > > Add a missing structure comment for the recently > added @list member. > > Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> > > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Christian König <christian.koenig@amd.com> The commit message tags should all be together at the end of the commit message (probably with your SoB last). Also: Fixes: 8935ff00e3b1 ("drm/scheduler: "node" --> "list"") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Thanks
On 2020-12-09 5:24 p.m., Stephen Rothwell wrote: > Hi Luben, > > On Wed, 9 Dec 2020 16:58:07 -0500 Luben Tuikov <luben.tuikov@amd.com> wrote: >> >> Add a missing structure comment for the recently >> added @list member. >> >> Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> >> >> Cc: Stephen Rothwell <sfr@canb.auug.org.au> >> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> >> Cc: Christian König <christian.koenig@amd.com> > > The commit message tags should all be together at the end of the commit > message (probably with your SoB last). Also: > > Fixes: 8935ff00e3b1 ("drm/scheduler: "node" --> "list"") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Right! I was just looking into this as the empty line up there didn't look good. I'll resubmit. Regards, Luben
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 2e0c368e19f6..975e8a67947f 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -171,10 +171,10 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f); * struct drm_sched_job - A job to be run by an entity. * * @queue_node: used to append this struct to the queue of jobs in an entity. + * @list: a job participates in a "pending" and "done" lists. * @sched: the scheduler instance on which this job is scheduled. * @s_fence: contains the fences for the scheduling of job. * @finish_cb: the callback for the finished fence. - * @node: used to append this struct to the @drm_gpu_scheduler.pending_list. * @id: a unique id assigned to each job scheduled on the scheduler. * @karma: increment on every hang caused by this job. If this exceeds the hang * limit of the scheduler then the job is marked guilty and will not
Add a missing structure comment for the recently added @list member. Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Christian König <christian.koenig@amd.com> --- include/drm/gpu_scheduler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)