| Message ID | 20201222040645.1323611-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: Drop redundant maxItems/items | expand |
Hi Rob, On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > preferred for a single entry while greater than 1 should have an 'items' > list. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jassi Brar <jaswinder.singh@linaro.org> > Cc: dri-devel@lists.freedesktop.org > Cc: dmaengine@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> With one comment below, Acked-by: Sam Ravnborg <sam@ravnborg.org> > --- > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > index 737c1f47b7de..54c361d4a7af 100644 > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > @@ -74,11 +74,8 @@ properties: > > phys: > maxItems: 1 > - items: > - - description: phandle + phy specifier pair. The description may help some people, so keeping the description and deleting maxItems would maybe be better. Sam
Hi Rob, Thank you for the patch. On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > preferred for a single entry while greater than 1 should have an 'items' > list. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jassi Brar <jaswinder.singh@linaro.org> > Cc: dri-devel@lists.freedesktop.org > Cc: dmaengine@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 - > Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 - > .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 -- > Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 - > Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 --- > 6 files changed, 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml > index 7b9d468c3e52..403d57977ee7 100644 > --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml > +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml > @@ -98,7 +98,6 @@ properties: > maxItems: 1 > > dmas: > - maxItems: 4 > items: > - description: Video layer, plane 0 (RGB or luma) > - description: Video layer, plane 1 (U/V or U) > diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml > index b548e4723936..c07eb6f2fc8d 100644 > --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml > @@ -73,7 +73,6 @@ properties: > maxItems: 1 > > clock-names: > - maxItems: 1 > items: > - const: fck > > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml > index d43791a2dde7..d07eb00b97c8 100644 > --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml > +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml > @@ -61,7 +61,6 @@ properties: > - description: low-priority non-secure > - description: high-priority non-secure > - description: Secure > - maxItems: 3 > > clocks: > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml > index e543a6123792..b55775e21de6 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml > @@ -44,7 +44,6 @@ properties: > maxItems: 3 > > clock-names: > - maxItems: 3 > items: > - const: hda > - const: hda2hdmi > @@ -54,7 +53,6 @@ properties: > maxItems: 3 > > reset-names: > - maxItems: 3 > items: > - const: hda > - const: hda2hdmi > diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml > index 0f078bd0a3e5..22603256ddf8 100644 > --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml > @@ -51,7 +51,6 @@ properties: > maxItems: 1 > > phy-names: > - maxItems: 1 > items: > - const: usb > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > index 737c1f47b7de..54c361d4a7af 100644 > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > @@ -74,11 +74,8 @@ properties: > > phys: > maxItems: 1 > - items: > - - description: phandle + phy specifier pair. > > phy-names: > - maxItems: 1 > items: > - const: usb >
On 21-12-20, 21:06, Rob Herring wrote: > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > preferred for a single entry while greater than 1 should have an 'items' > list. > > A meta-schema check for this is pending once these existing cases are > fixed. > --- > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 - > Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - Acked-By: Vinod Koul <vkoul@kernel.org>
On Mon, Dec 21, 2020 at 10:10 PM Rob Herring <robh@kernel.org> wrote: > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > preferred for a single entry while greater than 1 should have an 'items' > list. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jassi Brar <jaswinder.singh@linaro.org> > Cc: dri-devel@lists.freedesktop.org > Cc: dmaengine@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 - > Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 - > .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 -- > Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 - > Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 --- > 6 files changed, 9 deletions(-) Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > preferred for a single entry while greater than 1 should have an 'items' > list. Acked-by: Mark Brown <broonie@kernel.org>
On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Rob, > > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > > preferred for a single entry while greater than 1 should have an 'items' > > list. > > > > A meta-schema check for this is pending once these existing cases are > > fixed. > > > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Mark Brown <broonie@kernel.org> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: Jassi Brar <jaswinder.singh@linaro.org> > > Cc: dri-devel@lists.freedesktop.org > > Cc: dmaengine@vger.kernel.org > > Cc: alsa-devel@alsa-project.org > > Cc: linux-usb@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > With one comment below, > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > > --- > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > index 737c1f47b7de..54c361d4a7af 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > @@ -74,11 +74,8 @@ properties: > > > > phys: > > maxItems: 1 > > - items: > > - - description: phandle + phy specifier pair. > > The description may help some people, so keeping the > description and deleting maxItems would maybe be better. Do we really want to describe 'phys' hundreds of times? No. The question I ask on the descriptions is could it be generated instead. Rob
On Wed, Dec 23, 2020 at 10:54:26AM -0700, Rob Herring wrote: > On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > > > Hi Rob, > > > > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > > > preferred for a single entry while greater than 1 should have an 'items' > > > list. > > > > > > A meta-schema check for this is pending once these existing cases are > > > fixed. > > > > > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > Cc: Vinod Koul <vkoul@kernel.org> > > > Cc: Mark Brown <broonie@kernel.org> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Cc: Jassi Brar <jaswinder.singh@linaro.org> > > > Cc: dri-devel@lists.freedesktop.org > > > Cc: dmaengine@vger.kernel.org > > > Cc: alsa-devel@alsa-project.org > > > Cc: linux-usb@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > > With one comment below, > > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > > > > --- > > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > index 737c1f47b7de..54c361d4a7af 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > @@ -74,11 +74,8 @@ properties: > > > > > > phys: > > > maxItems: 1 > > > - items: > > > - - description: phandle + phy specifier pair. > > > > The description may help some people, so keeping the > > description and deleting maxItems would maybe be better. > > Do we really want to describe 'phys' hundreds of times? No. The > question I ask on the descriptions is could it be generated instead. I agree. If the description had mentioned why particular PHY was referenced, I would have kept that, but "the phy is a phy" is probably not something we want to duplicate everywhere.
Hi Rob, > > With one comment below, > > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > > > > --- > > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > index 737c1f47b7de..54c361d4a7af 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > @@ -74,11 +74,8 @@ properties: > > > > > > phys: > > > maxItems: 1 > > > - items: > > > - - description: phandle + phy specifier pair. > > > > The description may help some people, so keeping the > > description and deleting maxItems would maybe be better. > > Do we really want to describe 'phys' hundreds of times? No. Agree, for common properties we as a minimum want a phy-common.yaml or some such - and have the description exactly once. > The > question I ask on the descriptions is could it be generated instead. That could also be an idea, but assuming most people look at the source then the same "most people" would miss the generated descriptions. But to be clear - I see that phys: is a commonly used property so no problem to have the description dropped here. Ack still stands. Sam
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > preferred for a single entry while greater than 1 should have an 'items' > list. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jassi Brar <jaswinder.singh@linaro.org> > Cc: dri-devel@lists.freedesktop.org > Cc: dmaengine@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml index 7b9d468c3e52..403d57977ee7 100644 --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml @@ -98,7 +98,6 @@ properties: maxItems: 1 dmas: - maxItems: 4 items: - description: Video layer, plane 0 (RGB or luma) - description: Video layer, plane 1 (U/V or U) diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml index b548e4723936..c07eb6f2fc8d 100644 --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml @@ -73,7 +73,6 @@ properties: maxItems: 1 clock-names: - maxItems: 1 items: - const: fck diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml index d43791a2dde7..d07eb00b97c8 100644 --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml @@ -61,7 +61,6 @@ properties: - description: low-priority non-secure - description: high-priority non-secure - description: Secure - maxItems: 3 clocks: maxItems: 1 diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml index e543a6123792..b55775e21de6 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml @@ -44,7 +44,6 @@ properties: maxItems: 3 clock-names: - maxItems: 3 items: - const: hda - const: hda2hdmi @@ -54,7 +53,6 @@ properties: maxItems: 3 reset-names: - maxItems: 3 items: - const: hda - const: hda2hdmi diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml index 0f078bd0a3e5..22603256ddf8 100644 --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml @@ -51,7 +51,6 @@ properties: maxItems: 1 phy-names: - maxItems: 1 items: - const: usb diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml index 737c1f47b7de..54c361d4a7af 100644 --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml @@ -74,11 +74,8 @@ properties: phys: maxItems: 1 - items: - - description: phandle + phy specifier pair. phy-names: - maxItems: 1 items: - const: usb
'maxItems' equal to the 'items' list length is redundant. 'maxItems' is preferred for a single entry while greater than 1 should have an 'items' list. A meta-schema check for this is pending once these existing cases are fixed. Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Vinod Koul <vkoul@kernel.org> Cc: Mark Brown <broonie@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jassi Brar <jaswinder.singh@linaro.org> Cc: dri-devel@lists.freedesktop.org Cc: dmaengine@vger.kernel.org Cc: alsa-devel@alsa-project.org Cc: linux-usb@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 - Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 - .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 -- Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 - Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 --- 6 files changed, 9 deletions(-)