| Message ID | 20201225082441.10412-1-jitao.shi@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type | expand |
Hi, Jitao: Jitao Shi <jitao.shi@mediatek.com> 於 2020年12月25日 週五 下午4:30寫道： > > The interrupt trigger is already set by OF. When do devm_request_irq() > in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type > again. > > Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633 I remove change-id and apply this patch to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 4a188a942c38..1d6248930bdf 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) > goto err_unregister_host; > } > > - irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW); > ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq, > - IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi); > + IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi); > if (ret) { > dev_err(&pdev->dev, "failed to request mediatek dsi irq\n"); > goto err_unregister_host; > -- > 2.12.5 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 4a188a942c38..1d6248930bdf 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) goto err_unregister_host; } - irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW); ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq, - IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi); + IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi); if (ret) { dev_err(&pdev->dev, "failed to request mediatek dsi irq\n"); goto err_unregister_host;
The interrupt trigger is already set by OF. When do devm_request_irq() in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type again. Change-Id: Ie59d7bd9a44a130420890b169cc2e6fee3ad7633 Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)